From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v2] x86: Fixup IRQs when CPUs go down during shutdown Date: Wed, 2 Dec 2015 13:53:41 +0000 Message-ID: <565EF7E5.9020305@citrix.com> References: <1449063981-31486-1-git-send-email-ross.lagerwall@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1449063981-31486-1-git-send-email-ross.lagerwall@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ross Lagerwall , xen-devel@lists.xen.org Cc: Jan Beulich List-Id: xen-devel@lists.xenproject.org On 02/12/15 13:46, Ross Lagerwall wrote: > @@ -298,6 +299,13 @@ static void stop_this_cpu(void *dummy) > void smp_send_stop(void) > { > int timeout = 10; > + cpumask_t online; > + > + cpumask_clear(&online); > + cpumask_set_cpu(smp_processor_id(), &online); You can avoid this intermediate variable with cpumask_of(smp_processor_id()) There are a set of pre-canned cpumasks with a single cpu set. ~Andrew