Re: [Qemu-devel] [PATCH v14 13/15] qapi: Enforce (or whitelist) case conventions on qapi members

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1582 bytes --]

On 12/02/2015 04:51 AM, Markus Armbruster wrote:
> This is the fixup I mentioned in the v13 thread.  The "Unreachable and
> not implemented" hunk should probably be its own patch.
> 

> +++ b/tests/qapi-schema/args-member-case.err
> @@ -1 +1 @@
> -tests/qapi-schema/args-member-case.json:3: Member 'Arg' of 'Foo' should use lowercase
> +tests/qapi-schema/args-member-case.json:3: 'Arg' (parameter of Foo) should not use uppercase

Oh, and I forgot to use the name 'no-way-this-will-get-whitelisted' (or
NoWayThisWillGetWhitelisted) as suggested in v13, if you want to also
change naming.

> diff --git a/tests/qapi-schema/enum-member-case.err b/tests/qapi-schema/enum-member-case.err
> index e50b12a..a1d67c6 100644
> --- a/tests/qapi-schema/enum-member-case.err
> +++ b/tests/qapi-schema/enum-member-case.err
> @@ -1 +1 @@
> -tests/qapi-schema/enum-member-case.json:3: Member 'Value' of 'Foo' should use lowercase
> +tests/qapi-schema/enum-member-case.json:3: 'Value' (member of Foo) should not use uppercase
> diff --git a/tests/qapi-schema/union-branch-case.err b/tests/qapi-schema/union-branch-case.err
> index 6c6b740..0b4c1b5 100644
> --- a/tests/qapi-schema/union-branch-case.err
> +++ b/tests/qapi-schema/union-branch-case.err
> @@ -1 +1 @@
> -tests/qapi-schema/union-branch-case.json:3: Member 'Branch' of 'Foo' should use lowercase
> +tests/qapi-schema/union-branch-case.json:3: 'Branch' (branch of Foo) should not use uppercase
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]