From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCH v2 21/21] arm64: KVM: Remove weak attributes Date: Wed, 02 Dec 2015 17:52:51 +0000 Message-ID: <565F2FF3.2030804@arm.com> References: <1448650215-15218-1-git-send-email-marc.zyngier@arm.com> <1448650215-15218-22-git-send-email-marc.zyngier@arm.com> <20151202114732.GA18376@cbox> <565F0C8D.9010505@arm.com> <20151202162134.GN18376@cbox> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id EA9604979C for ; Wed, 2 Dec 2015 12:51:26 -0500 (EST) Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4Y-5JOEYwfeh for ; Wed, 2 Dec 2015 12:51:25 -0500 (EST) Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C6F0D49630 for ; Wed, 2 Dec 2015 12:51:25 -0500 (EST) In-Reply-To: <20151202162134.GN18376@cbox> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: Christoffer Dall Cc: kvm@vger.kernel.org, Ard Biesheuvel , Catalin Marinas , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org List-Id: kvmarm@lists.cs.columbia.edu On 02/12/15 16:21, Christoffer Dall wrote: > On Wed, Dec 02, 2015 at 03:21:49PM +0000, Marc Zyngier wrote: >> On 02/12/15 11:47, Christoffer Dall wrote: >>> On Fri, Nov 27, 2015 at 06:50:15PM +0000, Marc Zyngier wrote: >>>> As we've now switched to the new world switch implementation, >>>> remove the weak attributes, as nobody is supposed to override >>>> it anymore. >>> >>> Why not remove the aliases and change the callers? >> >> This is likely to be a bigger patch, and it would affect the 32bit as >> well. So far, I'm choosing to keep things the same. Another solution >> would be to completely drop the aliases, and just rename the new >> function to have the old names. >> >> I don't mind either way. >> > I didn't think of the 32-bit side. I think eventually we should get rid > of the aliases and just have the funcitons named as they are called, but > there's no rush. We can wait until we've the done the 32-bit side if > you prefer. Probably safest. We're already changing a lot of things. Hopefully for 4.6 I'll have the 32bit side sorted. M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 From: marc.zyngier@arm.com (Marc Zyngier) Date: Wed, 02 Dec 2015 17:52:51 +0000 Subject: [PATCH v2 21/21] arm64: KVM: Remove weak attributes In-Reply-To: <20151202162134.GN18376@cbox> References: <1448650215-15218-1-git-send-email-marc.zyngier@arm.com> <1448650215-15218-22-git-send-email-marc.zyngier@arm.com> <20151202114732.GA18376@cbox> <565F0C8D.9010505@arm.com> <20151202162134.GN18376@cbox> Message-ID: <565F2FF3.2030804@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/12/15 16:21, Christoffer Dall wrote: > On Wed, Dec 02, 2015 at 03:21:49PM +0000, Marc Zyngier wrote: >> On 02/12/15 11:47, Christoffer Dall wrote: >>> On Fri, Nov 27, 2015 at 06:50:15PM +0000, Marc Zyngier wrote: >>>> As we've now switched to the new world switch implementation, >>>> remove the weak attributes, as nobody is supposed to override >>>> it anymore. >>> >>> Why not remove the aliases and change the callers? >> >> This is likely to be a bigger patch, and it would affect the 32bit as >> well. So far, I'm choosing to keep things the same. Another solution >> would be to completely drop the aliases, and just rename the new >> function to have the old names. >> >> I don't mind either way. >> > I didn't think of the 32-bit side. I think eventually we should get rid > of the aliases and just have the funcitons named as they are called, but > there's no rush. We can wait until we've the done the 32-bit side if > you prefer. Probably safest. We're already changing a lot of things. Hopefully for 4.6 I'll have the 32bit side sorted. M. -- Jazz is not dead. It just smells funny...