From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCHv6] 04/28] build: convert HAS_PASSTHROUGH use to Kconfig Date: Wed, 2 Dec 2015 18:36:58 -0600 Message-ID: <565F8EAA.2050508@cardoe.com> References: <1448387538-12208-1-git-send-email-cardoe@cardoe.com> <1448387538-12208-5-git-send-email-cardoe@cardoe.com> <565C704D02000078000BA449@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3000588734159797119==" Return-path: In-Reply-To: <565C704D02000078000BA449@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Keir Fraser , Ian Campbell , Andrew Cooper , xen-devel@lists.xen.org, Stefano Stabellini , Daniel De Graaf List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============3000588734159797119== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hFcmqTOFiPsvkoxv1uuhcp4Ns25xJc1q2" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hFcmqTOFiPsvkoxv1uuhcp4Ns25xJc1q2 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 11/30/15 8:50 AM, Jan Beulich wrote: >>>> On 24.11.15 at 18:51, wrote: >> --- a/xen/arch/x86/Kconfig >> +++ b/xen/arch/x86/Kconfig >> @@ -3,6 +3,7 @@ config X86_64 >> =20 >> config X86 >> def_bool y >> + select HAS_PASSTHROUGH >> select HAS_GDBSX >=20 > Please get these sorted alphabetically from the beginning. >=20 >> --- /dev/null >> +++ b/xen/drivers/passthrough/Kconfig >> @@ -0,0 +1,4 @@ >> + >> +# Select HAS_PASSTHROUGH if PCI pass through is supported >> +config HAS_PASSTHROUGH >> + bool >=20 > s/PCI/device/ in the comment please. >=20 >> @@ -348,9 +348,9 @@ static XSM_INLINE int xsm_deassign_device(XSM_DEFA= ULT_ARG struct domain *d, uint >> return xsm_default_action(action, current->domain, d); >> } >> =20 >> -#endif /* HAS_PASSTHROUGH && HAS_PCI */ >> +#endif /* CONFIG_HAS_PASSTHROUGH && HAS_PCI */ >=20 > I don't think fiddling with trailing comments like this one is really > useful - the connection is clear also without CONFIG_ prefix. >=20 > Jan >=20 Most of this series was mechanical early on (e.g. sed). I can selectively undo updating the comments if that's desirable. --=20 Doug Goldstein --hFcmqTOFiPsvkoxv1uuhcp4Ns25xJc1q2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWX46qXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUluwP/iRo9iLzjcjQmQ+PwyE7xV9j ja3oDfemTi03vTJdtuR243Gq+aU8U7egYlJ1ndH9fgT9sPVPC32De94SD3jf/Fl/ 8EoORG4vJh+PeOmnIXS+L7F2lsT++krqX8Tnezb6KIkIioPSHoWBSfvpALbOUuyT jVYrQVWzFbTDy2mRVEENUI4Yj5p9IQWSLPz+LohxxiKZQ4n28MTcbtiABnuZRglZ a8L4BaGOdt41+5dm0F4j3JvxouLZHS9VaOAiJb7PeYqLjCzWSxhRtc9rsXXCyMvX TgwDLSQUxG5IECfpQfonTOt52m8baTmr8qj3Ne8gTBsD8NWZbpqsZxfbVIABHrHl 1Nz325KttlAbUHjjil8NSLGdpN1ZzRRKGa8fOYYmSvJiPfgAB7pMD6t6s0AvV+Nd JFHOoffAVo+DIpUVMNWxgOZDd3Hd9oBIjPRF1eR3gEtjR/kzqqrgdvP1sfz44oZ9 Rz7yg5FnZ5w335d4s2+MoOTtpM723CYE3T+F7c7Y75c7I1z6PKqMm9OJq2xp2PjR voS2B89Lf0MOFf3dDykaGgMIlMahoeKLEj4jmLkuqDZLU50oBqbSB9DFg6SSvxc5 bUoMvkQbpxb0GMYWbifgHro/+f/ETRqzG52jeHND2LSC7pjE1J6QN+Rg9ud7Z6TD m6IG5jfV25vmEgGrZqLF =p9ej -----END PGP SIGNATURE----- --hFcmqTOFiPsvkoxv1uuhcp4Ns25xJc1q2-- --===============3000588734159797119== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============3000588734159797119==--