From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCHv6] 08/28] build: convert HAS_IOPORTS use to Kconfig Date: Wed, 2 Dec 2015 18:39:44 -0600 Message-ID: <565F8F50.6050006@cardoe.com> References: <1448387538-12208-1-git-send-email-cardoe@cardoe.com> <1448387538-12208-9-git-send-email-cardoe@cardoe.com> <565C71C002000078000BA477@prv-mh.provo.novell.com> <565C72E502000078000BA48C@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4533218150825739253==" Return-path: In-Reply-To: <565C72E502000078000BA48C@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Andrew Cooper , Keir Fraser , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============4533218150825739253== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="MSnCc97uVaFlmoFvPAjM7u9SAqttUjggt" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --MSnCc97uVaFlmoFvPAjM7u9SAqttUjggt Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 11/30/15 9:01 AM, Jan Beulich wrote: >>>> On 30.11.15 at 15:56, wrote: >>>>> On 24.11.15 at 18:51, wrote: >>> --- a/xen/drivers/char/Kconfig >>> +++ b/xen/drivers/char/Kconfig >>> @@ -3,3 +3,8 @@ config UART_NS16550 >>> bool "16550-series UART support" >>> help >>> This selects the 16550-series UART support. For most systems, say= Y. >>> + >>> +# Select HAS_IOPORTS if 16550 has I/O ports >>> +config HAS_IOPORTS >>> + bool >>> + depends on UART_NS16550 >> >> Even if only used in ns16550.c, this is a generic setting and hence >> belongs in common/Kconfig and should be selected by the arches >> as needed. >=20 > I see it is being selected, but the "depends" here is bogus: When > there is no prompt and no default, there should also not be any > dependency. >=20 > Jan >=20 The dependency just means it can't be enabled unless the dependency is met. I believe its valid for the case when the config system starts and the user disables UART_NS16550, then HAS_IOPORTS would need to be disabled. Without the dependency then this wouldn't be turned off when UART_NS16550 is turned off. There are a number of examples of this in the Linux kernel's usage of kconfig. --=20 Doug Goldstein --MSnCc97uVaFlmoFvPAjM7u9SAqttUjggt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWX49QXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvU1asP/31HHpZaXrmo2qx3dFzftpyi jWz93oLMFbvNLOkQmvyhg64MsFeNyAen/nbz2cj5Zi2alyEtzeRkZTGbjFqWMWX3 6f3YLp+J+1gJu+TXjpUBQ0cFGG8SK0aulqdLz5h5SxIXXIDnP5JYLvqcMH4Vl9fS I0SqZvY+ESfB7p1TxFxURGN5v1IZ1sGYxT2q8iyMyOHSMBlv/fZ4FSWdvIpf2ZfH g7FblWtTinXSa8XLtY0b2pnamaJx28/cKSUXB3B44IhuWCzxKKroavExnglCDC1C g+b1yK2FLd+nuF4oROxtO96scoVFnhpfbOadOh56s/1iP5+8AVYptRzrH4oC3Ry8 AUAj/0wyxnaSu4BJ3tC9lh0aj46Jl1dV0vOF2jy49VDZ5I0A2SADWXJjw4pmEF2i /AjNhx8aEFz855W9ZB3bhkF758fgns7CXjCQbs7Tk+wOPcsmNLrTbiNMxKBfPgdd Qj0BP5wUzNqyYW/Uxc+yn96HG8iAXC+Fu3LZBCHjYo+/BNigFHrCp+DLAJiVHNP4 jK7pXPIaDYLjRO1RKHYtg7Pt9YyEWVqtHLH99vSGPu4ElD3Pq5BbQ8aeZi6745tX oliXO6mkMNjKzovT2Z3AypDyEqSLDreOA7DghNjNVjA2Kwhr7+wvN1sO+TWHtEWb C/D+ioNbrrVxI/7ou/YD =Thbj -----END PGP SIGNATURE----- --MSnCc97uVaFlmoFvPAjM7u9SAqttUjggt-- --===============4533218150825739253== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============4533218150825739253==--