From: Timur Tabi <timur@tabi.org>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v2] video: fbdev: fsl: fix kernel crash when diu_ops is not implemented
Date: Thu, 03 Dec 2015 01:12:49 +0000 [thread overview]
Message-ID: <565F9711.1090009@tabi.org> (raw)
In-Reply-To: <1449062416-12245-1-git-send-email-dongsheng.wang@freescale.com>
Dongsheng Wang wrote:
> From: Wang Dongsheng <dongsheng.wang@freescale.com>
>
> If diu_ops is not implemented on platform, kernel will access a null
> pointer. we need to check this pointer in diu initialization.
Please fix capitalization: We, DIU, NULL.
> @@ -1915,6 +1918,10 @@ static int __init fsl_diu_init(void)
> #else
> monitor_port = fsl_diu_name_to_port(monitor_string);
> #endif
> +
> + if (!diu_ops.set_pixel_clock)
> + return -ENODEV;
> +
Please add a comment explaining that set_pixel_clock is required, so if
it isn't set, then that means that there is no platform support for the DIU.
prev parent reply other threads:[~2015-12-03 1:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 13:20 [PATCH v2] video: fbdev: fsl: fix kernel crash when diu_ops is not implemented Dongsheng Wang
2015-12-03 1:12 ` Timur Tabi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565F9711.1090009@tabi.org \
--to=timur@tabi.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.