From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCHv6] 00/28] Kconfig conversion Date: Wed, 2 Dec 2015 21:02:25 -0600 Message-ID: <565FB0C1.8010101@cardoe.com> References: <1448387538-12208-1-git-send-email-cardoe@cardoe.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6441379903910088143==" Return-path: In-Reply-To: <1448387538-12208-1-git-send-email-cardoe@cardoe.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Ian Jackson , Jan Beulich , Andrew Cooper , Wei Liu , Keir Fraser , Tim Deegan , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============6441379903910088143== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="t4I2QJjgGfnO4xtXNRFFBu3S3UGAoxI3h" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --t4I2QJjgGfnO4xtXNRFFBu3S3UGAoxI3h Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 11/24/15 11:51 AM, Doug Goldstein wrote: > The following series is a follow on to the Kconfig conversion patch ser= ies. > There are still more components to convert however this is the bare min= imal > to get everything working and get the options out of the existing makef= iles. >=20 > The CONFIG_HAS_ variables are there to match the behavior of the Linux > CONFIG_HAVE_ variables. The purpose is to say that this hardware/profil= e/env > supports this option while the CONFIG_ variable states that this option= was > requested on/off by user intervention. >=20 > The UARTs are now uniformly prefixed as CONFIG_UART_ and dropping most = of the > CONFIG_HAS_ labeling for them. This means they are now user selectable = as > requested by Julien Grall in the prior review. The question I've got is= > the old config was just for selecting defaults. Users could enable the = OMAP > UART for arm64 for example but I'm not sure if that's valid. Currently = this > patchset makes those UARTs not user selectable if they were not previou= sly > defaulted on. But I would like some feedback on this if possible. >=20 > Ultimately my goal is to allow for more parts of the hypervisor to be t= urned > off at compile time and potentially make it easier to include more > experimental features by others which can be turned off by default. Als= o to > provide the one true location for all possible knobs in the source code= =2E >=20 > The patch series can be grabbed at: > https://github.com/cardoe/xen/tree/kconfig_v6 >=20 > Changes since v5: > - added Andrew Cooper's Acked-by and Tested-by > - rebased to resolve conflict with NUMA changes in staging (minor confl= ict) >=20 > Changes since v4: > - v4 was an oops and was a resend of v3. So the 'Changes since v3' appl= y here. >=20 > Changes since v3: > - fix dependency inversion causing options to appear to flip back on (h= i kexec) > - separate out wiring up Kconfig and then using it in the build (added = patch 3) > - dropped the old patch 3 > - changed UART configs to be prefixed as CONFIG_UART_ > - changed ARM UART defaults >=20 > Changes since v2: > - drop x86_32 support (patch 2) > - fix make defconfig (patch 2) > - fix 'make -C xen' vs 'cd xen && make' behaving differently (patch 2) > - fix for ARM64 builds (added patch 3) > - At this point all targets are tested on x86_64, arm32, and arm64 with= > fresh clones and rebuilds. >=20 > Changes since v1: > - hopefully addressed all review comments > - added CCs to all maintainers from get_maintainer.pl as requested > - drop Kbuild to build Kconfig and instead port the Makefile to the Xen= env > - add support for xconfig/gconfig > - include Kconfig docs from Linux >=20 All, There's been quite a few comments on this series and I'll admit I'm a bit lost as to the requested direction for the series so just to clear things up I'm going to send this out and address all the items before the next repost. My goal is to save you all time as reviewers so that hopefully you'll only have to review one more series. 1. Remove the KEXEC patch from this series and add it to the follow-on series? 2. Drop UART changes and just go back to the mechanical changes that enable the UARTs on ARM as they are today. The early patches failed to remove the items from config/arm{32,64}.mk but remedy that. 3. sync the (A) entire linux/scripts/kconfig directory or (B) basics from linux/scripts/kconfig or (C) basics + frontends for future series when user-configurable options are presented. Note: Option B will require not just copying files but making modifications (read: forking) until a more complete copy is brought over. 4. Should I rename xen/scripts/kconfig to xen/tools/kconfig? 5. Should I drop as much $(BASEDIR) usage as possible? --=20 Doug Goldstein --t4I2QJjgGfnO4xtXNRFFBu3S3UGAoxI3h Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWX7DHXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUsqwP/33x1lG42ZN6fzgX6KxOzQ+B 9S5cyWTFkOm4ApYPb/EvHVrvORTKxTUWipcrFEgT6jOYG0Be8+umpn9eWAzjLsUm y5cyrLuPcPZHl3WZIlQu6o+4HYS9GjlCjvCTN/mPM0Kgfk0EU7FELtMvA+kYWxV8 KhhkB2b3kTyzyXSThZ8gc466GZSUidWH9elWOHoocPnL2v8amN8M3AuJDpnjqXOL Km7J3ijxvagIn0Aa/dEGSaiYwSbRdHzyanQ2/S+nnT9b7N2bLSVkwJjMWlVoIDvJ 1jxPiJ3lRAX6vt3rWhyaK72nRoefdmOD88hMUz7Dt0TlN5fA8f1ePqfzXCZdh26n Xmlj8Z543WbbFCPfuu4QYIsniUJs/c1jZQDt9AsrnCr2yH98qXRXG8UnX/RolpNY Q+qQAA6vzAPr8aWTDbsMzLLxCuGd2cj5G2f9kRhCPNiIa9ysFqwO4HbEGdzwtkMp SM6ysbht4oKI/F3dzLYl/6G6ismuKRI+fA26jy5olvMqbepxDkKI2c46X+jzmbhS lzQl8Gcr5DkWDb8UGcxFhoqT/asiQfZhdrKFu14hevK2jDUK7tqjPMZufrmp2hP3 7FdDqfpLHi7SynQEzF97nbXvjF5HV7GbaaaBmCvUvcfw+qziutAOgsGDR+Iq+E07 3HIa7BeDejtsSZVH025A =xDkF -----END PGP SIGNATURE----- --t4I2QJjgGfnO4xtXNRFFBu3S3UGAoxI3h-- --===============6441379903910088143== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============6441379903910088143==--