From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [V2 PATCH 8/9] x86/hvm: pkeys, add xstate support for pkeys Date: Thu, 3 Dec 2015 10:56:40 +0000 Message-ID: <56601FE8.8070704@citrix.com> References: <1448617923-10884-1-git-send-email-huaitong.han@intel.com> <1448617923-10884-9-git-send-email-huaitong.han@intel.com> <565E068A.3030803@citrix.com> <1449040852.4010.3.camel@intel.com> <565EE48502000078000BB374@prv-mh.provo.novell.com> <1449107932.4187.4.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1449107932.4187.4.camel@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Han, Huaitong" , "JBeulich@suse.com" Cc: "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 03/12/15 01:58, Han, Huaitong wrote: > On Wed, 2015-12-02 at 04:31 -0700, Jan Beulich wrote: >>>>> On 02.12.15 at 08:20, wrote: >>>> Does this even compile? There is already >>>> >>>> static void *get_xsave_addr(void *xsave, unsigned int >>>> xfeature_idx) >>>> >>>> higher in the same file. >>>> >>>> That function should be augmented to take a struct xsave_struct >>>> *xsave, >>>> look at whether the representation is compressed or not, and use >>>> the >>>> appropriate offset array. >>>> >>> Just because I have pulled staging branch when "static void >>> *get_xsave_addr(void *xsave, unsigned int xfeature_idx)" is not >>> added. >> Yet you use the function on patch 7 already... > The function used by patch 7 has same name but is added by me. You must ensure that your patch series compiles and functions correctly at each patch boundary. This is for bisectability. ~Andrew