From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCHv6] 27/28] build: convert CONFIG_COMPAT to Kconfig Date: Thu, 3 Dec 2015 06:52:04 -0600 Message-ID: <56603AF4.3040805@cardoe.com> References: <1448387538-12208-1-git-send-email-cardoe@cardoe.com> <1448387538-12208-28-git-send-email-cardoe@cardoe.com> <565C76F302000078000BA4F8@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0766333416432688676==" Return-path: In-Reply-To: <565C76F302000078000BA4F8@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Andrew Cooper , Keir Fraser , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============0766333416432688676== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9Ot88iQDfwpg9o5QeROMcdw0cqDqLDVD0" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9Ot88iQDfwpg9o5QeROMcdw0cqDqLDVD0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 11/30/15 9:18 AM, Jan Beulich wrote: >>>> On 24.11.15 at 18:52, wrote: >> --- >> xen/arch/x86/Kconfig | 7 +++++++ >> 1 file changed, 7 insertions(+) >=20 > This can't be complete - you ought to be deleting the current definitio= n. I don't understand? >=20 >> --- a/xen/arch/x86/Kconfig >> +++ b/xen/arch/x86/Kconfig >> @@ -25,6 +25,13 @@ config ARCH_DEFCONFIG >> =20 >> menu "Architecture Features" >> =20 >> +config COMPAT >> + def_bool y >> + help >> + 32-bit interface support on 64-bit Xen which is used for both >> + HVM and PV guests. HVMLoader makes 32-bit hypercalls irrespective >> + of the destination runmode of the guest. >=20 > I also don't think help text is very useful here, as it won't appear > anywhere (and due to the hvmloader needs it's also not very > likely to become a user selectable option going forward). >=20 > Jan >=20 This wasn't meant to be a user-selectable option. The help text is actually based on a conversation I had with Andrew Cooper on IRC. During the RFC of the kconfig patch series I had suggested (and it seemed like some liked it), that even for options that were not user facing that the Kconfig file, that defines the CONFIG_ variable could hold information about what it does since there is often a lack of information about what a CONFIG_ variable is for. This is my attempt at starting that. I can convert it to a plain comment. But it seems better to have some kind of documentation on these variables in one place and that place would make sense to be where they are defined. --=20 Doug Goldstein --9Ot88iQDfwpg9o5QeROMcdw0cqDqLDVD0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWYDr3XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvU8GMP/R1iVrc2Xf2++sMfrzTiym15 Bx7cSRTdaGMv3tRRH0sefGqqPMeoE14PkErJ4pjvsmxypeNKDX1aXUPnThu2Anay EUrn5zTkHK0SdvY2TUKjex8l3qqkXDpMYnAeLDa6+6xkWkPmy1fWyUADW6rkL6b2 s+XbqBDg7mnADbpKVXwNtalpK/F2UPwlJVZMDgeVzRxqSTPo92+LO/J6/urdEfXc 9Ql+cYv2lV5ZcOua3uzqBZ113DvWbWtegp8fgsZYTmYp3qwsyhmT1oGuSnCb4uSZ 19wbsYtN1hPO2w44TRrk0gHHZxi7JETyqZLujj3DyYKHslxButklqUsxuey7FGGO S+2WCHkeMOB9m53u89OKneKKzvTNzqSd7e5CNUisNPkc6njVe6ya7ToqubdjDwQW Sbum/3HE0kUupGliMI0cs6wF/JMCJ1PLA3UVpa1CfZuANipo+hSK69daKt0ABQFy H8wICB+heJAR7Dc9KfZKeTVDB+QfCwJC8Kdnx/mI0md5bxFnYwu9dPoZgbhEVLc3 aVLpAeBrZD6w3vB4oCSIjqeAAqP+WTyrEs8g6ey3FUvg1JnRMicfUOKH9YGDNa00 jGMrSPp15G1pzW/pvV3PX8oChp7E0ylR5HHTnagCbiNzoWtmg8+CJR376jkUGlQK NoHN4DRWIPPta1jh1Xti =qFht -----END PGP SIGNATURE----- --9Ot88iQDfwpg9o5QeROMcdw0cqDqLDVD0-- --===============0766333416432688676== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============0766333416432688676==--