From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boszormenyi Zoltan Subject: Re: [PATCH] drm/radeon: Retry DDC probing on DVI on failure if we got an HPD interrupt Date: Thu, 3 Dec 2015 15:58:06 +0100 Message-ID: <5660587E.7050801@pr.hu> References: <1448034740-30193-1-git-send-email-cpaul@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail9.pr.hu (mail9.pr.hu [87.242.0.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id DEC856E171 for ; Thu, 3 Dec 2015 07:33:51 -0800 (PST) In-Reply-To: <1448034740-30193-1-git-send-email-cpaul@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: cpaul@redhat.com, Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Jerome Glisse , Benjamin Tissoires List-Id: dri-devel@lists.freedesktop.org MjAxNS0xMS0yMCAxNjo1MiBrZWx0ZXrDqXNzZWwsIGNwYXVsQHJlZGhhdC5jb20gw61ydGE6Cj4g RnJvbTogU3RlcGhlbiBDaGFuZGxlciBQYXVsIDxjcGF1bEByZWRoYXQuY29tPgo+Cj4gSFBEIHNp Z25hbHMgb24gRFZJIHBvcnRzIGNhbiBiZSBmaXJlZCBvZmYgYmVmb3JlIHRoZSBwaW5zIHJlcXVp cmVkIGZvcgo+IEREQyBwcm9iaW5nIGFjdHVhbGx5IG1ha2UgY29udGFjdCwgZHVlIHRvIHRoZSBw aW5zIGZvciBIUEQgbWFraW5nCj4gY29udGFjdCBmaXJzdC4gVGhpcyByZXN1bHRzIGluIGEgSFBE IHNpZ25hbCBiZWluZyBhc3NlcnRlZCBidXQgRERDCj4gcHJvYmluZyBmYWlsaW5nLCByZXN1bHRp bmcgaW4gaG90cGx1Z2dpbmcgb2NjYXNpb25hbGx5IGZhaWxpbmcuCj4KPiBUaGlzIGlzIHNvbWV3 aGF0IHJhcmUgb24gbW9zdCBjYXJkcyAoZGVwZW5kaW5nIG9uIHdoYXQgYW5nbGUgeW91IHBsdWcK PiB0aGUgRFZJIGNvbm5lY3RvciBpbiksIGJ1dCBvbiBzb21lIGNhcmRzIGl0IGhhcHBlbnMgY29u c3RhbnRseS4gVGhlCj4gUmFkZW9uIFI1IG9uIHRoZSBtYWNoaW5lIHVzZWQgZm9yIHRlc3Rpbmcg dGhpcyBwYXRjaCBmb3IgaW5zdGFuY2UsIHJ1bnMKPiBpbnRvIHRoaXMgaXNzdWUganVzdCBhYm91 dCBldmVyeSB0aW1lIEkgdHJ5IHRvIGhvdHBsdWcgYSBEVkkgbW9uaXRvciBhbmQKPiBhcyBhIHJl c3VsdCBob3RwbHVnZ2luZyBhbG1vc3QgbmV2ZXIgd29ya3MuCj4KPiBSZXNjaGVkdWxpbmcgdGhl IGhvdHBsdWcgd29yayBmb3IgYSBzZWNvbmQgd2hlbiB3ZSBydW4gaW50byBhbiBIUEQKPiBzaWdu YWwgd2l0aCBhIGZhaWxpbmcgRERDIHByb2JlIHVzdWFsbHkgZ2l2ZXMgZW5vdWdoIHRpbWUgZm9y IHRoZSByZXN0Cj4gb2YgdGhlIGNvbm5lY3RvcidzIHBpbnMgdG8gbWFrZSBjb250YWN0LCBhbmQg Zml4ZXMgdGhpcyBpc3N1ZS4KPgo+IFNpZ25lZC1vZmYtYnk6IFN0ZXBoZW4gQ2hhbmRsZXIgUGF1 bCA8Y3BhdWxAcmVkaGF0LmNvbT4KPiAtLS0KPiBTbyB0aGlzIG9uZSBoYXMga2luZCBvZiBiZWVu IGEgdG91Z2ggc2VsbCB3aXRoIEplcm9tZSwgbW9zdGx5IGJlY2F1c2UgaXQncwo+IHNvbWV3aGF0 IG9mIGEgaGFjay4gVW5mb3J0dW5hdGVseSBob3dldmVyIEkndmUgbWFuYWdlZCB0byBmaW5kIG1h Y2hpbmVzIHdoZXJlCj4gRFZJIGhvdHBsdWdnaW5nIGxpdGVyYWxseSBkb2Vzbid0IHdvcmsgd2l0 aG91dCBhIHBhdGNoIGxpa2UgdGhpcy4gV2UndmUgYWxyZWFkeQo+IHRyaWVkIGEgY291cGxlIG9m IHdheXMgb2YgaGFuZGxpbmcgdGhlIHNpdHVhdGlvbiBvZiByZXRyaWdnZXJpbmcgZGRjIHByb2Jl czoKPgo+ICogVHJ5aW5nIHRoZSBEREMgcHJvYmUgaW4gdGhlIHJhZGVvbl9kdmlfZGV0ZWN0KCkg ZnVuY3Rpb24gbXVsdGlwbGUgdGltZXMuCj4gKiBUcnlpbmcgdG8gcmVzY2hlZHVsZSB0aGUgaG90 cGx1Z193b3JrIHRhc2sgd2hlbmV2ZXIgRERDIHByb2JpbmcgZmFpbHMgb24gRFZJCj4gICBidXQg d2UgZ290IGEgaHBkIHNpZ25hbCAodGhpcyBlbmRlZCB1cCBiZWluZyBhIG11Y2ggbW9yZSBjb21w bGljYXRlZCBwYXRjaAo+ICAgdGhlbiBhbnRpY2lwYXRlZCkKPiAqIERvaW5nIHdoYXQgd2UgZG8g cmlnaHQgbm93LCB3aGljaCBpcyBqdXN0IHRyaWdnZXJpbmcgdXNlcnNwYWNlIHRvIHJlc2NhbiBh bGwKPiAgIHRoZSBwb3J0cyB3aGVuIHRoZSBocGQgc2lnbmFsIGlzIGFzc2VydGVkIGJ5IHRoZSBE VkkgcG9ydCBidXQgdGhlcmUncyBubyBEREMKPiAgIHByb2JlLCBhbmQgcmVwZWF0aW5nIHVudGls IGF0IGxlYXN0IGEgc2Vjb25kIHBhc3Nlcy4KPgo+IEFsbCBvZiB0aGVzZSBhY3R1YWxseSB3b3Jr LCBidXQgSSBndWVzcyBpdCdzIGEgcXVlc3Rpb24gb2Ygd2hpY2ggb25lIGlzIGxlc3Mgb2YKPiBh IGhhY2suIElmIGFueW9uZSBoZXJlIGNhbiB0aGluayBvZiBhIGNsZWFuZXIgd2F5IG9mIGhhbmRs aW5nIHRoaXMgZmVlbCBmcmVlIHRvCj4gbGV0IG1lIGtub3cuCj4KPiAgZHJpdmVycy9ncHUvZHJt L3JhZGVvbi9yYWRlb24uaCAgICAgICAgICAgIHwgIDMgKysrCj4gIGRyaXZlcnMvZ3B1L2RybS9y YWRlb24vcmFkZW9uX2Nvbm5lY3RvcnMuYyB8IDIwICsrKysrKysrKysrKysrKysrLS0tCj4gIGRy aXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX2lycV9rbXMuYyAgICB8ICAyICsrCj4gIDMgZmls ZXMgY2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbi5oIGIvZHJpdmVycy9ncHUvZHJtL3Jh ZGVvbi9yYWRlb24uaAo+IGluZGV4IGI2Y2JkODEuLmQ2M2YwZmUgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL3JhZGVvbi9yYWRlb24uaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yYWRl b24vcmFkZW9uLmgKPiBAQCAtMjQ2MCw2ICsyNDYwLDkgQEAgc3RydWN0IHJhZGVvbl9kZXZpY2Ug ewo+ICAJLyogYW1ka2ZkIGludGVyZmFjZSAqLwo+ICAJc3RydWN0IGtmZF9kZXYJCSprZmQ7Cj4g IAo+ICsJLyogbGFzdCB0aW1lIHdlIHJlY2VpdmVkIGFuIGhwZCBzaWduYWwgKi8KPiArCXVuc2ln bmVkIGxvbmcgaHBkX3RpbWU7Cj4gKwo+ICAJc3RydWN0IG11dGV4CW1uX2xvY2s7Cj4gIAlERUNM QVJFX0hBU0hUQUJMRShtbl9oYXNoLCA3KTsKPiAgfTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL3JhZGVvbi9yYWRlb25fY29ubmVjdG9ycy5jIGIvZHJpdmVycy9ncHUvZHJtL3JhZGVv bi9yYWRlb25fY29ubmVjdG9ycy5jCj4gaW5kZXggNWEyY2FmYi4uNGVlOTQ0MCAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl9jb25uZWN0b3JzLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl9jb25uZWN0b3JzLmMKPiBAQCAtMTIyOCwxOSAr MTIyOCwzMyBAQCByYWRlb25fZHZpX2RldGVjdChzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVj dG9yLCBib29sIGZvcmNlKQo+ICAJY29uc3Qgc3RydWN0IGRybV9lbmNvZGVyX2hlbHBlcl9mdW5j cyAqZW5jb2Rlcl9mdW5jczsKPiAgCWludCBpLCByOwo+ICAJZW51bSBkcm1fY29ubmVjdG9yX3N0 YXR1cyByZXQgPSBjb25uZWN0b3Jfc3RhdHVzX2Rpc2Nvbm5lY3RlZDsKPiAtCWJvb2wgZHJldCA9 IGZhbHNlLCBicm9rZW5fZWRpZCA9IGZhbHNlOwo+ICsJYm9vbCBkcmV0ID0gZmFsc2UsIGJyb2tl bl9lZGlkID0gZmFsc2UsIGhwZF91bmNoYW5nZWQ7Cj4gIAo+ICAJciA9IHBtX3J1bnRpbWVfZ2V0 X3N5bmMoY29ubmVjdG9yLT5kZXYtPmRldik7Cj4gIAlpZiAociA8IDApCj4gIAkJcmV0dXJuIGNv bm5lY3Rvcl9zdGF0dXNfZGlzY29ubmVjdGVkOwo+ICAKPiAtCWlmICghZm9yY2UgJiYgcmFkZW9u X2NoZWNrX2hwZF9zdGF0dXNfdW5jaGFuZ2VkKGNvbm5lY3RvcikpIHsKPiArCWhwZF91bmNoYW5n ZWQgPSByYWRlb25fY2hlY2tfaHBkX3N0YXR1c191bmNoYW5nZWQoY29ubmVjdG9yKTsKPiArCWlm ICghZm9yY2UgJiYgaHBkX3VuY2hhbmdlZCkgewo+ICAJCXJldCA9IGNvbm5lY3Rvci0+c3RhdHVz Owo+ICAJCWdvdG8gZXhpdDsKPiAgCX0KPiAgCj4gLQlpZiAocmFkZW9uX2Nvbm5lY3Rvci0+ZGRj X2J1cykKPiArCWlmIChyYWRlb25fY29ubmVjdG9yLT5kZGNfYnVzKSB7Cj4gIAkJZHJldCA9IHJh ZGVvbl9kZGNfcHJvYmUocmFkZW9uX2Nvbm5lY3RvciwgZmFsc2UpOwo+ICsKPiArCQkvKiBTb21l dGltZXMgdGhlIHBpbnMgcmVxdWlyZWQgZm9yIHRoZSBEREMgcHJvYmUgb24gRFZJCj4gKwkJICog Y29ubmVjdG9ycyBkb24ndCBtYWtlIGNvbnRhY3QgYXQgdGhlIHNhbWUgdGltZSB0aGF0IHRoZSBv bmVzCj4gKwkJICogZm9yIEhQRCBkby4gSWYgdGhlIEREQyBwcm9iZSBmYWlscyBldmVuIHRob3Vn aCB3ZSBoYWQgYW4gSFBECj4gKwkJICogc2lnbmFsLCBzaWduYWwgdXNlcnNwYWNlIHRvIHRyeSBh Z2FpbiAqLwo+ICsJCWlmICghZHJldCAmJiAhaHBkX3VuY2hhbmdlZCAmJgo+ICsJCSAgICBjb25u ZWN0b3ItPnN0YXR1cyAhPSBjb25uZWN0b3Jfc3RhdHVzX2Nvbm5lY3RlZCAmJgo+ICsJCSAgICB0 aW1lX2JlZm9yZShqaWZmaWVzLCByZGV2LT5ocGRfdGltZSArIG1zZWNzX3RvX2ppZmZpZXMoMTAw MCkpKSB7Cj4gKwkJCURSTV9ERUJVR19LTVMoIiVzOiBocGQgYXNzZXJ0ZWQgYnV0IGRkYyBwcm9i ZSBmYWlsZWQsIHJldHJ5aW5nXG4iLAo+ICsJCQkJICAgICAgY29ubmVjdG9yLT5uYW1lKTsKPiAr CQkJZHJtX3N5c2ZzX2hvdHBsdWdfZXZlbnQoZGV2KTsKPiArCQl9Cj4gKwl9Cj4gIAlpZiAoZHJl dCkgewo+ICAJCXJhZGVvbl9jb25uZWN0b3ItPmRldGVjdGVkX2J5X2xvYWQgPSBmYWxzZTsKPiAg CQlyYWRlb25fY29ubmVjdG9yX2ZyZWVfZWRpZChjb25uZWN0b3IpOwo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl9pcnFfa21zLmMgYi9kcml2ZXJzL2dwdS9kcm0v cmFkZW9uL3JhZGVvbl9pcnFfa21zLmMKPiBpbmRleCAxNzFkM2U0Li41NzljMjJjIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX2lycV9rbXMuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX2lycV9rbXMuYwo+IEBAIC03OSw2ICs3OSw4IEBA IHN0YXRpYyB2b2lkIHJhZGVvbl9ob3RwbHVnX3dvcmtfZnVuYyhzdHJ1Y3Qgd29ya19zdHJ1Y3Qg KndvcmspCj4gIAlzdHJ1Y3QgZHJtX21vZGVfY29uZmlnICptb2RlX2NvbmZpZyA9ICZkZXYtPm1v ZGVfY29uZmlnOwo+ICAJc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvcjsKPiAgCj4gKwly ZGV2LT5ocGRfdGltZSA9IGppZmZpZXM7Cj4gKwo+ICAJLyogd2UgY2FuIHJhY2UgaGVyZSBhdCBz dGFydHVwLCBzb21lIGJvYXJkcyBzZWVtIHRvIHRyaWdnZXIKPiAgCSAqIGhvdHBsdWcgaXJxcyB3 aGVuIHRoZXkgc2hvdWxkbid0LiAqLwo+ICAJaWYgKCFyZGV2LT5tb2RlX2luZm8ubW9kZV9jb25m aWdfaW5pdGlhbGl6ZWQpCgpEb2VzIHRoaXMgcGF0Y2ggaGVscCBpbiBjYXNlIEkgdXNlIGEgRFAt Mi1EVkktRCBvciBIRE1JLTItRFZJLUQgY29udmVydGVyIGNhYmxlPwoKVGhhbmtzIGluIGFkdmFu Y2UsClpvbHTDoW4gQsO2c3rDtnJtw6lueWkKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760588AbbLCPdx (ORCPT ); Thu, 3 Dec 2015 10:33:53 -0500 Received: from mail9.pr.hu ([87.242.0.9]:58385 "EHLO mail9.pr.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756289AbbLCPdw (ORCPT ); Thu, 3 Dec 2015 10:33:52 -0500 X-Greylist: delayed 2129 seconds by postgrey-1.27 at vger.kernel.org; Thu, 03 Dec 2015 10:33:51 EST Subject: Re: [PATCH] drm/radeon: Retry DDC probing on DVI on failure if we got an HPD interrupt To: cpaul@redhat.com, Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <1448034740-30193-1-git-send-email-cpaul@redhat.com> Cc: Jerome Glisse , Benjamin Tissoires From: Boszormenyi Zoltan Message-ID: <5660587E.7050801@pr.hu> Date: Thu, 3 Dec 2015 15:58:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1448034740-30193-1-git-send-email-cpaul@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.2 (/) X-Scan-Signature: 4504fbbec4e21e79d85e2024c7bc7f5e X-Spam-Tracer: backend.mail.pr.hu 0.2 20151203145814Z Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2015-11-20 16:52 keltezéssel, cpaul@redhat.com írta: > From: Stephen Chandler Paul > > HPD signals on DVI ports can be fired off before the pins required for > DDC probing actually make contact, due to the pins for HPD making > contact first. This results in a HPD signal being asserted but DDC > probing failing, resulting in hotplugging occasionally failing. > > This is somewhat rare on most cards (depending on what angle you plug > the DVI connector in), but on some cards it happens constantly. The > Radeon R5 on the machine used for testing this patch for instance, runs > into this issue just about every time I try to hotplug a DVI monitor and > as a result hotplugging almost never works. > > Rescheduling the hotplug work for a second when we run into an HPD > signal with a failing DDC probe usually gives enough time for the rest > of the connector's pins to make contact, and fixes this issue. > > Signed-off-by: Stephen Chandler Paul > --- > So this one has kind of been a tough sell with Jerome, mostly because it's > somewhat of a hack. Unfortunately however I've managed to find machines where > DVI hotplugging literally doesn't work without a patch like this. We've already > tried a couple of ways of handling the situation of retriggering ddc probes: > > * Trying the DDC probe in the radeon_dvi_detect() function multiple times. > * Trying to reschedule the hotplug_work task whenever DDC probing fails on DVI > but we got a hpd signal (this ended up being a much more complicated patch > then anticipated) > * Doing what we do right now, which is just triggering userspace to rescan all > the ports when the hpd signal is asserted by the DVI port but there's no DDC > probe, and repeating until at least a second passes. > > All of these actually work, but I guess it's a question of which one is less of > a hack. If anyone here can think of a cleaner way of handling this feel free to > let me know. > > drivers/gpu/drm/radeon/radeon.h | 3 +++ > drivers/gpu/drm/radeon/radeon_connectors.c | 20 +++++++++++++++++--- > drivers/gpu/drm/radeon/radeon_irq_kms.c | 2 ++ > 3 files changed, 22 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon/radeon.h > index b6cbd81..d63f0fe 100644 > --- a/drivers/gpu/drm/radeon/radeon.h > +++ b/drivers/gpu/drm/radeon/radeon.h > @@ -2460,6 +2460,9 @@ struct radeon_device { > /* amdkfd interface */ > struct kfd_dev *kfd; > > + /* last time we received an hpd signal */ > + unsigned long hpd_time; > + > struct mutex mn_lock; > DECLARE_HASHTABLE(mn_hash, 7); > }; > diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c > index 5a2cafb..4ee9440 100644 > --- a/drivers/gpu/drm/radeon/radeon_connectors.c > +++ b/drivers/gpu/drm/radeon/radeon_connectors.c > @@ -1228,19 +1228,33 @@ radeon_dvi_detect(struct drm_connector *connector, bool force) > const struct drm_encoder_helper_funcs *encoder_funcs; > int i, r; > enum drm_connector_status ret = connector_status_disconnected; > - bool dret = false, broken_edid = false; > + bool dret = false, broken_edid = false, hpd_unchanged; > > r = pm_runtime_get_sync(connector->dev->dev); > if (r < 0) > return connector_status_disconnected; > > - if (!force && radeon_check_hpd_status_unchanged(connector)) { > + hpd_unchanged = radeon_check_hpd_status_unchanged(connector); > + if (!force && hpd_unchanged) { > ret = connector->status; > goto exit; > } > > - if (radeon_connector->ddc_bus) > + if (radeon_connector->ddc_bus) { > dret = radeon_ddc_probe(radeon_connector, false); > + > + /* Sometimes the pins required for the DDC probe on DVI > + * connectors don't make contact at the same time that the ones > + * for HPD do. If the DDC probe fails even though we had an HPD > + * signal, signal userspace to try again */ > + if (!dret && !hpd_unchanged && > + connector->status != connector_status_connected && > + time_before(jiffies, rdev->hpd_time + msecs_to_jiffies(1000))) { > + DRM_DEBUG_KMS("%s: hpd asserted but ddc probe failed, retrying\n", > + connector->name); > + drm_sysfs_hotplug_event(dev); > + } > + } > if (dret) { > radeon_connector->detected_by_load = false; > radeon_connector_free_edid(connector); > diff --git a/drivers/gpu/drm/radeon/radeon_irq_kms.c b/drivers/gpu/drm/radeon/radeon_irq_kms.c > index 171d3e4..579c22c 100644 > --- a/drivers/gpu/drm/radeon/radeon_irq_kms.c > +++ b/drivers/gpu/drm/radeon/radeon_irq_kms.c > @@ -79,6 +79,8 @@ static void radeon_hotplug_work_func(struct work_struct *work) > struct drm_mode_config *mode_config = &dev->mode_config; > struct drm_connector *connector; > > + rdev->hpd_time = jiffies; > + > /* we can race here at startup, some boards seem to trigger > * hotplug irqs when they shouldn't. */ > if (!rdev->mode_info.mode_config_initialized) Does this patch help in case I use a DP-2-DVI-D or HDMI-2-DVI-D converter cable? Thanks in advance, Zoltán Böszörményi