From: David Vrabel <david.vrabel@citrix.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: <x86@kernel.org>, <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
<xen-devel@lists.xenproject.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>
Subject: Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs
Date: Thu, 3 Dec 2015 15:06:03 +0000 [thread overview]
Message-ID: <56605A5B.6000506@citrix.com> (raw)
In-Reply-To: <87mvtr7p2s.fsf@vitty.brq.redhat.com>
On 03/12/15 11:23, Vitaly Kuznetsov wrote:
> David Vrabel <david.vrabel@citrix.com> writes:
>
>> Adding the rtc platform device when there are no legacy irqs (no
>> legacy PIC)
>
> No PIC != No legacy IRQs, Hyper-V Gen2 represents such a platform (and
> it has RTC on irq8). I've tested this patch against it and it appears to
> work because the device is present in ACPI and we initialize it in
> drivers/acpi/acpi_cmos_rtc.c, add_rtc_cmos() bails out in the very
> beginning as we see PNP0b00 device.
It's not a legacy IRQ if it isn't going via the legacy PIC, it just
happens to have the same number.
I think it is safe to assume that any machine with a CMOS RTC but no PNP
information is also going to have a legacy PIC.
David
next prev parent reply other threads:[~2015-12-03 15:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 10:43 [PATCHv1] x86: rtc_cmos platform device requires legacy irqs David Vrabel
2015-12-03 11:23 ` [Xen-devel] " Vitaly Kuznetsov
2015-12-03 15:06 ` David Vrabel [this message]
2015-12-03 15:06 ` David Vrabel
2015-12-03 11:23 ` Vitaly Kuznetsov
2015-12-04 14:06 ` David Vrabel
2015-12-04 14:06 ` [Xen-devel] " David Vrabel
2015-12-04 15:24 ` David Vrabel
2015-12-04 15:35 ` Boris Ostrovsky
2015-12-04 15:52 ` Vitaly Kuznetsov
2015-12-04 15:52 ` [Xen-devel] " Vitaly Kuznetsov
2015-12-04 16:14 ` Boris Ostrovsky
2015-12-04 16:14 ` [Xen-devel] " Boris Ostrovsky
2015-12-04 15:35 ` Boris Ostrovsky
2015-12-08 21:02 ` Thomas Gleixner
2015-12-08 21:02 ` [Xen-devel] " Thomas Gleixner
2015-12-08 21:15 ` Boris Ostrovsky
2015-12-08 21:27 ` Thomas Gleixner
2015-12-08 21:27 ` [Xen-devel] " Thomas Gleixner
2015-12-08 21:15 ` Boris Ostrovsky
2015-12-04 15:24 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56605A5B.6000506@citrix.com \
--to=david.vrabel@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.