Re: [PATCH 1/2] HFSPlus: clear dirty flags on remount read-only

["Timo Schlüßler" <timo@schluessler.org>]

Hello Vyacheslav,

thank you for your quick reply.

On 29.11.2015 23:50, Vyacheslav Dubeyko wrote:
> Hi Timo,
>
>
> If you set HFSPLUS_VOL_UNMNT and clear HFSPLUS_VOL_INCNSTNT bits on
> operation of remount in READ-ONLY state then you should do opposite
> operation on remount in READ-WRITE state. But, as far as I can judge,
> you've missed this change. Such modification should be in the same
> patch.

Of course, I will add this change to the patch.

> Are you sure that hfsplus_sync_fs() should be called here? As far as I
> can see, sync_filesystem() does it for you. What the reason for second
> call? Or do I miss something?

I wanted to avoid reordering the original code and also avoid to duplicate
the call to sync_filesystem() (as I did in the end int the HFS patch).
Now when adding the second change to clear HFSPLUS_VOL_UNMNT and set
HFSPLUS_VOL_INCNSTNT on remounting READ-WRITE, the reordering makes
perfect sense.

> Thanks,
> Vyacheslav Dubeyko.
>

Best regards,
Timo Schlüßler