From: "Timo Schlüßler" <timo@schluessler.org>
To: unlisted-recipients:; (no To-header on input)
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] HFS: clear dirty flags on remount read-only
Date: Thu, 3 Dec 2015 19:42:36 +0100 [thread overview]
Message-ID: <56608D1C.30708@schluessler.org> (raw)
In-Reply-To: <1448838216.4582.12.camel@ubuntu-slavad-14.04>
Hello Vyacheslav,
On 30.11.2015 00:03, Vyacheslav Dubeyko wrote:
> Hi Timo,
>
> I think that this is the right placement for sync_filesystem() call.
> It's much better to have such call in one place. Anyway, you need to set
> HFS_SB_ATTRIB_UNMNT and to clear HFS_SB_ATTRIB_INCNSTNT for remount from
> READ-WRITE to READ-ONLY state. And vou need to do opposite operation for
> remount from READ-ONLY to READ-WRITE state. So, it's much better ti
> leave sync_filesystem() call in the same place but to add additional
> logic before this call.
>
> Thanks,
> Vyacheslav Dubeyko.
>
I agree with you and will provide an updated patch for this.
Best regards
Timo Schlüßler
prev parent reply other threads:[~2015-12-03 18:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-29 14:59 [PATCH 2/2] HFS: clear dirty flags on remount read-only Timo Schlüßler
2015-11-29 23:03 ` Vyacheslav Dubeyko
2015-12-03 18:42 ` Timo Schlüßler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56608D1C.30708@schluessler.org \
--to=timo@schluessler.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.