From: Ben Greear <greearb@candelatech.com>
To: ath10k <ath10k@lists.infradead.org>
Subject: Bugs in wake-queue logic.
Date: Thu, 3 Dec 2015 11:52:46 -0800 [thread overview]
Message-ID: <56609D8E.9010703@candelatech.com> (raw)
So, after tweaking a firmware image to actually be able to use
all tx-buffers, then queues can actually be stopped on the host
now.
I'm now getting splats related to tx-queue being
out of range.
Why are we using vdev_id as the queue-id below?
void ath10k_mac_vif_tx_unlock(struct ath10k_vif *arvif, int reason)
{
struct ath10k *ar = arvif->ar;
lockdep_assert_held(&ar->htt.tx_lock);
WARN_ON(reason >= BITS_PER_LONG);
arvif->tx_paused &= ~BIT(reason);
if (ar->tx_paused)
return;
if (arvif->tx_paused)
return;
ieee80211_wake_queue(ar->hw, arvif->vdev_id);
}
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next reply other threads:[~2015-12-03 19:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 19:52 Ben Greear [this message]
2015-12-04 6:06 ` Bugs in wake-queue logic Janusz Dziedzic
2015-12-04 6:11 ` Janusz Dziedzic
2015-12-04 6:30 ` Ben Greear
2015-12-04 9:15 ` Janusz Dziedzic
2015-12-05 13:42 ` Michal Kazior
2015-12-05 16:18 ` Ben Greear
2015-12-05 16:42 ` Michal Kazior
2015-12-05 18:19 ` Ben Greear
2015-12-06 4:32 ` Michal Kazior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56609D8E.9010703@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath10k@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.