All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michel Dänzer" <michel@daenzer.net>
To: "Christian König" <deathsimple@vodafone.de>, alexdeucher@gmail.com
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/amdgpu: set snooped flags only on system addresses
Date: Fri, 4 Dec 2015 11:50:47 +0900	[thread overview]
Message-ID: <5660FF87.8090904@daenzer.net> (raw)
In-Reply-To: <1449168952-4636-1-git-send-email-deathsimple@vodafone.de>

On 04.12.2015 03:55, Christian König wrote:
> From: Christian König <christian.koenig@amd.com>
> 
> Not necessary for VRAM.
> 
> Signed-off-by: Christian König <christian.koenig@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index 8051cb9..298fb10 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -801,11 +801,12 @@ uint32_t amdgpu_ttm_tt_pte_flags(struct amdgpu_device *adev, struct ttm_tt *ttm,
>  	if (mem && mem->mem_type != TTM_PL_SYSTEM)
>  		flags |= AMDGPU_PTE_VALID;
>  
> -	if (mem && mem->mem_type == TTM_PL_TT)
> +	if (mem && mem->mem_type == TTM_PL_TT) {
>  		flags |= AMDGPU_PTE_SYSTEM;
>  
> -	if (!ttm || ttm->caching_state == tt_cached)
> -		flags |= AMDGPU_PTE_SNOOPED;
> +		if (!ttm || ttm->caching_state == tt_cached)
> +			flags |= AMDGPU_PTE_SNOOPED;
> +	}

Can ttm be NULL here if mem->mem_type == TTM_PL_TT?


Patches 2 & 3 are

Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2015-12-04  2:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-03 18:55 [PATCH 1/3] drm/amdgpu: set snooped flags only on system addresses Christian König
2015-12-03 18:55 ` [PATCH 2/3] drm/amdgpu: take a BO reference in the dispaly code Christian König
2015-12-03 18:55 ` [PATCH 3/3] drm/amdgpu: take a BO reference for the user fence Christian König
2015-12-04  2:50 ` Michel Dänzer [this message]
2015-12-04 12:32   ` [PATCH 1/3] drm/amdgpu: set snooped flags only on system addresses Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5660FF87.8090904@daenzer.net \
    --to=michel@daenzer.net \
    --cc=alexdeucher@gmail.com \
    --cc=deathsimple@vodafone.de \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.