From: Eric Blake <eblake@redhat.com>
To: Miao Yan <yanmiaobest@gmail.com>,
jasowang@redhat.com, dmitry@daynix.com, qemu-devel@nongnu.org,
armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/2] net/vmxnet3: remove redundant VMW_SHPRN(...) definition
Date: Fri, 4 Dec 2015 06:35:59 -0700 [thread overview]
Message-ID: <566196BF.6080801@redhat.com> (raw)
In-Reply-To: <1449220774-17968-2-git-send-email-yanmiaobest@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 875 bytes --]
On 12/04/2015 02:19 AM, Miao Yan wrote:
> Macro VMW_SHPRN(...) is already defined vmxnet3_debug.h,
> so remove the duplication
>
> Signed-off-by: Miao Yan <yanmiaobest@gmail.com>
> ---
> hw/net/vmware_utils.h | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/hw/net/vmware_utils.h b/hw/net/vmware_utils.h
> index 1099df6..c2c2f90 100644
> --- a/hw/net/vmware_utils.h
> +++ b/hw/net/vmware_utils.h
> @@ -18,10 +18,7 @@
> #define VMWARE_UTILS_H
>
> #include "qemu/range.h"
> -
> -#ifndef VMW_SHPRN
> -#define VMW_SHPRN(fmt, ...) do {} while (0)
> -#endif
> +#include "vmxnet_debug.h"
>
> /*
> * Shared memory access functions with byte swap support
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-12-04 13:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 9:19 [Qemu-devel] [PATCH 1/2] net/vmxnet3: fix debug macro pattern for vmxnet3 Miao Yan
2015-12-04 9:19 ` [Qemu-devel] [PATCH 2/2] net/vmxnet3: remove redundant VMW_SHPRN(...) definition Miao Yan
2015-12-04 13:35 ` Eric Blake [this message]
2015-12-04 13:18 ` [Qemu-devel] [PATCH 1/2] net/vmxnet3: fix debug macro pattern for vmxnet3 Eric Blake
2015-12-05 7:28 ` Miao Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566196BF.6080801@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=dmitry@daynix.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yanmiaobest@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.