All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Ashfield <bruce.ashfield@windriver.com>
To: Kyle Russell <bkylerussell@gmail.com>, <yocto@yoctoproject.org>
Subject: Re: [meta-oracle-java][PATCH v2] oracle-jse-jdk: Don't use ${D} installing symlink target
Date: Fri, 4 Dec 2015 10:49:07 -0500	[thread overview]
Message-ID: <5661B5F3.9020004@windriver.com> (raw)
In-Reply-To: <1449099554-22948-1-git-send-email-bkylerussell@gmail.com>

On 15-12-02 06:39 PM, Kyle Russell wrote:
> When installed to the sysroot, this makes the symlink point to the
> workdir, which is invalid in the sstate package.  Since we cd to
> ${D} before creating the symlink, this ensures the link is created
> in the correct install location, so just point the link to the final
> target so that the patch is correctly fixed up during populate_sysroot.

Looks good to me: Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>

>
> Signed-off-by: Kyle Russell <bkylerussell@gmail.com>
> ---
>   recipes-devtools/oracle-java/oracle-jse-jdk.inc |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-devtools/oracle-java/oracle-jse-jdk.inc b/recipes-devtools/oracle-java/oracle-jse-jdk.inc
> index 54e83b8..6f13125 100644
> --- a/recipes-devtools/oracle-java/oracle-jse-jdk.inc
> +++ b/recipes-devtools/oracle-java/oracle-jse-jdk.inc
> @@ -16,7 +16,7 @@ do_install_class-native() {
>       install -d -m 0755 ${D}${bindir}
>       cp -a ${S}/${JDK_JRE}${PV}_${PV_UPDATE} ${D}${libdir}/
>       for prog in java javac; do
> -	( cd ${D}${bindir} && ln -sf ${D}${libdir}/${JDK_JRE}${PV}_${PV_UPDATE}/bin/$prog )
> +	( cd ${D}${bindir} && ln -sf ${libdir}/${JDK_JRE}${PV}_${PV_UPDATE}/bin/$prog )
>       done
>
>       ( cd ${D}${libdir}/${JDK_JRE}${PV}_${PV_UPDATE}/bin ; \
>



      parent reply	other threads:[~2015-12-04 15:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-02 23:39 [meta-oracle-java][PATCH v2] oracle-jse-jdk: Don't use ${D} installing symlink target Kyle Russell
2015-12-04 12:05 ` Maxin B. John
2015-12-04 15:49 ` Bruce Ashfield [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5661B5F3.9020004@windriver.com \
    --to=bruce.ashfield@windriver.com \
    --cc=bkylerussell@gmail.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.