From: Eric Sandeen <sandeen@redhat.com>
To: fstests <fstests@vger.kernel.org>
Subject: [PATCH] 242: remove open-coded check for "zero" command
Date: Fri, 4 Dec 2015 15:06:14 -0600 [thread overview]
Message-ID: <56620046.7060101@redhat.com> (raw)
We have helpers for this, no need to open-code it.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/tests/xfs/242 b/tests/xfs/242
index 304e69f..4e1a8b4 100755
--- a/tests/xfs/242
+++ b/tests/xfs/242
@@ -47,14 +47,7 @@ _supported_fs xfs
_supported_os Linux
_require_test
-_test_io_zero()
-{
- $XFS_IO_PROG -c "zero help" 2>&1 | \
- grep 'command "zero" not found' > /dev/null
- echo $?
-}
-
-[ $(_test_io_zero) -eq 0 ] && _notrun "zero command not supported"
+_require_xfs_io_command "zero"
testfile=$TEST_DIR/242.$$
next reply other threads:[~2015-12-04 21:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 21:06 Eric Sandeen [this message]
2015-12-04 22:02 ` [PATCH V2] xfs/242: remove open-coded check for "zero" command Eric Sandeen
2015-12-11 9:26 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56620046.7060101@redhat.com \
--to=sandeen@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.