From mboxrd@z Thu Jan 1 00:00:00 1970 From: kapilh@broadcom.com (Kapil Hali) Date: Sat, 5 Dec 2015 17:26:08 +0530 Subject: [PATCH v5 2/5] ARM: BCM: Clean up SMP support for Broadcom Kona In-Reply-To: <56621CA3.3090903@gmail.com> References: <1449260611-24417-1-git-send-email-kapilh@broadcom.com> <1449260611-24417-3-git-send-email-kapilh@broadcom.com> <56621CA3.3090903@gmail.com> Message-ID: <5662D0D8.1020004@broadcom.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Florian, On 12/5/2015 4:37 AM, Florian Fainelli wrote: > On 04/12/15 12:23, Kapil Hali wrote: >> These changes cleans up SMP implementaion for Broadcom's >> Kona SoC which are required for handling SMP for iProc >> family of SoCs at a single place for BCM NSP and BCM Kona. >> >> Signed-off-by: Kapil Hali >> --- >> arch/arm/boot/dts/bcm11351.dtsi | 2 +- >> arch/arm/boot/dts/bcm21664.dtsi | 2 +- >> arch/arm/mach-bcm/kona_smp.c | 82 +++++++++++++++++++++++++++-------------- >> 3 files changed, 56 insertions(+), 30 deletions(-) >> >> diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi >> index 2ddaa51..3dc7a8c 100644 >> --- a/arch/arm/boot/dts/bcm11351.dtsi >> +++ b/arch/arm/boot/dts/bcm11351.dtsi >> @@ -31,7 +31,6 @@ >> #address-cells = <1>; >> #size-cells = <0>; >> enable-method = "brcm,bcm11351-cpu-method"; >> - secondary-boot-reg = <0x3500417c>; > > I would expect the 'enable-method' to be moved as well to be consistent > with what you are adding for NSP later on. > Right, it is updated in the new patch set. >> >> cpu0: cpu at 0 { >> device_type = "cpu"; >> @@ -42,6 +41,7 @@ >> cpu1: cpu at 1 { >> device_type = "cpu"; >> compatible = "arm,cortex-a9"; >> + secondary-boot-reg = <0x3500417c>; >> reg = <1>; >> }; Thanks, Kapil From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kapil Hali Subject: Re: [PATCH v5 2/5] ARM: BCM: Clean up SMP support for Broadcom Kona Date: Sat, 5 Dec 2015 17:26:08 +0530 Message-ID: <5662D0D8.1020004@broadcom.com> References: <1449260611-24417-1-git-send-email-kapilh@broadcom.com> <1449260611-24417-3-git-send-email-kapilh@broadcom.com> <56621CA3.3090903@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56621CA3.3090903-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Florian Fainelli , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Ray Jui , Scott Branden , Jon Mason Cc: Gregory Fong , Lee Jones , Hauke Mehrtens , Kever Yang , Maxime Ripard , Olof Johansson , Paul Walmsley , Linus Walleij , Chen-Yu Tsai , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Florian, On 12/5/2015 4:37 AM, Florian Fainelli wrote: > On 04/12/15 12:23, Kapil Hali wrote: >> These changes cleans up SMP implementaion for Broadcom's >> Kona SoC which are required for handling SMP for iProc >> family of SoCs at a single place for BCM NSP and BCM Kona. >> >> Signed-off-by: Kapil Hali >> --- >> arch/arm/boot/dts/bcm11351.dtsi | 2 +- >> arch/arm/boot/dts/bcm21664.dtsi | 2 +- >> arch/arm/mach-bcm/kona_smp.c | 82 +++++++++++++++++++++++++++-------------- >> 3 files changed, 56 insertions(+), 30 deletions(-) >> >> diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi >> index 2ddaa51..3dc7a8c 100644 >> --- a/arch/arm/boot/dts/bcm11351.dtsi >> +++ b/arch/arm/boot/dts/bcm11351.dtsi >> @@ -31,7 +31,6 @@ >> #address-cells = <1>; >> #size-cells = <0>; >> enable-method = "brcm,bcm11351-cpu-method"; >> - secondary-boot-reg = <0x3500417c>; > > I would expect the 'enable-method' to be moved as well to be consistent > with what you are adding for NSP later on. > Right, it is updated in the new patch set. >> >> cpu0: cpu@0 { >> device_type = "cpu"; >> @@ -42,6 +41,7 @@ >> cpu1: cpu@1 { >> device_type = "cpu"; >> compatible = "arm,cortex-a9"; >> + secondary-boot-reg = <0x3500417c>; >> reg = <1>; >> }; Thanks, Kapil -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754554AbbLEL4R (ORCPT ); Sat, 5 Dec 2015 06:56:17 -0500 Received: from mail-gw2-out.broadcom.com ([216.31.210.63]:11815 "EHLO mail-gw2-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753570AbbLEL4P (ORCPT ); Sat, 5 Dec 2015 06:56:15 -0500 X-IronPort-AV: E=Sophos;i="5.20,384,1444719600"; d="scan'208";a="82497153" Subject: Re: [PATCH v5 2/5] ARM: BCM: Clean up SMP support for Broadcom Kona To: Florian Fainelli , Rob Herring , Pawel Moll , Mark Rutland , "Ian Campbell" , Kumar Gala , Russell King , Ray Jui , "Scott Branden" , Jon Mason References: <1449260611-24417-1-git-send-email-kapilh@broadcom.com> <1449260611-24417-3-git-send-email-kapilh@broadcom.com> <56621CA3.3090903@gmail.com> CC: Gregory Fong , Lee Jones , "Hauke Mehrtens" , Kever Yang , Maxime Ripard , Olof Johansson , Paul Walmsley , Linus Walleij , Chen-Yu Tsai , , , , From: Kapil Hali Message-ID: <5662D0D8.1020004@broadcom.com> Date: Sat, 5 Dec 2015 17:26:08 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <56621CA3.3090903@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Florian, On 12/5/2015 4:37 AM, Florian Fainelli wrote: > On 04/12/15 12:23, Kapil Hali wrote: >> These changes cleans up SMP implementaion for Broadcom's >> Kona SoC which are required for handling SMP for iProc >> family of SoCs at a single place for BCM NSP and BCM Kona. >> >> Signed-off-by: Kapil Hali >> --- >> arch/arm/boot/dts/bcm11351.dtsi | 2 +- >> arch/arm/boot/dts/bcm21664.dtsi | 2 +- >> arch/arm/mach-bcm/kona_smp.c | 82 +++++++++++++++++++++++++++-------------- >> 3 files changed, 56 insertions(+), 30 deletions(-) >> >> diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi >> index 2ddaa51..3dc7a8c 100644 >> --- a/arch/arm/boot/dts/bcm11351.dtsi >> +++ b/arch/arm/boot/dts/bcm11351.dtsi >> @@ -31,7 +31,6 @@ >> #address-cells = <1>; >> #size-cells = <0>; >> enable-method = "brcm,bcm11351-cpu-method"; >> - secondary-boot-reg = <0x3500417c>; > > I would expect the 'enable-method' to be moved as well to be consistent > with what you are adding for NSP later on. > Right, it is updated in the new patch set. >> >> cpu0: cpu@0 { >> device_type = "cpu"; >> @@ -42,6 +41,7 @@ >> cpu1: cpu@1 { >> device_type = "cpu"; >> compatible = "arm,cortex-a9"; >> + secondary-boot-reg = <0x3500417c>; >> reg = <1>; >> }; Thanks, Kapil