From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail2.candelatech.com ([208.74.158.173]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1a5FXh-0006do-5M for ath10k@lists.infradead.org; Sat, 05 Dec 2015 16:18:37 +0000 Message-ID: <56630E47.8010809@candelatech.com> Date: Sat, 05 Dec 2015 08:18:15 -0800 From: Ben Greear MIME-Version: 1.0 Subject: Re: Bugs in wake-queue logic. References: <56609D8E.9010703@candelatech.com> In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Michal Kazior Cc: ath10k On 12/05/2015 05:42 AM, Michal Kazior wrote: > On 04/12/2015, Ben Greear wrote: >> So, after tweaking a firmware image to actually be able to use >> all tx-buffers, then queues can actually be stopped on the host >> now. >> >> I'm now getting splats related to tx-queue being >> out of range. >> >> Why are we using vdev_id as the queue-id below? >> >> void ath10k_mac_vif_tx_unlock(struct ath10k_vif *arvif, int reason) >> { >> struct ath10k *ar = arvif->ar; >> >> lockdep_assert_held(&ar->htt.tx_lock); >> >> WARN_ON(reason >= BITS_PER_LONG); >> arvif->tx_paused &= ~BIT(reason); >> >> if (ar->tx_paused) >> return; >> >> if (arvif->tx_paused) >> return; >> >> ieee80211_wake_queue(ar->hw, arvif->vdev_id); > > I guess you could try replacing arvif->vdev_id with > arvif->vif->cab_queue. This along with vif->hw_queue[] share the same > queue number associated with vdev_id. Refer to the add_interface() > implementation, please. > > You don't need to increase mac80211's max_queues unless you intend to > support a similar host queue control via firmware events like qca6174. What about the comments about tx-locking? Does that only apply to qca6174? For host queue control, are firmware events really needed, or can we just keep track of buffered pkts per peer and/or per vdev and use that on the host? Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k