Re: [RFC PATCH] Crypto: rockchip/crypto - add hash support for crypto engine in rk3288

[Zain <zain.wang@rock-chips.com>]

在 2015年12月05日 20:36, Corentin LABBE 写道:
> Le 05/12/2015 07:30, Zain Wang a écrit :
>> Add md5 sha1 sha256 support for crypto engine in rk3288.
>> This patch can't support multiple updatings because of limited of IC,
>> as result, it can't support import and export too.
>>
>> Signed-off-by: Zain Wang <zain.wang@rock-chips.com>
>> ---
>>  drivers/crypto/rockchip/Makefile                   |   1 +
>>  drivers/crypto/rockchip/rk3288_crypto.c            |  33 +-
>>  drivers/crypto/rockchip/rk3288_crypto.h            |  50 ++-
>>  drivers/crypto/rockchip/rk3288_crypto_ablkcipher.c |  20 +-
>>  drivers/crypto/rockchip/rk3288_crypto_ahash.c      | 369 +++++++++++++++++++++
>>  5 files changed, 455 insertions(+), 18 deletions(-)
>>  create mode 100644 drivers/crypto/rockchip/rk3288_crypto_ahash.c
>>
>> diff --git a/drivers/crypto/rockchip/Makefile b/drivers/crypto/rockchip/Makefile
>> index 7051c6c..30f9129 100644
>> +++ b/drivers/crypto/rockchip/rk3288_crypto_ahash.c
>> @@ -0,0 +1,369 @@
>> +/*
>> + * Crypto acceleration support for Rockchip RK3288
>> + *
>> + * Copyright (c) 2015, Fuzhou Rockchip Electronics Co., Ltd
>> + *
>> + * Author: Zain Wang <zain.wang@rock-chips.com>
>> + *
>> + * This program is free software; you can redistribute it and/or modify it
>> + * under the terms and conditions of the GNU General Public License,
>> + * version 2, as published by the Free Software Foundation.
>> + *
>> + * Some ideas are from marvell/cesa.c and s5p-sss.c driver.
>> + */
>> +#include "rk3288_crypto.h"
>> +
>> +static u8 *outdata[3] = {
>> +		"\xda\x39\xa3\xee\x5e\x6b\x4b\x0d\x32\x55"
>> +		"\xbf\xef\x95\x60\x18\x90\xaf\xd8\x07\x09",
>> +
>> +		"\xe3\xb0\xc4\x42\x98\xfc\x1c\x14"
>> +		"\x9a\xfb\xf4\xc8\x99\x6f\xb9\x24"
>> +		"\x27\xae\x41\xe4\x64\x9b\x93\x4c"
>> +		"\xa4\x95\x99\x1b\x78\x52\xb8\x55",
>> +
>> +		"\xd4\x1d\x8c\xd9\x8f\x00\xb2\x04"
>> +		"\xe9\x80\x09\x98\xec\xf8\x42\x7e",
>> +};
>> +
> Clearly this array must be set const, and a comment about what are thoses numbers is necessary.
> Perhaps splitting that in three arrays const xxx_zero_message_hash = ... is also better.
It's good idea. I will fix it in next version.
>
>> +static void nodata_process(struct ahash_request *req)
>> +{
>> +	struct crypto_ahash *tfm = crypto_ahash_reqtfm(req);
>> +	int rk_digest_size;
>> +
>> +	rk_digest_size = crypto_ahash_digestsize(tfm);
>> +
>> +	if (rk_digest_size == SHA1_DIGEST_SIZE)
>> +		memcpy(req->result, outdata[0], rk_digest_size);
>> +	else if (rk_digest_size == SHA256_DIGEST_SIZE)
>> +		memcpy(req->result, outdata[1], rk_digest_size);
>> +	else if (rk_digest_size == MD5_DIGEST_SIZE)
>> +		memcpy(req->result, outdata[2], rk_digest_size);
>> +}
>> +
>> +static void rk_ahash_crypto_complete(struct rk_crypto_info *dev, int err)
>> +{
>> +	if (dev->ahash_req->base.complete)
>> +		dev->ahash_req->base.complete(&dev->ahash_req->base, err);
>> +}
>> +
>> +static void rk_ahash_hw_init(struct rk_crypto_info *dev)
>> +{
>> +	int reg_status = 0;
>> +
>> +	reg_status = CRYPTO_READ(dev, RK_CRYPTO_CTRL) |
>> +		     RK_CRYPTO_HASH_FLUSH |
>> +		     _SBF(0xffff, 16);
>> +	CRYPTO_WRITE(dev, RK_CRYPTO_CTRL, reg_status);
>> +
>> +	reg_status = CRYPTO_READ(dev, RK_CRYPTO_CTRL);
>> +	reg_status &= (~RK_CRYPTO_HASH_FLUSH);
>> +	reg_status |= _SBF(0xffff, 16);
>> +	CRYPTO_WRITE(dev, RK_CRYPTO_CTRL, reg_status);
>> +
>> +	memset_io(dev->reg + RK_CRYPTO_HASH_DOUT_0, 0, 32);
>> +}
>> +
>> +static void rk_ahash_reg_init(struct rk_crypto_info *dev)
>> +{
>> +	rk_ahash_hw_init(dev);
>> +
>> +	CRYPTO_WRITE(dev, RK_CRYPTO_INTENA, RK_CRYPTO_HRDMA_ERR_ENA |
>> +					    RK_CRYPTO_HRDMA_DONE_ENA);
>> +
>> +	CRYPTO_WRITE(dev, RK_CRYPTO_INTSTS, RK_CRYPTO_HRDMA_ERR_INT |
>> +					    RK_CRYPTO_HRDMA_DONE_INT);
>> +
>> +	CRYPTO_WRITE(dev, RK_CRYPTO_HASH_CTRL, dev->mode |
>> +					       RK_CRYPTO_HASH_SWAP_DO);
>> +
>> +	CRYPTO_WRITE(dev, RK_CRYPTO_CONF, RK_CRYPTO_BYTESWAP_HRFIFO |
>> +					  RK_CRYPTO_BYTESWAP_BRFIFO |
>> +					  RK_CRYPTO_BYTESWAP_BTFIFO);
>> +}
>> +
>> +static int rk_ahash_init(struct ahash_request *req)
>> +{
>> +	struct crypto_ahash *tfm = crypto_ahash_reqtfm(req);
>> +	struct rk_ahash_ctx *tctx = crypto_tfm_ctx(req->base.tfm);
>> +	struct rk_crypto_info *dev = NULL;
>> +	int rk_digest_size;
>> +
>> +	dev = tctx->dev;
>> +	dev->left_bytes = 0;
>> +	dev->aligned = 0;
>> +	dev->ahash_req = req;
>> +	dev->mode = 0;
>> +	dev->align_size = 4;
>> +	dev->sg_dst = NULL;
>> +
>> +	tctx->first_op = 1;
>> +
>> +	rk_digest_size = crypto_ahash_digestsize(tfm);
>> +	if (!rk_digest_size)
>> +		dev_err(dev->dev, "can't get digestsize\n");
>> +	if (rk_digest_size == SHA1_DIGEST_SIZE)
>> +		dev->mode = RK_CRYPTO_HASH_SHA1;
>> +	else if (rk_digest_size == SHA256_DIGEST_SIZE)
>> +		dev->mode = RK_CRYPTO_HASH_SHA256;
>> +	else if (rk_digest_size == MD5_DIGEST_SIZE)
>> +		dev->mode = RK_CRYPTO_HASH_MD5;
>> +
>> +	rk_ahash_reg_init(dev);
>> +	return 0;
>> +}
>> +
>> +static int rk_ahash_final(struct ahash_request *req)
>> +{
>> +	struct rk_ahash_ctx *tctx = crypto_tfm_ctx(req->base.tfm);
>> +	struct rk_crypto_info *dev = tctx->dev;
>> +	struct crypto_ahash *tfm = crypto_ahash_reqtfm(dev->ahash_req);
>> +
>> +	if (!dev->total) {
>> +		nodata_process(dev->ahash_req);
>> +		return 0;
>> +	}
>> +
>> +	/*
>> +	 * IC should process the result again after last dma interrupt.
>> +	 * And the last processing is very quick so than it may entry
>> +	 * interrupt before finishing last interrupt.
>> +	 * So I don't use interrupt finished hash.
>> +	 */
>> +	while (!CRYPTO_READ(dev, RK_CRYPTO_HASH_STS))
>> +		usleep_range(50, 100);
>> +
>> +	memcpy_fromio(dev->ahash_req->result, dev->reg + RK_CRYPTO_HASH_DOUT_0,
>> +		      crypto_ahash_digestsize(tfm));
>> +	return 0;
>> +}
>> +
>> +static int rk_ahash_update(struct ahash_request *req)
>> +{
>> +	struct rk_ahash_ctx *tctx = crypto_tfm_ctx(req->base.tfm);
>> +	struct rk_crypto_info *dev = tctx->dev;
>> +	int ret;
>> +
>> +	dev->total = req->nbytes;
>> +	dev->left_bytes = req->nbytes;
>> +	dev->sg_src = req->src;
>> +	dev->first = req->src;
>> +	dev->nents = sg_nents(req->src);
>> +
>> +	/* IC can calculate 0 data hash, so it should finish update here */
>> +	if (!dev->total) {
>> +		pr_err("[%s:%d] no data\n", __func__, __LINE__);
>> +		return 0;
>> +	}
>> +
>> +	if (tctx->first_op) {
>> +		tctx->first_op = 0;
>> +		CRYPTO_WRITE(dev, RK_CRYPTO_HASH_MSG_LEN, dev->total);
>> +	} else {
>> +		/*
>> +		 * IC must know the length of total data at first,
>> +		 * multiple updatings cannot support this variable.
>> +		 */
>> +		dev_warn(dev->dev, "Cannot carry multiple updatings!\n");
>> +		return 0;
>> +	}
>> +	spin_lock(&dev->lock);
>> +	ret = crypto_enqueue_request(&dev->queue, &req->base);
>> +	spin_unlock(&dev->lock);
>> +
>> +	tasklet_schedule(&dev->crypto_tasklet);
>> +
>> +	return ret;
>> +}
>> +
>> +static int rk_ahash_finup(struct ahash_request *req)
>> +{
>> +	struct rk_ahash_ctx *tctx = crypto_tfm_ctx(req->base.tfm);
>> +	int err;
>> +
>> +	/*
>> +	 * finup should should process one updating and final.
>> +	 * and we should wait for updating in finup so that we can
>> +	 * fetching result by calling rk_ahash_final in finup.
>> +	 */
>> +
>> +	tctx->FLAG_FINUP = 1;
>> +	err = rk_ahash_update(req);
>> +	if (err == -EINPROGRESS || err == -EBUSY)
>> +		while (tctx->FLAG_FINUP)
>> +			usleep_range(50, 500);
> Please write a comment on why do you choose those numbers.
Ok, it will be fixed in next version.
>
>> +
>> +	return rk_ahash_final(req);
>> +}
>> +
>> +static int rk_ahash_digest(struct ahash_request *req)
>> +{
>> +	return rk_ahash_init(req) ? -EINVAL : rk_ahash_finup(req);
>> +}
>> +
>> +static void crypto_ahash_dma_start(struct rk_crypto_info *dev)
>> +{
>> +	CRYPTO_WRITE(dev, RK_CRYPTO_HRDMAS, dev->addr_in);
>> +	CRYPTO_WRITE(dev, RK_CRYPTO_HRDMAL, (dev->count + 3) / 4);
>> +	CRYPTO_WRITE(dev, RK_CRYPTO_CTRL, RK_CRYPTO_HASH_START |
>> +					  (RK_CRYPTO_HASH_START << 16));
>> +}
>> +
>> +static int rk_ahash_set_data_start(struct rk_crypto_info *dev)
>> +{
>> +	int err;
>> +
>> +	err = dev->load_data(dev, dev->sg_src, NULL);
>> +	if (!err)
>> +		crypto_ahash_dma_start(dev);
>> +	return err;
>> +}
>> +
>> +static int rk_ahash_start(struct rk_crypto_info *dev)
>> +{
>> +	return rk_ahash_set_data_start(dev);
>> +}
>> +
>> +/*
>> + * return:
>> + * true: some err was occurred
>> + * fault: no err, please continue
>> + */
>> +static int rk_ahash_crypto_rx(struct rk_crypto_info *dev)
>> +{
>> +	int err = 0;
>> +	struct rk_ahash_ctx *tctx = crypto_tfm_ctx(dev->ahash_req->base.tfm);
>> +
>> +	dev->unload_data(dev);
>> +	if (dev->left_bytes) {
>> +		if (dev->aligned) {
>> +			if (sg_is_last(dev->sg_src)) {
>> +				dev_warn(dev->dev, "[%s:%d], lack of data\n",
>> +					 __func__, __LINE__);
>> +				err = -ENOMEM;
>> +				goto out_rx;
>> +			}
>> +			dev->sg_src = sg_next(dev->sg_src);
>> +		}
>> +		err = rk_ahash_set_data_start(dev);
>> +	} else {
>> +		tctx->FLAG_FINUP = 0;
>> +		dev->complete(dev, 0);
>> +		return 0;
>> +	}
>> +
>> +out_rx:
>> +	return err;
>> +}
>> +
>> +static int rk_cra_hash_init(struct crypto_tfm *tfm)
>> +{
>> +	struct rk_ahash_ctx *tctx = crypto_tfm_ctx(tfm);
>> +	struct rk_crypto_tmp *algt;
>> +	struct ahash_alg *alg = __crypto_ahash_alg(tfm->__crt_alg);
>> +
>> +	algt = container_of(alg, struct rk_crypto_tmp, alg.hash);
>> +
>> +	tctx->dev = algt->dev;
>> +	tctx->dev->addr_vir = (void *)__get_free_page(GFP_KERNEL);
>> +	if (!tctx->dev->addr_vir) {
>> +		pr_err("failed to kmalloc for addr_vir\n");
> Prefer dev_err instead of pr_err
Good idea. It will be fixed in next version.
>
> Regards
>
>
>
>
Thanks
Zain