From mboxrd@z Thu Jan 1 00:00:00 1970 From: yankejian@huawei.com (Yankejian (Hackim Yim)) Date: Mon, 7 Dec 2015 09:30:56 +0800 Subject: [PATCH RESEND net-next 2/3] dts: hisi: fixes no syscon error when init mdio In-Reply-To: <5330584.WSWh7F8G32@wuerfel> References: <1449302218-54374-1-git-send-email-yankejian@huawei.com> <1449302218-54374-3-git-send-email-yankejian@huawei.com> <5330584.WSWh7F8G32@wuerfel> Message-ID: <5664E150.4020402@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015/12/6 6:15, Arnd Bergmann wrote: > On Saturday 05 December 2015 15:56:57 yankejian wrote: >> #size-cells = <0>; >> compatible = "hisilicon,hns-mdio"; >> - reg = <0x0 0x803c0000 0x0 0x10000 >> - 0x0 0x80000000 0x0 0x10000>; >> + reg = <0x0 0x803c0000 0x0 0x10000>; >> + subctrl_vbase = <&peri_c_subctrl>; >> >> soc0_phy0: ethernet-phy at 0 { >> reg = <0x0>; > I don't see the subctrl_vbase property documented in the binding. Please > modify the binding as well. > > Also, please use the normal naming conventions using '-' instead of '_' > inside of property names. > > Arnd > > . Hi, Arnd Thanks for your suggestions. i will fixes it later. From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Yankejian (Hackim Yim)" Subject: Re: [PATCH RESEND net-next 2/3] dts: hisi: fixes no syscon error when init mdio Date: Mon, 7 Dec 2015 09:30:56 +0800 Message-ID: <5664E150.4020402@huawei.com> References: <1449302218-54374-1-git-send-email-yankejian@huawei.com> <1449302218-54374-3-git-send-email-yankejian@huawei.com> <5330584.WSWh7F8G32@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5330584.WSWh7F8G32@wuerfel> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org Cc: mark.rutland@arm.com, wangkefeng.wang@huawei.com, catalin.marinas@arm.com, will.deacon@arm.com, linuxarm@huawei.com, haojian.zhuang@linaro.org, haifeng.wei@huawei.com, xuwei5@hisilicon.com, galak@codeaurora.org, dingtianhong@huawei.com, Yisen.Zhuang@huawei.com, devicetree@vger.kernel.org, bintian.wang@huawei.com, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, leo.yan@linaro.org, robh+dt@kernel.org, liguozhu@huawei.com, netdev@vger.kernel.org, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, wangzhou1@hisilicon.com, long.wanglong@huawei.com, davem@davemloft.net List-Id: devicetree@vger.kernel.org On 2015/12/6 6:15, Arnd Bergmann wrote: > On Saturday 05 December 2015 15:56:57 yankejian wrote: >> #size-cells = <0>; >> compatible = "hisilicon,hns-mdio"; >> - reg = <0x0 0x803c0000 0x0 0x10000 >> - 0x0 0x80000000 0x0 0x10000>; >> + reg = <0x0 0x803c0000 0x0 0x10000>; >> + subctrl_vbase = <&peri_c_subctrl>; >> >> soc0_phy0: ethernet-phy@0 { >> reg = <0x0>; > I don't see the subctrl_vbase property documented in the binding. Please > modify the binding as well. > > Also, please use the normal naming conventions using '-' instead of '_' > inside of property names. > > Arnd > > . Hi, Arnd Thanks for your suggestions. i will fixes it later. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755118AbbLGBgC (ORCPT ); Sun, 6 Dec 2015 20:36:02 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:52233 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754612AbbLGBf7 (ORCPT ); Sun, 6 Dec 2015 20:35:59 -0500 Subject: Re: [PATCH RESEND net-next 2/3] dts: hisi: fixes no syscon error when init mdio To: Arnd Bergmann , References: <1449302218-54374-1-git-send-email-yankejian@huawei.com> <1449302218-54374-3-git-send-email-yankejian@huawei.com> <5330584.WSWh7F8G32@wuerfel> CC: , , , , , , , , , , , , , , , , , , , , , , , From: "Yankejian (Hackim Yim)" Message-ID: <5664E150.4020402@huawei.com> Date: Mon, 7 Dec 2015 09:30:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5330584.WSWh7F8G32@wuerfel> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.57.126.191] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020204.5664E15E.0162,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 9a2dce1839862c9b4745e7d557d7c878 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/12/6 6:15, Arnd Bergmann wrote: > On Saturday 05 December 2015 15:56:57 yankejian wrote: >> #size-cells = <0>; >> compatible = "hisilicon,hns-mdio"; >> - reg = <0x0 0x803c0000 0x0 0x10000 >> - 0x0 0x80000000 0x0 0x10000>; >> + reg = <0x0 0x803c0000 0x0 0x10000>; >> + subctrl_vbase = <&peri_c_subctrl>; >> >> soc0_phy0: ethernet-phy@0 { >> reg = <0x0>; > I don't see the subctrl_vbase property documented in the binding. Please > modify the binding as well. > > Also, please use the normal naming conventions using '-' instead of '_' > inside of property names. > > Arnd > > . Hi, Arnd Thanks for your suggestions. i will fixes it later. From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Yankejian (Hackim Yim)" Subject: Re: [PATCH RESEND net-next 2/3] dts: hisi: fixes no syscon error when init mdio Date: Mon, 7 Dec 2015 09:30:56 +0800 Message-ID: <5664E150.4020402@huawei.com> References: <1449302218-54374-1-git-send-email-yankejian@huawei.com> <1449302218-54374-3-git-send-email-yankejian@huawei.com> <5330584.WSWh7F8G32@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: mark.rutland@arm.com, wangkefeng.wang@huawei.com, catalin.marinas@arm.com, will.deacon@arm.com, linuxarm@huawei.com, haojian.zhuang@linaro.org, haifeng.wei@huawei.com, xuwei5@hisilicon.com, galak@codeaurora.org, dingtianhong@huawei.com, Yisen.Zhuang@huawei.com, devicetree@vger.kernel.org, bintian.wang@huawei.com, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, leo.yan@linaro.org, robh+dt@kernel.org, liguozhu@huawei.com, netdev@vger.kernel.org, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, wangzhou1@hisilicon.com, long.wanglong@huawei.com, davem@davemloft.net To: Arnd Bergmann , Return-path: In-Reply-To: <5330584.WSWh7F8G32@wuerfel> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: netdev.vger.kernel.org On 2015/12/6 6:15, Arnd Bergmann wrote: > On Saturday 05 December 2015 15:56:57 yankejian wrote: >> #size-cells = <0>; >> compatible = "hisilicon,hns-mdio"; >> - reg = <0x0 0x803c0000 0x0 0x10000 >> - 0x0 0x80000000 0x0 0x10000>; >> + reg = <0x0 0x803c0000 0x0 0x10000>; >> + subctrl_vbase = <&peri_c_subctrl>; >> >> soc0_phy0: ethernet-phy@0 { >> reg = <0x0>; > I don't see the subctrl_vbase property documented in the binding. Please > modify the binding as well. > > Also, please use the normal naming conventions using '-' instead of '_' > inside of property names. > > Arnd > > . Hi, Arnd Thanks for your suggestions. i will fixes it later.