From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH 2/2] usb: musb: Fix unbalanced pm_runtime_enable Date: Mon, 7 Dec 2015 12:34:20 +0530 Message-ID: <56652F74.10106@ti.com> References: <1448948233-31804-1-git-send-email-tony@atomide.com> <1448948233-31804-3-git-send-email-tony@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1448948233-31804-3-git-send-email-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Tony Lindgren , Felipe Balbi Cc: Bin Liu , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, NeilBrown List-Id: linux-omap@vger.kernel.org On Tuesday 01 December 2015 11:07 AM, Tony Lindgren wrote: > When reloading omap2430 kernel module we get a warning about > unbalanced pm_runtime_enable. Let's fix this. Note that we > need to do this after the child musb-core platform_device is > removed because of pm_runtime_irq_safe being set at the child. > > Cc: Bin Liu > Cc: Felipe Balbi > Cc: Kishon Vijay Abraham I > Cc: NeilBrown > Signed-off-by: Tony Lindgren Reviewed-by: Kishon Vijay Abraham I > --- > drivers/usb/musb/omap2430.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c > index bf05f80..c84e0322 100644 > --- a/drivers/usb/musb/omap2430.c > +++ b/drivers/usb/musb/omap2430.c > @@ -664,8 +664,11 @@ static int omap2430_remove(struct platform_device *pdev) > { > struct omap2430_glue *glue = platform_get_drvdata(pdev); > > + pm_runtime_get_sync(glue->dev); > cancel_work_sync(&glue->omap_musb_mailbox_work); > platform_device_unregister(glue->musb); > + pm_runtime_put_sync(glue->dev); > + pm_runtime_disable(glue->dev); > > return 0; > } > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html