From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Nikolay Borisov <kernel@kyup.com>, fruggeri@arista.com
Cc: pablo@netfilter.org, kadlec@blackhole.kfki.hu,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH] netfilter: nfnetlink_queue: Unregister pernet subsys in case of init failure
Date: Mon, 7 Dec 2015 15:29:25 +0300 [thread overview]
Message-ID: <56657BA5.6070303@cogentembedded.com> (raw)
In-Reply-To: <1449483206-22618-1-git-send-email-kernel@kyup.com>
Hello.
On 12/07/2015 01:13 PM, Nikolay Borisov wrote:
> Commit 3bfe049807c2403 ('netfilter: nfnetlink_{log,queue}:
Double quotes please, that's what scripts/checkpatch.pl enforces now.
> Register pernet in first place') reorganised the initialisation
> order of the pernet_subsys to avoid "use-before-initialised"
> condition. However, in doing so the cleanup logic in nfnetlink_queue
> got botched in that the pernet_subsys wasn't cleaned in case
> nfnetlink_subsys_register failed. This patch adds the necessary
> cleanup routine call.
>
> Fixes: 3bfe049807c2403 ('netfilter: nfnetlink_{log,queue}: Register
> pernet in first place')
Likewise.
>
> Signed-off-by: Nikolay Borisov <kernel@kyup.com>
[...]
MBR, Sergei
next prev parent reply other threads:[~2015-12-07 12:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 10:13 [PATCH] netfilter: nfnetlink_queue: Unregister pernet subsys in case of init failure Nikolay Borisov
2015-12-07 12:29 ` Sergei Shtylyov [this message]
2015-12-07 12:58 ` Nikolay Borisov
2015-12-07 13:17 ` Pablo Neira Ayuso
2015-12-09 13:48 ` [netfilter-core] " Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56657BA5.6070303@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fruggeri@arista.com \
--cc=kadlec@blackhole.kfki.hu \
--cc=kernel@kyup.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.