All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: "Holger Hoffstätte" <holger.hoffstaette@googlemail.com>,
	"Qu Wenruo" <quwenruo@cn.fujitsu.com>,
	linux-btrfs <linux-btrfs@vger.kernel.org>,
	"Chris Mason" <clm@fb.com>
Subject: Re: [PATCH] btrfs: Enhance super validation check
Date: Mon, 7 Dec 2015 22:11:27 +0800	[thread overview]
Message-ID: <5665938F.7040508@gmx.com> (raw)
In-Reply-To: <566571F0.2010002@googlemail.com>



On 12/07/2015 07:48 PM, Holger Hoffstätte wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 12/07/15 09:39, Qu Wenruo wrote:
> (..)
>> +#define BTRFS_SUPER_FLAG_METADUMP_V2	(1ULL << 34)
>
> It looks like you diffed from a tree that has Josef's patch
> called "Btrfs: add metadump_v2 support to the kernel" [1] applied,
> which never made it upstream (probably got lost in the 4.0 mess).
> This patch is not yet in 4.4rc, so merging your patch will introduce
> half of Josef's patch but with the bits in inode.c missing.

It's based from integration-4.4.

This bit is copied from btrfs-progs.
And I added this is to make kernel accept such dump image as it used to.
(Along with fsid chaning image)

Not sure about the inode part.
But I added this just to keep the same behavior for such images.
>
> cc:'ing Chris to make sure he applies that missing patch as well.

And if Josef's patch can be merged into kernel, that would be best.

Thanks,
Qu

>
> cheers,
> Holger
>
> [1] http://www.spinics.net/lists/linux-btrfs/msg41973.html
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
>
> iEYEARECAAYFAlZlcewACgkQD4E0Cdjc7s2AjACeJKjfyJDRQBVM9y2j90MaZhjX
> ynwAn0oKMM9MTZ4I8cmuxnHGgj3ZeSv4
> =Jb6u
> -----END PGP SIGNATURE-----
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

  reply	other threads:[~2015-12-07 14:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-07  8:39 [PATCH] btrfs: Enhance super validation check Qu Wenruo
2015-12-07 11:48 ` Holger Hoffstätte
2015-12-07 14:11   ` Qu Wenruo [this message]
2015-12-07 15:02 ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5665938F.7040508@gmx.com \
    --to=quwenruo.btrfs@gmx.com \
    --cc=clm@fb.com \
    --cc=holger.hoffstaette@googlemail.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.