diff for duplicates of <5665A0EB.5050202@osg.samsung.com> diff --git a/a/1.txt b/N1/1.txt index d8d096f..f84710e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -36,9 +36,9 @@ Thanks for your feedback. >> >> /* Create links. */ >> list_for_each_entry(entity, &vsp1->entities, list_dev) { ->> - if (entity->type = VSP1_ENTITY_LIF || ->> - entity->type = VSP1_ENTITY_RPF) ->> + if (entity->type = VSP1_ENTITY_LIF) { +>> - if (entity->type == VSP1_ENTITY_LIF || +>> - entity->type == VSP1_ENTITY_RPF) +>> + if (entity->type == VSP1_ENTITY_LIF) { >> + ret = vsp1_wpf_create_pads_links(vsp1, entity); > > Could you please s/pads_links/links/ ? There's no other type of links handled @@ -62,7 +62,7 @@ Yes, that will be better indeed. >> + } >> + ->> + if (entity->type = VSP1_ENTITY_RPF) { +>> + if (entity->type == VSP1_ENTITY_RPF) { >> + ret = vsp1_rpf_create_pads_links(vsp1, entity); >> + if (ret < 0) >> + goto done; diff --git a/a/content_digest b/N1/content_digest index 87d6a38..996d5fd 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\07559062.XA9lTlmQ7K@avalon\0" "From\0Javier Martinez Canillas <javier@osg.samsung.com>\0" "Subject\0Re: [PATCH 3/5] [media] v4l: vsp1: separate links creation from entities init\0" - "Date\0Mon, 07 Dec 2015 15:08:27 +0000\0" + "Date\0Mon, 7 Dec 2015 12:08:27 -0300\0" "To\0Laurent Pinchart <laurent.pinchart@ideasonboard.com>\0" "Cc\0linux-kernel@vger.kernel.org" Hans Verkuil <hans.verkuil@cisco.com> @@ -50,9 +50,9 @@ ">>\n" ">> \t/* Create links. */\n" ">> \tlist_for_each_entry(entity, &vsp1->entities, list_dev) {\n" - ">> -\t\tif (entity->type = VSP1_ENTITY_LIF ||\n" - ">> -\t\t entity->type = VSP1_ENTITY_RPF)\n" - ">> +\t\tif (entity->type = VSP1_ENTITY_LIF) {\n" + ">> -\t\tif (entity->type == VSP1_ENTITY_LIF ||\n" + ">> -\t\t entity->type == VSP1_ENTITY_RPF)\n" + ">> +\t\tif (entity->type == VSP1_ENTITY_LIF) {\n" ">> +\t\t\tret = vsp1_wpf_create_pads_links(vsp1, entity);\n" "> \n" "> Could you please s/pads_links/links/ ? There's no other type of links handled \n" @@ -76,7 +76,7 @@ " \n" ">> +\t\t}\n" ">> +\n" - ">> +\t\tif (entity->type = VSP1_ENTITY_RPF) {\n" + ">> +\t\tif (entity->type == VSP1_ENTITY_RPF) {\n" ">> +\t\t\tret = vsp1_rpf_create_pads_links(vsp1, entity);\n" ">> +\t\t\tif (ret < 0)\n" ">> +\t\t\t\tgoto done;\n" @@ -100,4 +100,4 @@ "Open Source Group\n" Samsung Research America -a71ed4ef7e9935e21fef7d39fc3b07284b8ed07779a3e30e1e18944012c3d845 +f75e0c830cc78b63866cc49a64f5e994fb8eb51001cf7d19208af8b3f0308891
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.