From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v2 00/14] Add VMX TSC scaling support
Date: Mon, 7 Dec 2015 17:04:03 +0000
Message-ID: <5665BC03.5080901@citrix.com>
References: <1449435529-12989-1-git-send-email-haozhong.zhang@intel.com>
	<20151206211434.GA13913@hz-desktop.sh.intel.com>
	<56654B77.8030205@amazon.de>
	<20151207101624.GB3547@hz-desktop.sh.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20151207101624.GB3547@hz-desktop.sh.intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Egger, Christoph" <chegger@amazon.de>, xen-devel@lists.xen.org, Keir
	Fraser <keir@xen.org>, Jan Beulich <jbeulich@suse.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>, Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>
List-Id: xen-devel@lists.xenproject.org

On 07/12/15 10:16, Haozhong Zhang wrote:
> On 12/07/15 10:03, Egger, Christoph wrote:
>> Did you consider nested virtualization?
>> L1 hypervisor may have a different tsc scaling
>> and L2 guest again may have a different tsc scale ratio.
>>
> Oh, I forgot this. I'll check the nested TSC scaling code (mostly
> about nested SVM TSC ratio, because this patch series does not expose
> VMX TSC scaling to L1 guest).
>
> BTW, are there any practical usage scenarios of nested TSC scaling? If
> any, I may also need to consider adding nested virtualization support
> to VMX TSC scaling.

I would say that there are genuine uses for nested TSC scaling.  An L1
hypervisor is going to want to scale for the same reasons as the L0
hypervisor.

Having said that, if TSC scaling is correctly hidden from the L1 guests,
I would advise against conflating the two issues together.  i.e. getting
nested TSC scaling working is not a prerequisite for accepting this series.

~Andrew