From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felix Fietkau Subject: Re: [PATCH] net: emac: emac gigabit ethernet controller driver Date: Tue, 8 Dec 2015 00:33:04 +0100 Message-ID: <56661730.4050801@openwrt.org> References: <1449529094-10922-1-git-send-email-gavidov@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from arrakis.dune.hu ([78.24.191.176]:36758 "EHLO arrakis.dune.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932730AbbLGXdW (ORCPT ); Mon, 7 Dec 2015 18:33:22 -0500 In-Reply-To: <1449529094-10922-1-git-send-email-gavidov@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Gilad Avidov , gregkh@linuxfoundation.org, netdev@vger.kernel.org Cc: sdharia@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, vikrams@codeaurora.org, shankerd@codeaurora.org On 2015-12-07 23:58, Gilad Avidov wrote: > +/* RRD (Receive Return Descriptor) */ > +union emac_rrd { > + struct { > + /* 32bit word 0 */ > + u32 xsum:16; > + u32 nor:4; /* number of RFD */ > + u32 si:12; /* start index of rfd-ring */ > + /* 32bit word 1 */ > + u32 hash; > + /* 32bit word 2 */ You should never use bitfields for hardware structs. I think in general, kernel code should be made endian safe, even if you only care about one particular endian type for your platform. - Felix