From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Michel_D=c3=a4nzer?= Subject: Re: [PATCH 3/9] drm/vc4: Add create and map BO ioctls. Date: Tue, 8 Dec 2015 11:56:43 +0900 Message-ID: <566646EB.3050406@daenzer.net> References: <1449002158-19156-1-git-send-email-eric@anholt.net> <1449002158-19156-3-git-send-email-eric@anholt.net> <87bna1d9js.fsf@eliezer.anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.gna.ch (darkcity.gna.ch [195.226.6.51]) by gabe.freedesktop.org (Postfix) with ESMTP id 500776E7A5 for ; Mon, 7 Dec 2015 18:56:49 -0800 (PST) In-Reply-To: <87bna1d9js.fsf@eliezer.anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt , Emil Velikov Cc: "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel List-Id: dri-devel@lists.freedesktop.org T24gMDguMTIuMjAxNSAxMDoxNiwgRXJpYyBBbmhvbHQgd3JvdGU6Cj4gRW1pbCBWZWxpa292IDxl bWlsLmwudmVsaWtvdkBnbWFpbC5jb20+IHdyaXRlczoKPiAKPj4gSGkgRXJpYywKPj4KPj4gQSBj b3VwbGUgb2Ygc3VnZ2VzdGlvbnMvcmVxdWVzdHMgb24gdGhlIFVBUEkgaGVhZGVyIHNpZGUKPj4K Pj4gT24gMSBEZWNlbWJlciAyMDE1IGF0IDIwOjM1LCBFcmljIEFuaG9sdCA8ZXJpY0BhbmhvbHQu bmV0PiB3cm90ZToKPj4KPj4+IC0tLSAvZGV2L251bGwKPj4+ICsrKyBiL2luY2x1ZGUvdWFwaS9k cm0vdmM0X2RybS5oCj4+Cj4+PiArI2luY2x1ZGUgPGRybS9kcm0uaD4KPj4+ICsKPj4gQ2FuIHdl IG1ha2UgdGhpcyBhICJkcm0uaCIgPwo+IAo+IE5vcGUuCj4gCj4gaW5jbHVkZS91YXBpL2RybS92 YzRfZHJtLmg6Mjc6MTc6IGZhdGFsIGVycm9yOiBkcm0uaDogTm8gc3VjaCBmaWxlIG9yIGRpcmVj dG9yeQoKV2hhdCBoYXBwZW5lZCB0byBpbmNsdWRlL3VhcGkvZHJtL2RybS5oIGluIHRoYXQgdHJl ZT8KCgo+IGFuZCBub25lIG9mIHRoZSBkcml2ZXJzIGRvLCBlaXRoZXIuCgpkYWVuemVyQGthdmVy aXwxMTo1NTozMT4gZ3JlcCAnI2luY2x1ZGUgImRybS5oIicgaW5jbHVkZS91YXBpL2RybS8qCmlu Y2x1ZGUvdWFwaS9kcm0vYW1kZ3B1X2RybS5oOiNpbmNsdWRlICJkcm0uaCIKaW5jbHVkZS91YXBp L2RybS9yYWRlb25fZHJtLmg6I2luY2x1ZGUgImRybS5oIgoKUGF0Y2hlcyB0byBjb252ZXJ0IHRo ZSByZXN0IGFyZSBwZW5kaW5nLgoKCi0tIApFYXJ0aGxpbmcgTWljaGVsIETDpG56ZXIgICAgICAg ICAgICAgICB8ICAgICAgICAgICAgICAgaHR0cDovL3d3dy5hbWQuY29tCkxpYnJlIHNvZnR3YXJl IGVudGh1c2lhc3QgICAgICAgICAgICAgfCAgICAgICAgICAgICBNZXNhIGFuZCBYIGRldmVsb3Bl cgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932495AbbLHC4w (ORCPT ); Mon, 7 Dec 2015 21:56:52 -0500 Received: from darkcity.gna.ch ([195.226.6.51]:47946 "EHLO mail.gna.ch" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755267AbbLHC4v (ORCPT ); Mon, 7 Dec 2015 21:56:51 -0500 Subject: Re: [PATCH 3/9] drm/vc4: Add create and map BO ioctls. To: Eric Anholt , Emil Velikov References: <1449002158-19156-1-git-send-email-eric@anholt.net> <1449002158-19156-3-git-send-email-eric@anholt.net> <87bna1d9js.fsf@eliezer.anholt.net> Cc: "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel From: =?UTF-8?Q?Michel_D=c3=a4nzer?= X-Enigmail-Draft-Status: N1110 Message-ID: <566646EB.3050406@daenzer.net> Date: Tue, 8 Dec 2015 11:56:43 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.4.0 MIME-Version: 1.0 In-Reply-To: <87bna1d9js.fsf@eliezer.anholt.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08.12.2015 10:16, Eric Anholt wrote: > Emil Velikov writes: > >> Hi Eric, >> >> A couple of suggestions/requests on the UAPI header side >> >> On 1 December 2015 at 20:35, Eric Anholt wrote: >> >>> --- /dev/null >>> +++ b/include/uapi/drm/vc4_drm.h >> >>> +#include >>> + >> Can we make this a "drm.h" ? > > Nope. > > include/uapi/drm/vc4_drm.h:27:17: fatal error: drm.h: No such file or directory What happened to include/uapi/drm/drm.h in that tree? > and none of the drivers do, either. daenzer@kaveri|11:55:31> grep '#include "drm.h"' include/uapi/drm/* include/uapi/drm/amdgpu_drm.h:#include "drm.h" include/uapi/drm/radeon_drm.h:#include "drm.h" Patches to convert the rest are pending. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer