Re: [PATCH 1/2] drm/i915/skl: Disable coarse power gating up until F0

From: "Kamble, Sagar A" <sagar.a.kamble@intel.com>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915/skl: Disable coarse power gating up until F0
Date: Tue, 8 Dec 2015 15:03:20 +0530	[thread overview]
Message-ID: <5666A3E0.8090300@intel.com> (raw)
In-Reply-To: <1449505785-20812-1-git-send-email-mika.kuoppala@intel.com>

Reviewed-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>

On 12/7/2015 9:59 PM, Mika Kuoppala wrote:
> There is conflicting info between E0 and F0 steppings
> for this workarounds. Trust more authoritative source and
> be conservative and extend also for F0.
>
> This prevents numerous (>50) gpu hangs with SKL GT4e
> during piglit run.
>
> References: HSD: gen9lp/2134184
> Cc: Sagar Arun Kamble <sagar.a.kamble@intel.com>
> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
> ---
>   drivers/gpu/drm/i915/intel_pm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index ee05ce8..7096c06 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -4717,7 +4717,7 @@ static void gen9_enable_rc6(struct drm_device *dev)
>   	 */
>   	if (IS_BXT_REVID(dev, 0, BXT_REVID_A1) ||
>   	    ((IS_SKL_GT3(dev) || IS_SKL_GT4(dev)) &&
> -	     IS_SKL_REVID(dev, 0, SKL_REVID_E0)))
> +	     IS_SKL_REVID(dev, 0, SKL_REVID_F0)))
>   		I915_WRITE(GEN9_PG_ENABLE, 0);
>   	else
>   		I915_WRITE(GEN9_PG_ENABLE, (rc6_mask & GEN6_RC_CTL_RC6_ENABLE) ?

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx