All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Suzuki K. Poulose" <Suzuki.Poulose@arm.com>
To: Al Viro <viro@ZenIV.linux.org.uk>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Marc Zyngier <marc.zyngier@arm.com>, Tejun Heo <tj@kernel.org>,
	stable <stable@vger.kernel.org>
Subject: Re: [PATCH] blkdev: Fix blkdev_open to release the bdev on error
Date: Tue, 8 Dec 2015 10:08:56 +0000	[thread overview]
Message-ID: <5666AC38.8050806@arm.com> (raw)
In-Reply-To: <20151208075854.GN20997@ZenIV.linux.org.uk>

On 08/12/15 07:58, Al Viro wrote:
> On Mon, Dec 07, 2015 at 10:49:05AM -0800, Linus Torvalds wrote:
>> On Mon, Dec 7, 2015 at 10:05 AM, Suzuki K. Poulose
>> <suzuki.poulose@arm.com> wrote:

...

> Anyway, the fix for 9p bogosity follows; it definitely fixes a bug there,
> and I'm fairly sure that it fixes the bug that had been reported.
> A confirmation would be nice, of course...
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
> diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c
> index 699941e..5110785 100644
> --- a/fs/9p/vfs_inode.c
> +++ b/fs/9p/vfs_inode.c
> @@ -451,9 +451,9 @@ void v9fs_evict_inode(struct inode *inode)
>   {
>   	struct v9fs_inode *v9inode = V9FS_I(inode);
>
> -	truncate_inode_pages_final(inode->i_mapping);
> +	truncate_inode_pages_final(&inode->i_data);
>   	clear_inode(inode);
> -	filemap_fdatawrite(inode->i_mapping);
> +	filemap_fdatawrite(&inode->i_data);
>
>   	v9fs_cache_inode_put_cookie(inode);
>   	/* clunk the fid stashed in writeback_fid */
>

This patch fixes the problem :

Tested-by: Suzuki K. Poulose <suzuki.poulose@arm.com>

Thanks
Suzuki



  reply	other threads:[~2015-12-08 10:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-07 18:05 [PATCH] blkdev: Fix blkdev_open to release the bdev on error Suzuki K. Poulose
2015-12-07 18:49 ` Linus Torvalds
2015-12-08  7:58   ` Al Viro
2015-12-08 10:08     ` Suzuki K. Poulose [this message]
2015-12-08 11:56       ` Vegard Nossum
2015-12-08  7:25 ` Al Viro
2015-12-08 10:07   ` Suzuki K. Poulose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5666AC38.8050806@arm.com \
    --to=suzuki.poulose@arm.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=stable@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.