From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 08 Dec 2015 11:31:04 +0100 (CET) Received: from mailapp01.imgtec.com ([195.59.15.196]:16381 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27006859AbbLHKbChsrKp (ORCPT ); Tue, 8 Dec 2015 11:31:02 +0100 Received: from hhmail02.hh.imgtec.org (unknown [10.100.10.20]) by Websense Email Security Gateway with ESMTPS id 4417FF98715BF; Tue, 8 Dec 2015 10:30:54 +0000 (GMT) Received: from LEMAIL01.le.imgtec.org (192.168.152.62) by hhmail02.hh.imgtec.org (10.100.10.20) with Microsoft SMTP Server (TLS) id 14.3.235.1; Tue, 8 Dec 2015 10:30:56 +0000 Received: from [192.168.154.22] (192.168.154.22) by LEMAIL01.le.imgtec.org (192.168.152.62) with Microsoft SMTP Server (TLS) id 14.3.210.2; Tue, 8 Dec 2015 10:30:55 +0000 Subject: Re: [PATCH 05/23] mtd: nand: jz4770: kill the ->ecc_layout field To: Boris Brezillon , David Woodhouse , Brian Norris , References: <1449527178-5930-1-git-send-email-boris.brezillon@free-electrons.com> <1449527178-5930-6-git-send-email-boris.brezillon@free-electrons.com> CC: Daniel Mack , Haojian Zhuang , Robert Jarzmik , "Kukjin Kim" , Krzysztof Kozlowski , , , Ralf Baechle , , Josh Wu , Ezequiel Garcia , Maxime Ripard , Chen-Yu Tsai , , Stefan Agner , Kyungmin Park , "Greg Kroah-Hartman" , , , punnaiah choudary kalluri From: Harvey Hunt Message-ID: <5666B150.2030406@imgtec.com> Date: Tue, 8 Dec 2015 10:30:40 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1449527178-5930-6-git-send-email-boris.brezillon@free-electrons.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.22] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 50417 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: harvey.hunt@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Hi Boris, On 07/12/15 22:26, Boris Brezillon wrote: > ->ecc_layout is not used by any board file. Kill this field to avoid any > confusion. New boards are encouraged to use the default ECC layout defined > in NAND core. > > Signed-off-by: Boris Brezillon > --- > arch/mips/include/asm/mach-jz4740/jz4740_nand.h | 2 -- > drivers/mtd/nand/jz4740_nand.c | 3 --- > 2 files changed, 5 deletions(-) > > diff --git a/arch/mips/include/asm/mach-jz4740/jz4740_nand.h b/arch/mips/include/asm/mach-jz4740/jz4740_nand.h > index 79cff26..398733e 100644 > --- a/arch/mips/include/asm/mach-jz4740/jz4740_nand.h > +++ b/arch/mips/include/asm/mach-jz4740/jz4740_nand.h > @@ -25,8 +25,6 @@ struct jz_nand_platform_data { > int num_partitions; > struct mtd_partition *partitions; > > - struct nand_ecclayout *ecc_layout; > - > unsigned char banks[JZ_NAND_NUM_BANKS]; > > void (*ident_callback)(struct platform_device *, struct nand_chip *, > diff --git a/drivers/mtd/nand/jz4740_nand.c b/drivers/mtd/nand/jz4740_nand.c > index 5a99a93..c4fe446 100644 > --- a/drivers/mtd/nand/jz4740_nand.c > +++ b/drivers/mtd/nand/jz4740_nand.c > @@ -446,9 +446,6 @@ static int jz_nand_probe(struct platform_device *pdev) > chip->ecc.bytes = 9; > chip->ecc.strength = 4; > > - if (pdata) > - chip->ecc.layout = pdata->ecc_layout; > - > chip->chip_delay = 50; > chip->cmd_ctrl = jz_nand_cmd_ctrl; > chip->select_chip = jz_nand_select_chip; > Is there a typo in this commit title? The JZ4740 and JZ4770 have quite different NAND controller interfaces, so I don't think that the JZ4740 driver will support the JZ4770. Thanks, Harvey From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:16381 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27006859AbbLHKbChsrKp (ORCPT ); Tue, 8 Dec 2015 11:31:02 +0100 Subject: Re: [PATCH 05/23] mtd: nand: jz4770: kill the ->ecc_layout field References: <1449527178-5930-1-git-send-email-boris.brezillon@free-electrons.com> <1449527178-5930-6-git-send-email-boris.brezillon@free-electrons.com> From: Harvey Hunt Message-ID: <5666B150.2030406@imgtec.com> Date: Tue, 8 Dec 2015 10:30:40 +0000 MIME-Version: 1.0 In-Reply-To: <1449527178-5930-6-git-send-email-boris.brezillon@free-electrons.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Boris Brezillon , David Woodhouse , Brian Norris , linux-mtd@lists.infradead.org Cc: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Kukjin Kim , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ralf Baechle , linux-mips@linux-mips.org, Josh Wu , Ezequiel Garcia , Maxime Ripard , Chen-Yu Tsai , linux-sunxi@googlegroups.com, Stefan Agner , Kyungmin Park , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, punnaiah choudary kalluri Message-ID: <20151208103040.db34MpuWv-TllDa9r-Sn-z0DgDUkll9lh-s771-w6ss@z> Hi Boris, On 07/12/15 22:26, Boris Brezillon wrote: > ->ecc_layout is not used by any board file. Kill this field to avoid any > confusion. New boards are encouraged to use the default ECC layout defined > in NAND core. > > Signed-off-by: Boris Brezillon > --- > arch/mips/include/asm/mach-jz4740/jz4740_nand.h | 2 -- > drivers/mtd/nand/jz4740_nand.c | 3 --- > 2 files changed, 5 deletions(-) > > diff --git a/arch/mips/include/asm/mach-jz4740/jz4740_nand.h b/arch/mips/include/asm/mach-jz4740/jz4740_nand.h > index 79cff26..398733e 100644 > --- a/arch/mips/include/asm/mach-jz4740/jz4740_nand.h > +++ b/arch/mips/include/asm/mach-jz4740/jz4740_nand.h > @@ -25,8 +25,6 @@ struct jz_nand_platform_data { > int num_partitions; > struct mtd_partition *partitions; > > - struct nand_ecclayout *ecc_layout; > - > unsigned char banks[JZ_NAND_NUM_BANKS]; > > void (*ident_callback)(struct platform_device *, struct nand_chip *, > diff --git a/drivers/mtd/nand/jz4740_nand.c b/drivers/mtd/nand/jz4740_nand.c > index 5a99a93..c4fe446 100644 > --- a/drivers/mtd/nand/jz4740_nand.c > +++ b/drivers/mtd/nand/jz4740_nand.c > @@ -446,9 +446,6 @@ static int jz_nand_probe(struct platform_device *pdev) > chip->ecc.bytes = 9; > chip->ecc.strength = 4; > > - if (pdata) > - chip->ecc.layout = pdata->ecc_layout; > - > chip->chip_delay = 50; > chip->cmd_ctrl = jz_nand_cmd_ctrl; > chip->select_chip = jz_nand_select_chip; > Is there a typo in this commit title? The JZ4740 and JZ4770 have quite different NAND controller interfaces, so I don't think that the JZ4740 driver will support the JZ4770. Thanks, Harvey From mboxrd@z Thu Jan 1 00:00:00 1970 From: harvey.hunt@imgtec.com (Harvey Hunt) Date: Tue, 8 Dec 2015 10:30:40 +0000 Subject: [PATCH 05/23] mtd: nand: jz4770: kill the ->ecc_layout field In-Reply-To: <1449527178-5930-6-git-send-email-boris.brezillon@free-electrons.com> References: <1449527178-5930-1-git-send-email-boris.brezillon@free-electrons.com> <1449527178-5930-6-git-send-email-boris.brezillon@free-electrons.com> Message-ID: <5666B150.2030406@imgtec.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Boris, On 07/12/15 22:26, Boris Brezillon wrote: > ->ecc_layout is not used by any board file. Kill this field to avoid any > confusion. New boards are encouraged to use the default ECC layout defined > in NAND core. > > Signed-off-by: Boris Brezillon > --- > arch/mips/include/asm/mach-jz4740/jz4740_nand.h | 2 -- > drivers/mtd/nand/jz4740_nand.c | 3 --- > 2 files changed, 5 deletions(-) > > diff --git a/arch/mips/include/asm/mach-jz4740/jz4740_nand.h b/arch/mips/include/asm/mach-jz4740/jz4740_nand.h > index 79cff26..398733e 100644 > --- a/arch/mips/include/asm/mach-jz4740/jz4740_nand.h > +++ b/arch/mips/include/asm/mach-jz4740/jz4740_nand.h > @@ -25,8 +25,6 @@ struct jz_nand_platform_data { > int num_partitions; > struct mtd_partition *partitions; > > - struct nand_ecclayout *ecc_layout; > - > unsigned char banks[JZ_NAND_NUM_BANKS]; > > void (*ident_callback)(struct platform_device *, struct nand_chip *, > diff --git a/drivers/mtd/nand/jz4740_nand.c b/drivers/mtd/nand/jz4740_nand.c > index 5a99a93..c4fe446 100644 > --- a/drivers/mtd/nand/jz4740_nand.c > +++ b/drivers/mtd/nand/jz4740_nand.c > @@ -446,9 +446,6 @@ static int jz_nand_probe(struct platform_device *pdev) > chip->ecc.bytes = 9; > chip->ecc.strength = 4; > > - if (pdata) > - chip->ecc.layout = pdata->ecc_layout; > - > chip->chip_delay = 50; > chip->cmd_ctrl = jz_nand_cmd_ctrl; > chip->select_chip = jz_nand_select_chip; > Is there a typo in this commit title? The JZ4740 and JZ4770 have quite different NAND controller interfaces, so I don't think that the JZ4740 driver will support the JZ4770. Thanks, Harvey