All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Pitoiset <samuel.pitoiset-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Emil Velikov <emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: ML nouveau
	<nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
	Ben Skeggs <bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [mesa v2 8/9] nvc0: remove allocation of unused sw class
Date: Tue, 8 Dec 2015 17:05:52 +0100	[thread overview]
Message-ID: <5666FFE0.8080305@gmail.com> (raw)
In-Reply-To: <CACvgo50HH6fk+AtpGRsbkfzsn8nPDndcqzMo54cUfwX4hCjFsg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>



On 12/08/2015 04:30 PM, Emil Velikov wrote:
> On 8 December 2015 at 14:56, Samuel Pitoiset <samuel.pitoiset@gmail.com> wrote:
>> NACK.
>>
>> This patches breaks MP performance counters on Fermi/Kepler because they
>> actually use software methods to configure multiplexers. Global perf
>> counters will also use software methods to init, sample and read hardware
>> counters, so this SW object is definitely needed.
>>
> I'm curious how exactly this happens. Afaict there is no reference to
> the nvsw object, which ought to be used, wouldn't it ?
> Imho if there is something subtle it's worth adding a comment.

Usually, we need to "register" a subchannel using
the NV01_SUBCHAN_OBJECT command, but surprisingly this doesn't seem to 
be needed for this SW subchan. Probably because it's not *really* a 
subchan like 3D, 2D, COMPUTE, M2MF and so on.

I'm not sure if the right way is to use NV01_SUBCHAN_OBJECT like other 
subchans (even if this one won't change anything), or to add a comment.

Ben, any ideas?

>
> -Emil
>

-- 
-Samuel
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

  parent reply	other threads:[~2015-12-08 16:05 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-27  1:04 [mesa v2 1/9] nouveau: bump required libdrm version to 2.4.66 Ben Skeggs
     [not found] ` <1448586301-8351-1-git-send-email-skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-11-27  1:04   ` [mesa v2 2/9] nouveau: remove use of deprecated nouveau_device::fd Ben Skeggs
2015-11-27  1:04   ` [mesa v2 3/9] nouveau: remove use of deprecated nouveau_device::drm_version Ben Skeggs
2015-11-27  1:04   ` [mesa v2 4/9] nouveau: return nouveau_screen from hw-specific creation functions Ben Skeggs
2015-11-27  1:04   ` [mesa v2 5/9] nouveau: fix screen creation failure paths Ben Skeggs
     [not found]     ` <1448586301-8351-5-git-send-email-skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-12-07  3:40       ` Ilia Mirkin
     [not found]         ` <CAKb7UvjwbztKvR3-PaUA+8=A+NZqBzCeP1KT7AfrNLq4HQsReQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-07  3:48           ` Ben Skeggs
     [not found]             ` <566501AA.9010600-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-12-07  3:53               ` Ilia Mirkin
     [not found]                 ` <CAKb7Uvj_3wzh19C+TPe9c_1QJuGgU=JwrZeasjswZ4uM3JcoiA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-07  3:57                   ` Ben Skeggs
2015-11-27  1:04   ` [mesa v2 6/9] nouveau: remove use of deprecated nouveau_device_wrap() Ben Skeggs
2015-11-27  1:04   ` [mesa v2 7/9] nv50: fix g98+ vdec class allocation Ben Skeggs
2015-11-27  1:05   ` [mesa v2 8/9] nvc0: remove allocation of unused sw class Ben Skeggs
     [not found]     ` <1448586301-8351-8-git-send-email-skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-12-08 14:56       ` Samuel Pitoiset
     [not found]         ` <5666EF90.2000701-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-12-08 15:30           ` Emil Velikov
     [not found]             ` <CACvgo50HH6fk+AtpGRsbkfzsn8nPDndcqzMo54cUfwX4hCjFsg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-08 16:05               ` Samuel Pitoiset [this message]
2015-11-27  1:05   ` [mesa v2 9/9] nouveau: enable use of new kernel interfaces Ben Skeggs
     [not found]     ` <1448586301-8351-9-git-send-email-skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-12-07  3:46       ` Ilia Mirkin
2015-12-07  3:32   ` [mesa v2 1/9] nouveau: bump required libdrm version to 2.4.66 Ilia Mirkin
2015-12-07  3:49     ` Ben Skeggs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5666FFE0.8080305@gmail.com \
    --to=samuel.pitoiset-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.