From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergio Gonzalez Monroy Subject: Re: [PATCH v2] mk: fix external shared library dependencies of libraries Date: Tue, 8 Dec 2015 16:28:06 +0000 Message-ID: <56670516.7050701@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Panu Matilainen Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 95DEC37A6 for ; Tue, 8 Dec 2015 17:28:26 +0100 (CET) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 08/12/2015 11:47, Panu Matilainen wrote: > Similar to commit 5f9115e58cc6f304ff4ade694cf5823d32887d1a etc, but > for libraries. Clean up librte_vhost CFLAGS/LDFLAGS/LDLIBS confusion > while at it. > > Requiring applications to know about library internal details like > dependencies to external helper libraries is a limitation of > static linkage, shared libraries should always know their own > dependencies for sane operation. > > Linking with the combined library (whether shared or not) still > requires knowing the internal dependencies, and intra-dpdk > dependencies are also not currently recorded. > > Signed-off-by: Panu Matilainen > --- > > v2: > - clean up librte_vhost CFLAGS/LDFLAGS/LDLIBS confusion while at it > > Hi Panu, Patch itself looks good but there is a small side effect on BSD that results in app/test not linking because of missing -lm. Linuxapp links with -lm by default (EXECENV_LDLIBS), but BSD does not. Should we just add -lm to EXECENV_LDLIBS for BSD too instead of adding it on each app/example that uses librte_sched ? Sergio