All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan_Lynch@mentor.com (Nathan Lynch)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM:VDSO: use PTR_ERR_OR_ZERO for vma check
Date: Tue, 8 Dec 2015 10:35:51 -0600	[thread overview]
Message-ID: <566706E7.5010200@mentor.com> (raw)
In-Reply-To: <5654DC2E.7080908@mentor.com>

On 11/24/2015 03:52 PM, Nathan Lynch wrote:
> On 11/24/2015 12:56 AM, Mutharaju, Prasanna (P.) wrote:
>> From: Prasanna Karthik <mkarthi3@visteon.com>
>>
>> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>>
>> Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com>
>> ---
>>  arch/arm/kernel/vdso.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/kernel/vdso.c b/arch/arm/kernel/vdso.c
>> index 54a5aea..994e971 100644
>> --- a/arch/arm/kernel/vdso.c
>> +++ b/arch/arm/kernel/vdso.c
>> @@ -224,7 +224,7 @@ static int install_vvar(struct mm_struct *mm, unsigned long addr)
>>  				       VM_READ | VM_MAYREAD,
>>  				       &vdso_data_mapping);
>>  
>> -	return IS_ERR(vma) ? PTR_ERR(vma) : 0;
>> +	return PTR_ERR_OR_ZERO(vma);
>>  }
>>  
> 
> Thanks, I think this is fine, but I won't be able to properly process
> this until next week.

I've verified that this results in no change in generated code, and I
have sent it to Russell to queue for 4.5, thanks.

      reply	other threads:[~2015-12-08 16:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-24  6:56 [PATCH] ARM:VDSO: use PTR_ERR_OR_ZERO for vma check Mutharaju, Prasanna (P.)
2015-11-24 21:52 ` Nathan Lynch
2015-12-08 16:35   ` Nathan Lynch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=566706E7.5010200@mentor.com \
    --to=nathan_lynch@mentor.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.