From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1a6Lrj-00087K-JJ for mharc-grub-devel@gnu.org; Tue, 08 Dec 2015 12:15:51 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36984) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6Lrh-00086r-1e for grub-devel@gnu.org; Tue, 08 Dec 2015 12:15:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a6Lre-0006sJ-83 for grub-devel@gnu.org; Tue, 08 Dec 2015 12:15:48 -0500 Received: from mail-lf0-x236.google.com ([2a00:1450:4010:c07::236]:34645) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6Lrd-0006rj-Tv for grub-devel@gnu.org; Tue, 08 Dec 2015 12:15:46 -0500 Received: by lffu14 with SMTP id u14so17122666lff.1 for ; Tue, 08 Dec 2015 09:15:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type:content-transfer-encoding; bh=HdiRmnIFw18znAjc6pTC2eSPV0HyrGtCreYXuYsroQc=; b=HyvUgscyjxhq0J+ZSXGUnp1RJC0kE1+liFDjw/LZni0o7cyKLe3K9xSXIOHXr9BbvV vr7JyAK7LuMouRnkqRccYxaYz9c/q1aERCTUImHA8uA6auaKwm1IwvvFwgBSh71Xd/32 SDK5+Fwbk2pQ7qDv0Mp2bxrNTvSarxFyJ8GEVMP/i9n0hjKJkwzL1vJeExS/uziCvF8k iIGk8/akKqh5K/1IlBvpJH9xpARsTUcccYrWcPsOYOndR6RatF5CmKU9mtAWL1NKJsiS gyLsnVQ3W3fTZHdPfKJjjyxvaqL4FoQSscI34E+LRHtHytTKZsva1oTXe+KSdAeklXYX DPiA== X-Received: by 10.25.148.204 with SMTP id w195mr292583lfd.108.1449594945040; Tue, 08 Dec 2015 09:15:45 -0800 (PST) Received: from [192.168.1.41] (ppp91-76-25-247.pppoe.mtu-net.ru. [91.76.25.247]) by smtp.gmail.com with ESMTPSA id m64sm715801lfd.45.2015.12.08.09.15.43 for (version=TLSv1/SSLv3 cipher=OTHER); Tue, 08 Dec 2015 09:15:43 -0800 (PST) Subject: Re: grub causing NVDIMMs to be treated as normal memory To: grub-devel@gnu.org References: <94D0CD8314A33A4D9D801C0FE68B40295BE539AF@G9W0745.americas.hpqcorp.net> <5655FFC3.9030603@gmail.com> <94D0CD8314A33A4D9D801C0FE68B40295BE5549A@G9W0745.americas.hpqcorp.net> <56567CC3.3040405@gmail.com> <94D0CD8314A33A4D9D801C0FE68B40295BE55713@G9W0745.americas.hpqcorp.net> <56573973.9060806@gmail.com> <94D0CD8314A33A4D9D801C0FE68B40295BE56257@G9W0745.americas.hpqcorp.net> <5657D4CD.7060205@gmail.com> <94D0CD8314A33A4D9D801C0FE68B40295BE575A4@G9W0745.americas.hpqcorp.net> <5658399A.8020101@gmail.com> <94D0CD8314A33A4D9D801C0FE68B40295BE58183@G9W0745.americas.hpqcorp.net> <94D0CD8314A33A4D9D801C0FE68B40295BE7E188@G4W3202.americas.hpqcorp.net> From: Andrei Borzenkov X-Enigmail-Draft-Status: N1110 Message-ID: <5667103F.30304@gmail.com> Date: Tue, 8 Dec 2015 20:15:43 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <94D0CD8314A33A4D9D801C0FE68B40295BE7E188@G4W3202.americas.hpqcorp.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::236 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Dec 2015 17:15:50 -0000 03.12.2015 20:50, Elliott, Robert (Persistent Memory) пишет: > From bd13098e80422444d60e08cb856093bf671df2bf Mon Sep 17 00:00:00 2001 > From: Robert Elliott > Date: Thu, 3 Dec 2015 11:38:36 -0600 > Subject: [PATCH 1/4] Translate UEFI persistent memory type > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > Define > * GRUB_EFI_PERSISTENT_MEMORY (UEFI memory map type 14) per UEFI 2.5 > * GRUB_EFI_PMEM (E820 type 7) per ACPI 3.0 > * GRUB_EFI_PRAM (E820 unofficial type 12) per ACPI 3.0 > Well, ACPI talks about AddressRangePersistentMemory and "OEM defined". Let's not confuse future hackers. GRUB_MEMORY_PERSISTENT GRUB_MEMORY_PERSISTENT_LEGACY makes them obvious; PMEM and PRAM not. Neither PMEM nor PRAM are found in ACPI spec. > and translate GRUB_EFI_PERSISTENT_MEMORY to GRUB_EFI_PMEM in > grub_efi_mmap_iterate(). > > Includes > * adding the E820 names to lsmmap > * handling the E820 types in make_efi_memtype() > > Suggested-by: Vladimir 'П†-coder/phcoder' Serbinenko > Suggested-by: Andrei Borzenkov > --- > grub-core/commands/lsmmap.c | 2 ++ > grub-core/mmap/efi/mmap.c | 11 +++++++++++ > include/grub/efi/api.h | 1 + > include/grub/memory.h | 2 ++ > 4 files changed, 16 insertions(+) > > diff --git a/grub-core/commands/lsmmap.c b/grub-core/commands/lsmmap.c > index 4b504fd..1ff7276 100644 > --- a/grub-core/commands/lsmmap.c > +++ b/grub-core/commands/lsmmap.c > @@ -37,6 +37,8 @@ static const char *names[] = > is required to save accross hibernations. */ > [GRUB_MEMORY_NVS] = N_("ACPI non-volatile storage RAM"), > [GRUB_MEMORY_BADRAM] = N_("faulty RAM (BadRAM)"), > + [GRUB_MEMORY_PMEM] = N_("persistent memory"), > + [GRUB_MEMORY_PRAM] = N_("persistent memory (legacy)"), visually "persistent RAM" and "persistent RAM (legacy)" aligns better with surrounding text. > [GRUB_MEMORY_COREBOOT_TABLES] = N_("RAM holding coreboot tables"), > [GRUB_MEMORY_CODE] = N_("RAM holding firmware code") > }; > diff --git a/grub-core/mmap/efi/mmap.c b/grub-core/mmap/efi/mmap.c > index 900a4d6..5acd405 100644 > --- a/grub-core/mmap/efi/mmap.c > +++ b/grub-core/mmap/efi/mmap.c > @@ -118,6 +118,11 @@ grub_efi_mmap_iterate (grub_memory_hook_t hook, void *hook_data, > GRUB_MEMORY_NVS, hook_data); > break; > > + case GRUB_EFI_PERSISTENT_MEMORY: > + hook (desc->physical_start, desc->num_pages * 4096, > + GRUB_MEMORY_PMEM, hook_data); > + break; > + > default: > grub_printf ("Unknown memory type %d, considering reserved\n", > desc->type); > @@ -147,6 +152,12 @@ make_efi_memtype (int type) > /* No way to remove a chunk of memory from EFI mmap. > So mark it as unusable. */ > case GRUB_MEMORY_HOLE: > + /* > + * AllocatePages() does not support GRUB_EFI_PERSISTENT_MEMORY, > + * so no translation for GRUB_MEMORY_PMEM or GRUB_MEMORY_PRAM. > + */ > + case GRUB_MEMORY_PMEM: > + case GRUB_MEMORY_PRAM: > case GRUB_MEMORY_RESERVED: > return GRUB_EFI_UNUSABLE_MEMORY; > > diff --git a/include/grub/efi/api.h b/include/grub/efi/api.h > index 24a05c5..2bbfe34 100644 > --- a/include/grub/efi/api.h > +++ b/include/grub/efi/api.h > @@ -476,6 +476,7 @@ enum grub_efi_memory_type > GRUB_EFI_MEMORY_MAPPED_IO, > GRUB_EFI_MEMORY_MAPPED_IO_PORT_SPACE, > GRUB_EFI_PAL_CODE, > + GRUB_EFI_PERSISTENT_MEMORY, > GRUB_EFI_MAX_MEMORY_TYPE > }; > typedef enum grub_efi_memory_type grub_efi_memory_type_t; > diff --git a/include/grub/memory.h b/include/grub/memory.h > index 083cfb6..1894c9d 100644 > --- a/include/grub/memory.h > +++ b/include/grub/memory.h > @@ -30,6 +30,8 @@ typedef enum grub_memory_type > GRUB_MEMORY_ACPI = 3, > GRUB_MEMORY_NVS = 4, > GRUB_MEMORY_BADRAM = 5, > + GRUB_MEMORY_PMEM = 7, > + GRUB_MEMORY_PRAM = 12, > GRUB_MEMORY_COREBOOT_TABLES = 16, > GRUB_MEMORY_CODE = 20, > /* This one is special: it's used internally but is never reported > -- 2.4.3 Regarding efiemu - this is used in one very specific case - to boot OS X kernel out of CSM emulation. It is unlikely we'll see persistent memory on any platform where it is still needed; I doubt anyone can actually test it, so it is probably better to leave it as is.