From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCHv6] 02/28] build: build Kconfig and config rules Date: Tue, 8 Dec 2015 11:59:16 -0600 Message-ID: <56671A74.7020105@cardoe.com> References: <1448387538-12208-1-git-send-email-cardoe@cardoe.com> <1448387538-12208-3-git-send-email-cardoe@cardoe.com> <565C6CEF02000078000BA42E@prv-mh.provo.novell.com> <565C8D06.4080907@cardoe.com> <565D90FE02000078000BAA7C@prv-mh.provo.novell.com> <565F8E25.6070008@cardoe.com> <566011FB02000078000BB930@prv-mh.provo.novell.com> <5665F9CC.60408@cardoe.com> <5666959B02000078000BD043@prv-mh.provo.novell.com> <5666E62F.2090200@cardoe.com> <5666F66A02000078000BD3D2@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4100903528354489831==" Return-path: In-Reply-To: <5666F66A02000078000BD3D2@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Andrew Cooper , Keir Fraser , Stefano Stabellini , Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============4100903528354489831== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="VM7v6ICPrvbGfavnHL57Bj9lXED6UnInl" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --VM7v6ICPrvbGfavnHL57Bj9lXED6UnInl Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 12/8/15 8:25 AM, Jan Beulich wrote: >>>> On 08.12.15 at 15:16, wrote: >> On 12/8/15 1:32 AM, Jan Beulich wrote: >>>>>> On 07.12.15 at 22:27, wrote: >>>> On 12/3/15 2:57 AM, Jan Beulich wrote: >>>>>>>> On 03.12.15 at 01:34, wrote: >>>>>> On 12/1/15 5:22 AM, Jan Beulich wrote: >>>>>>>>>> On 30.11.15 at 18:53, wrote: >>>>>>>> On 11/30/15 8:36 AM, Jan Beulich wrote: >>>>>>>>>>>> On 24.11.15 at 18:51, wrote: >>>>>>>>>> +config ARCH_DEFCONFIG >>>>>>>>>> + string >>>>>>>>>> + default "arch/x86/configs/x86_64_defconfig" >>>>>>>>> >>>>>>>>> x86_defconfig perhaps? >>>>>>>> >>>>>>>> No. I was told to drop support for x86 entirely in an earlier re= view. >>>>>>>> Its not possible to configure for 32-bit x86 in v6. >>>>>>> >>>>>>> x86 !=3D 32-bit. I think you're mixing this up with ix86 or x86-3= 2. >>>>>>> Here I consider x86 as to basic architecture without any >>>>>>> particular bit width in mind. >>>>>> >>>>>> ok. Well the syntax is still "arch/SUBARCH/configs/ARCH_defconfig"= so >>>>>> the original is correct. There is no defconfig for the ambiguous x= 86 >>>>>> family. You're either building for x86_64 or x86_32 (which I refer= red to >>>>>> as x86 in my original response). >>>>>> >>>>>> This defconfig is for the 64-bit architecture of x86 (x86_64) and = there >>>>>> for its named correctly. >>>>> >>>>> But there is no x86_32 architecture form the hypervisor build's >>>>> point of view, and hence x86 isn't ambiguous. In fact the mid-term >>>>> plan is to remove leftovers of references to x86_64 (like the >>>>> arch/x86/x86_64/ or include/asm-x86/x86_64/ directories) where >>>>> possible. The only place they need to be kept are in the public >>>>> interface. >>>> >>>> That's fine but you don't build things for "x86". You build them for= >>>> "x86_64". XEN_TARGET_ARCH takes in "x86_64". >>> >>> The XEN_TARGET_ARCH value is of no interest here. The only fact >>> that I care about is that there's only one x86 configuration, and >>> hence I can't see why it shouldn't be named x86_defconfig. >> >> This is just how the upstream stuff works. Are we forking upstream's >> kconfig just so we can call it "x86" instead of "x86_64"? >=20 > I don't think using >=20 > config ARCH_DEFCONFIG > string > default "arch/x86/configs/x86_defconfig" >=20 > instead of >=20 > config ARCH_DEFCONFIG > string > default "arch/x86/configs/x86_64_defconfig" >=20 > in a Kconfig file of ours is a fork. Or am I overlooking some other > aspect? >=20 > Jan >=20 Its not that simple. When you run "make defconfig" it will default to using "arch/$(SRCARCH)/configs/$(ARCH)_defconfig". Where SRCARCH =3D TARGET_ARCH and ARCH =3D TARGET_SUBARCH =3D XEN_TARGET_ARCH. So to use re= al values from the documentation how to build Xen: - XEN_TARGET_ARCH=3Dx86_64 make defconfig - XEN_TARGET_ARCH=3Darm32 make defconfig - XEN_TARGET_ARCH=3Darm64 make defconfig The result is things build correctly. To make the variable build ups change for x86 vs arm would require us to fork xen/tools/kconfig/Makefile line 101 (potentially others). --=20 Doug Goldstein --VM7v6ICPrvbGfavnHL57Bj9lXED6UnInl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWZxp3XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUfL0QAIusZ5fcPm7vp8HCuFdpMpME +0WnCUJH5smMv/sBojIn2bqpgsPSIrCMTfC0lpeaiWoFr+r4gjEk+ih6SrUUY3Ew 38jvFuYettzWEqCZaRpg/yFTQTmXCRHm9s08VBcAQNLqR1Mi6Iou0HQfEMJMIvAY jsutR8JvplknC9MqMTRoyKtiAPmb6G/hkEB9rF6urk41qfPHsATmyAv4iKeNYX0C HKY7t9ivLQpXPmSnRAHXSGfrPDnc8XxwubsJNNwt/WMoAD2VEgf/YqPfJ4nRVKwU gMDS8xCAQJZgKcgphuxpHtqk3wwdGXGoBFzPwQvwf5M2rCSXkaQuCrU10/8e/zgv tkzvPd85Yqqnq2t7fOklh3K95LKdNCci9U4nxG03yp9zeC8xIRh/moioHMtPnoq7 ESQ/+7E4Qz+FK6Ixhf/bX4b/1b/tMtknMzzd2NNJ/7cMTl1JSnKcBAVOeiiaDYub TD7DXlJliOj0wx6l7cITbI3HI0THU6K4yvEUW6S+sA5MuAtIFocwexNB5g6Iu01+ 24UtV1gE8oa1SuxXjmt8+S1iY3AGQ+3Wq+BGitPfc+F0bZq1JwMTQR6milxGrwZc 6P9qGDoImS4Z7KRrr1kk8vfR3rR/PQPkZa5aaM63SpLUU9C/NLpmFzJKdoepUzxZ Ym1fdqmUVGBzDLsqkBeX =Lp67 -----END PGP SIGNATURE----- --VM7v6ICPrvbGfavnHL57Bj9lXED6UnInl-- --===============4100903528354489831== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============4100903528354489831==--