All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Alex Zuepke <azu@sysgo.de>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
	chouteau@adacore.com
Subject: [Qemu-devel] [PATCH for-2.5] sparc: allow CASA with ASI 0xa from user space
Date: Tue, 8 Dec 2015 11:59:31 -0800	[thread overview]
Message-ID: <566736A3.30503@twiddle.net> (raw)
In-Reply-To: <1449241262-3002-1-git-send-email-azu@sysgo.de>

On 12/04/2015 07:01 AM, Alex Zuepke wrote:
> LEON3 allows the CASA instruction to be used from user space
> if the ASI is set to 0xa (user data).
> 
> Signed-off-by: Alex Zuepke <azu@sysgo.de>
> ---
>  target-sparc/translate.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/target-sparc/translate.c b/target-sparc/translate.c
> index 41a3319..63440dd 100644
> --- a/target-sparc/translate.c
> +++ b/target-sparc/translate.c
> @@ -5097,7 +5097,8 @@ static void disas_sparc_insn(DisasContext * dc, unsigned int insn)
>                      if (IS_IMM) {
>                          goto illegal_insn;
>                      }
> -                    if (!supervisor(dc)) {
> +                    /* LEON3 allows CASA from user space with ASI 0xa */
> +                    if ((GET_FIELD(insn, 19, 26) != 0xa) && !supervisor(dc)) {
>                          goto priv_insn;
>                      }
>  #endif
> 

Reviewed-by: Richard Henderson <rth@twiddle.net>

This should probably be merged for 2.5.

For 2.6, I have a branch with substantial changes for the sparc backend.  Part
of which totally revamps the way ASIs are handled.  I believe it gets this
right.  See

  git://github.com/rth7680/qemu.git tgt-sparc


r~

  parent reply	other threads:[~2015-12-08 19:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-04 15:01 [Qemu-devel] [PATCH] sparc: allow CASA with ASI 0xa from user space Alex Zuepke
2015-12-07 11:35 ` Fabien Chouteau
2015-12-07 12:41   ` "Züpke, Alexander"
2015-12-07 12:56     ` Fabien Chouteau
2015-12-07 13:07       ` "Züpke, Alexander"
2015-12-07 15:03         ` Fabien Chouteau
2015-12-08 19:59 ` Richard Henderson [this message]
2015-12-08 21:28   ` [Qemu-devel] [PATCH for-2.5] " Peter Maydell
2015-12-09 23:24     ` Mark Cave-Ayland
2015-12-10 11:43       ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=566736A3.30503@twiddle.net \
    --to=rth@twiddle.net \
    --cc=azu@sysgo.de \
    --cc=chouteau@adacore.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.