All of lore.kernel.org
 help / color / mirror / Atom feed
From: "André Hentschel" <nerv@dawncrow.de>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] wine: Make the sane-config patch obsolete by using configure flags
Date: Tue, 8 Dec 2015 22:02:28 +0100	[thread overview]
Message-ID: <56674564.70707@dawncrow.de> (raw)
In-Reply-To: <20151208094815.7200558c@free-electrons.com>

Am 08.12.2015 um 09:48 schrieb Thomas Petazzoni:
> Andr?,
> 
> On Mon, 7 Dec 2015 21:39:22 +0100, Andr? Hentschel wrote:
>> Signed-off-by: Andr? Hentschel <nerv@dawncrow.de>
>> ---
>>  package/wine/0003-sane-config-fix.patch | 21 ---------------------
>>  package/wine/wine.mk                    |  3 ++-
>>  2 files changed, 2 insertions(+), 22 deletions(-)
>>  delete mode 100644 package/wine/0003-sane-config-fix.patch
> 
> IMO, this is not the good choice. The patch should be kept and
> submitted upstream. There is absolutely no reason for upstream to
> reject the patch: it simply *adds* the possibility of passing a custom
> sane-config path through SANE_CONFIG, without changing *anything* to
> the existing behavior if SANE_CONFIG is not used.
> 

Hi Thomas,
rebase it, send it to wine-patches at winehq.org (maybe you need to register first, not sure), I'll also sign it off, but I totally doubt it gets in.
One point might be that there's already a way with the variables I used in my patch or that your patch is not generic enough.

  reply	other threads:[~2015-12-08 21:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-07 20:39 [Buildroot] [PATCH 1/2] wine: Make the sane-config patch obsolete by using configure flags André Hentschel
2015-12-08  8:48 ` Thomas Petazzoni
2015-12-08 21:02   ` André Hentschel [this message]
2015-12-22 21:38 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56674564.70707@dawncrow.de \
    --to=nerv@dawncrow.de \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.