From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junxiao Bi Date: Wed, 9 Dec 2015 10:28:17 +0800 Subject: [Ocfs2-devel] [PATCH] ocfs2: fix SGID not inherited issue In-Reply-To: <20151208132215.6efe510a3868e57c9ca2f87a@linux-foundation.org> References: <1449461346-21864-1-git-send-email-junxiao.bi@oracle.com> <20151208132215.6efe510a3868e57c9ca2f87a@linux-foundation.org> Message-ID: <566791C1.6050407@oracle.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ocfs2-devel@oss.oracle.com Hi Andrew, On 12/09/2015 05:22 AM, Andrew Morton wrote: > On Mon, 7 Dec 2015 12:09:06 +0800 Junxiao Bi wrote: > >> commit 8f1eb48758aa ("ocfs2: fix umask ignored issue") introduced an issue, >> SGID of sub dir was not inherited from its parents dir. It is because SGID >> is set into "inode->i_mode" in ocfs2_get_init_inode(), but is overwritten >> by "mode" which don't have SGID set later. >> >> Fixes: 8f1eb48758aa ("ocfs2: fix umask ignored issue") >> Signed-off-by: Junxiao Bi >> Cc: > > 8f1eb48758aa is only in 4.4-rcX so I removed the cc:stable. If 8f1eb48758aa is merged into stable, but this patch not, there will be a regression issue in stable branch? Thanks, Junxiao. >