Re: [PATCH mptcp-next v7 3/6] mptcp: pm: in-kernel: add the subflow-retries limit

[Matthieu Baerts <matttbe@kernel.org>]

On 20/10/2026 05:17, Anil Kaushik wrote:
> A new limit for the in-kernel PM, set and read with the other limits:
> the number of SYN retries of a subflow re-created after an error, like
> the TCP_SYNCNT socket option. 15 by default, about 20 minutes, and 0
> to not re-create it. The netlink policy checks the maximum value,
> MAX_TCP_SYNCNT.
> 
> It is also exposed in struct mptcp_info, in place of the reserved field.
> 
> The next patch uses it.
> 
> Assisted-by: LLM
> Signed-off-by: Anil Kaushik <anilkaushikwireless@gmail.com>
> ---
> 
> Notes:
>     v6:
>      - the netlink policy checks the maximum, no more parse_limit() change
>        (netdev Sashiko)
>      - the limit works like TCP_SYNCNT, say so (netdev Sashiko)

That's a good idea to use netlink policy to check the maximum. Do you
mind adding a patch between the current 1 and 2 to do the same with the
other 2 limits to uniform everything, please?

Either that, or continuing to use parse_limit(), but better not to have
a mix of the two.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.