From: David Ahern <dsa@cumulusnetworks.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, shm@cumulusnetworks.com
Subject: Re: [PATCH net-next v2] net: Add fib rules at vrf device create
Date: Tue, 8 Dec 2015 20:08:31 -0700 [thread overview]
Message-ID: <56679B2F.5080700@cumulusnetworks.com> (raw)
In-Reply-To: <20151208.214411.2137019448940208712.davem@davemloft.net>
On 12/8/15 7:44 PM, David Miller wrote:
> Unfortunately it's too late for this, you should have considered this
> issue fully when VRF first went into an upstream release.
>
> If I add your change, the user experience is _worse_.
>
> Users on older kernels have to use the full sequence, then if they
> upgrade their kernels to one with this patch then the 'ru add' et
> al. commands will fail.
>
Perhaps this is another fug (feature bug), they do not fail:
root@kenny-jessie2:~# ip ru ls
0: from all lookup local
32760: from all iif vrf-green lookup vrf-green
32761: from all oif vrf-green lookup vrf-green
32762: from all iif vrf-blue lookup vrf-blue
32763: from all oif vrf-blue lookup vrf-blue
32764: from all iif vrf-red lookup vrf-red
32765: from all oif vrf-red lookup vrf-red
32766: from all lookup main
32767: from all lookup default
root@kenny-jessie2:~# ip ru add oif vrf-red lookup vrf-red
root@kenny-jessie2:~# ip ru ls
0: from all lookup local
32759: from all oif vrf-red lookup vrf-red
32760: from all iif vrf-green lookup vrf-green
32761: from all oif vrf-green lookup vrf-green
32762: from all iif vrf-blue lookup vrf-blue
32763: from all oif vrf-blue lookup vrf-blue
32764: from all iif vrf-red lookup vrf-red
32765: from all oif vrf-red lookup vrf-red
32766: from all lookup main
32767: from all lookup default
next prev parent reply other threads:[~2015-12-09 3:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 20:48 [PATCH net-next v2] net: Add fib rules at vrf device create David Ahern
2015-12-09 2:44 ` David Miller
2015-12-09 3:08 ` David Ahern [this message]
2015-12-09 3:21 ` David Ahern
2015-12-09 3:41 ` David Miller
2015-12-09 5:17 ` roopa
2015-12-09 3:40 ` David Miller
2015-12-09 13:04 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56679B2F.5080700@cumulusnetworks.com \
--to=dsa@cumulusnetworks.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shm@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.