From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39552) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6VTq-0003yB-6Y for qemu-devel@nongnu.org; Tue, 08 Dec 2015 22:31:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a6VTn-0002Sd-0n for qemu-devel@nongnu.org; Tue, 08 Dec 2015 22:31:50 -0500 Received: from mail-pa0-x230.google.com ([2607:f8b0:400e:c03::230]:33296) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6VTm-0002RH-Sf for qemu-devel@nongnu.org; Tue, 08 Dec 2015 22:31:46 -0500 Received: by pabur14 with SMTP id ur14so22442261pab.0 for ; Tue, 08 Dec 2015 19:31:46 -0800 (PST) References: <1449459280-14983-1-git-send-email-david@gibson.dropbear.id.au> <1449459280-14983-2-git-send-email-david@gibson.dropbear.id.au> From: Alexey Kardashevskiy Message-ID: <5667A09C.3080304@ozlabs.ru> Date: Wed, 9 Dec 2015 14:31:40 +1100 MIME-Version: 1.0 In-Reply-To: <1449459280-14983-2-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv2 01/10] pseries: Remove redundant setting of mc->name for pseries-2.5 machine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , ehabkost@redhat.com, agraf@suse.de, mdroth@linux.vnet.ibm.com Cc: lvivier@redhat.com, thuth@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 12/07/2015 02:34 PM, David Gibson wrote: > 98cec76 "machine: Set MachineClass::name automatically" removed the setting > of mc->name for the pseries machine types, since it can be derived > automatically from the type names constructed with MACHINE_TYPE_NAME(). > > Unfortunately fb0fc8f "spapr: Create pseries-2.5 machine" went in later and > brought one of them back. > > This removes it again. > > Signed-off-by: David Gibson > Reviewed-by: Thomas Huth > --- > hw/ppc/spapr.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index 29a16b7..a69856f 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -2440,7 +2440,6 @@ static void spapr_machine_2_5_class_init(ObjectClass *oc, void *data) > MachineClass *mc = MACHINE_CLASS(oc); > sPAPRMachineClass *smc = SPAPR_MACHINE_CLASS(oc); > > - mc->name = "pseries-2.5"; > mc->desc = "pSeries Logical Partition (PAPR compliant) v2.5"; > mc->alias = "pseries"; > mc->is_default = 1; > Reviewed-by: Alexey Kardashevskiy -- Alexey