From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39908)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1a6VUS-0004u5-5Z
	for qemu-devel@nongnu.org; Tue, 08 Dec 2015 22:32:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1a6VUQ-0003UR-RE
	for qemu-devel@nongnu.org; Tue, 08 Dec 2015 22:32:28 -0500
Received: from mail-pf0-x231.google.com ([2607:f8b0:400e:c00::231]:35102)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1a6VUQ-0003TN-ML
	for qemu-devel@nongnu.org; Tue, 08 Dec 2015 22:32:26 -0500
Received: by pfu207 with SMTP id 207so22557992pfu.2
	for <qemu-devel@nongnu.org>; Tue, 08 Dec 2015 19:32:26 -0800 (PST)
References: <1449459280-14983-1-git-send-email-david@gibson.dropbear.id.au>
	<1449459280-14983-4-git-send-email-david@gibson.dropbear.id.au>
From: Alexey Kardashevskiy <aik@ozlabs.ru>
Message-ID: <5667A0C3.3040601@ozlabs.ru>
Date: Wed, 9 Dec 2015 14:32:19 +1100
MIME-Version: 1.0
In-Reply-To: <1449459280-14983-4-git-send-email-david@gibson.dropbear.id.au>
Content-Type: text/plain; charset=koi8-r; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv2 03/10] pseries: Remove redundant calls to
 spapr_machine_initfn()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Gibson <david@gibson.dropbear.id.au>, ehabkost@redhat.com, agraf@suse.de, mdroth@linux.vnet.ibm.com
Cc: lvivier@redhat.com, thuth@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org

On 12/07/2015 02:34 PM, David Gibson wrote:
> The instance_init() functions for several of the pseries-x.y versioned
> machine types explicitly call spapr_machine_initfn().  But that's the
> instance_init function for the common parent of all those machine types,
> so will already have been called beforehand by the QOM infrastructure.
>
> Remove the redundant calls.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
>   hw/ppc/spapr.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index c126e10..c7c6517 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -2366,7 +2366,6 @@ static void spapr_compat_2_3(Object *obj)
>   static void spapr_machine_2_3_instance_init(Object *obj)
>   {
>       spapr_compat_2_3(obj);
> -    spapr_machine_initfn(obj);
>   }
>
>   static void spapr_machine_2_3_class_init(ObjectClass *oc, void *data)
> @@ -2409,7 +2408,6 @@ static void spapr_compat_2_2(Object *obj)
>   static void spapr_machine_2_2_instance_init(Object *obj)
>   {
>       spapr_compat_2_2(obj);
> -    spapr_machine_initfn(obj);
>   }
>
>   static void spapr_machine_2_2_class_init(ObjectClass *oc, void *data)
> @@ -2446,7 +2444,6 @@ static void spapr_compat_2_1(Object *obj)
>   static void spapr_machine_2_1_instance_init(Object *obj)
>   {
>       spapr_compat_2_1(obj);
> -    spapr_machine_initfn(obj);
>   }
>
>   static void spapr_machine_2_1_class_init(ObjectClass *oc, void *data)
>

Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>	

-- 
Alexey