From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [PATCH v10.1 14/17] drm: bridge: analogix/dp: try force hpd after plug in lookup failed Date: Wed, 9 Dec 2015 13:55:20 +0800 Message-ID: <5667C248.8030605@rock-chips.com> References: <1449470239-30667-1-git-send-email-ykk@rock-chips.com> <1449627039-15689-1-git-send-email-ykk@rock-chips.com> <20151209042540.GA14415@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20151209042540.GA14415@rob-hp-laptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Herring Cc: Krzysztof Kozlowski , Seung-Woo Kim , dri-devel@lists.freedesktop.org, Andrzej Hajda , Gustavo Padovan , linux-samsung-soc@vger.kernel.org, Russell King , javier@osg.samsung.com, Kishon Vijay Abraham I , linux-rockchip@lists.infradead.org, Thierry Reding , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jingoo Han , emil.l.velikov@gmail.com, linux-kernel@vger.kernel.org, Kyungmin Park , ajaynumb@gmail.com, Andy Yan List-Id: linux-rockchip.vger.kernel.org SGkgUm9iLAoKT24gMTIvMDkvMjAxNSAxMjoyNSBQTSwgUm9iIEhlcnJpbmcgd3JvdGU6Cj4gT24g V2VkLCBEZWMgMDksIDIwMTUgYXQgMTA6MTA6MzlBTSArMDgwMCwgWWFraXIgWWFuZyB3cm90ZToK Pj4gU29tZSBlZHAgc2NyZWVuIGRvIG5vdCBoYXZlIGhwZCBzaWduYWwsIHNvIHdlIGNhbid0IGp1 c3QgcmV0dXJuCj4+IGZhaWxlZCB3aGVuIGhwZCBwbHVnIGluIGRldGVjdCBmYWlsZWQuCj4+Cj4+ IFRoaXMgaXMgYW4gaGFyZHdhcmUgcHJvcGVydHksIHNvIHdlIG5lZWQgYWRkIGEgZGV2aWNldHJl ZSBwcm9wZXJ0eQo+PiAiYW5hbG9naXgsbmVlZC1mb3JjZS1ocGQiIHRvIGluZGljYXRlIHRoaXMg c3V0aWF0aW9uLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBZYWtpciBZYW5nIDx5a2tAcm9jay1jaGlw cy5jb20+Cj4+IFRlc3RlZC1ieTogSmF2aWVyIE1hcnRpbmV6IENhbmlsbGFzIDxqYXZpZXJAb3Nn LnNhbXN1bmcuY29tPgo+IEFja2VkLWJ5OiBSb2IgSGVycmluZyA8cm9iaEBrZXJuZWwub3JnPgoK VGhhbmtzLAoKPgo+PiAtLS0KPj4gQ2hhbmdlcyBpbiB2MTAuMToKPj4gLSBSZW5hbWUgdGhlICJh bmFsb2dpeCxuZWVkLWZvcmNlLWhwZCIgdG8gY29tbW9uICdmb3JjZS1ocGQnIChSb2IpCj4+Cj4+ IENoYW5nZXMgaW4gdjk6IE5vbmUKPj4gQ2hhbmdlcyBpbiB2ODogTm9uZQo+PiBDaGFuZ2VzIGlu IHY3OiBOb25lCj4+IENoYW5nZXMgaW4gdjY6IE5vbmUKPj4gQ2hhbmdlcyBpbiB2NTogTm9uZQo+ PiBDaGFuZ2VzIGluIHY0OiBOb25lCj4+IENoYW5nZXMgaW4gdjM6Cj4+IC0gQWRkICJhbmFsb2dp eCxuZWVkLWZvcmNlLWhwZCIgdG8gaW5kaWNhdGUgd2hldGhlciBkcml2ZXIgbmVlZCBmb2NlCj4+ ICAgIGhwZCB3aGVuIGhwZCBkZXRlY3QgZmFpbGVkLgo+Pgo+PiBDaGFuZ2VzIGluIHYyOiBOb25l Cj4+Cj4+ICAgLi4uL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL2FuYWxvZ2l4X2RwLnR4dCAgICAg ICAgfCAgNCArKy0KPj4gICAuLi4vYmluZGluZ3MvZGlzcGxheS9leHlub3MvZXh5bm9zX2RwLnR4 dCAgICAgICAgICB8ICAxICsKPj4gICAuLi4vZGlzcGxheS9yb2NrY2hpcC9hbmFsb2dpeF9kcC1y b2NrY2hpcC50eHQgICAgICB8ICAxICsKPj4gICBkcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2FuYWxv Z2l4L2FuYWxvZ2l4X2RwX2NvcmUuYyB8IDM1ICsrKysrKysrKysrKysrKysrKy0tLS0KPj4gICBk cml2ZXJzL2dwdS9kcm0vYnJpZGdlL2FuYWxvZ2l4L2FuYWxvZ2l4X2RwX2NvcmUuaCB8ICAyICsr Cj4+ICAgZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFsb2dpeC9hbmFsb2dpeF9kcF9yZWcuYyAg fCAgOSArKysrKysKPj4gICA2IGZpbGVzIGNoYW5nZWQsIDQ2IGluc2VydGlvbnMoKyksIDYgZGVs ZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmlu ZGluZ3MvZGlzcGxheS9icmlkZ2UvYW5hbG9naXhfZHAudHh0IGIvRG9jdW1lbnRhdGlvbi9kZXZp Y2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL2FuYWxvZ2l4X2RwLnR4dAo+PiBpbmRleCA3 NjU5YTdhLi40ZjJiYThjIDEwMDY0NAo+PiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUv YmluZGluZ3MvZGlzcGxheS9icmlkZ2UvYW5hbG9naXhfZHAudHh0Cj4+ICsrKyBiL0RvY3VtZW50 YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L2JyaWRnZS9hbmFsb2dpeF9kcC50eHQK Pj4gQEAgLTIyLDYgKzIyLDkgQEAgUmVxdWlyZWQgcHJvcGVydGllcyBmb3IgZHAtY29udHJvbGxl cjoKPj4gICAJCWZyb20gZ2VuZXJhbCBQSFkgYmluZGluZzogU2hvdWxkIGJlICJkcCIuCj4+ICAg Cj4+ICAgT3B0aW9uYWwgcHJvcGVydGllcyBmb3IgZHAtY29udHJvbGxlcjoKPj4gKwktZm9yY2Ut aHBkOgo+PiArCQlJbmRpY2F0ZSBkcml2ZXIgbmVlZCBmb3JjZSBocGQgd2hlbiBocGQgZGV0ZWN0 IGZhaWxlZCwgdGhpcwo+PiArCQlpcyB1c2VkIGZvciBzb21lIGVEUCBzY3JlZW4gd2hpY2ggZG9u J3QgaGF2ZSBocGQgc2lnbmFsLgo+PiAgIAktaHBkLWdwaW9zOgo+PiAgIAkJSG90cGx1ZyBkZXRl Y3QgR1BJTy4KPj4gICAJCUluZGljYXRlcyB3aGljaCBHUElPIHNob3VsZCBiZSB1c2VkIGZvciBo b3RwbHVnIGRldGVjdGlvbgo+PiBAQCAtMzEsNyArMzQsNiBAQCBPcHRpb25hbCBwcm9wZXJ0aWVz IGZvciBkcC1jb250cm9sbGVyOgo+PiAgIAkJKiBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmlu ZGluZ3MvZGlzcGxheS9leHlub3MvZXh5bm9zX2RwLnR4dAo+PiAgIAkJKiBEb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvdmlkZW8vYW5hbG9naXhfZHAtcm9ja2NoaXAudHh0Cj4+ICAg Cj4+IC0KPj4gICBbMV06IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tZWRpYS92 aWRlby1pbnRlcmZhY2VzLnR4dAo+PiAgIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPj4gICAKPj4g ZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L2V4 eW5vcy9leHlub3NfZHAudHh0IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rp c3BsYXkvZXh5bm9zL2V4eW5vc19kcC50eHQKPj4gaW5kZXggOTkwNTA4MS4uODgwMDE2NCAxMDA2 NDQKPj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvZXh5 bm9zL2V4eW5vc19kcC50eHQKPj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL2Rpc3BsYXkvZXh5bm9zL2V4eW5vc19kcC50eHQKPj4gQEAgLTQxLDYgKzQxLDcgQEAgRm9y IHRoZSBiZWxvdyBwcm9wZXJ0aWVzLCBwbGVhc2UgcmVmZXIgdG8gQW5hbG9naXggRFAgYmluZGlu ZyBkb2N1bWVudDoKPj4gICAJLXBoeXMgKHJlcXVpcmVkKQo+PiAgIAktcGh5LW5hbWVzIChyZXF1 aXJlZCkKPj4gICAJLWhwZC1ncGlvcyAob3B0aW9uYWwpCj4+ICsJLWFuYWxvZ2l4LG5lZWQtZm9y Y2UtaHBkIChvcHRpb25hbCkKCkZvcmdldCBhYm91dCB0aGlzIG9uZSwgd2lsbCBzZW5kIHRoZSBu ZXcgdmVyc2lvbiB0byBmaXggdGhpcywgYW5kIGNhcnJ5IAp5b3VyIGFjay4KCgotIFlha2lyCgo+ PiAgIAktdmlkZW8gaW50ZXJmYWNlcyAob3B0aW9uYWwpCj4+ICAgCj4+ICAgRGVwcmVjYXRlZCBw cm9wZXJ0aWVzIGZvciBEaXNwbGF5UG9ydDoKPj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24v ZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3JvY2tjaGlwL2FuYWxvZ2l4X2RwLXJvY2tjaGlw LnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3JvY2tjaGlw L2FuYWxvZ2l4X2RwLXJvY2tjaGlwLnR4dAo+PiBpbmRleCBkYWU4NmM0Li4xODdhNzA4ZSAxMDA2 NDQKPj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvcm9j a2NoaXAvYW5hbG9naXhfZHAtcm9ja2NoaXAudHh0Cj4+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2 aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3JvY2tjaGlwL2FuYWxvZ2l4X2RwLXJvY2tjaGlwLnR4 dAo+PiBAQCAtMzIsNiArMzIsNyBAQCBGb3IgdGhlIGJlbG93IHByb3BlcnRpZXMsIHBsZWFzZSBy ZWZlciB0byBBbmFsb2dpeCBEUCBiaW5kaW5nIGRvY3VtZW50Ogo+PiAgIC0gcGh5cyAocmVxdWly ZWQpCj4+ICAgLSBwaHktbmFtZXMgKHJlcXVpcmVkKQo+PiAgIC0gaHBkLWdwaW9zIChvcHRpb25h bCkKPj4gKy0gZm9yY2UtaHBkIChvcHRpb25hbCkKPj4gICAtLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t Cj4+ICAgCj4+ICAgRXhhbXBsZToKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9icmlk Z2UvYW5hbG9naXgvYW5hbG9naXhfZHBfY29yZS5jIGIvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9h bmFsb2dpeC9hbmFsb2dpeF9kcF9jb3JlLmMKPj4gaW5kZXggYTExNTA0Yi4uMDBhZWU0NCAxMDA2 NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFsb2dpeC9hbmFsb2dpeF9kcF9j b3JlLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFsb2dpeC9hbmFsb2dpeF9k cF9jb3JlLmMKPj4gQEAgLTU5LDE1ICs1OSwzOCBAQCBzdGF0aWMgaW50IGFuYWxvZ2l4X2RwX2Rl dGVjdF9ocGQoc3RydWN0IGFuYWxvZ2l4X2RwX2RldmljZSAqZHApCj4+ICAgewo+PiAgIAlpbnQg dGltZW91dF9sb29wID0gMDsKPj4gICAKPj4gLQl3aGlsZSAoYW5hbG9naXhfZHBfZ2V0X3BsdWdf aW5fc3RhdHVzKGRwKSAhPSAwKSB7Cj4+ICsJd2hpbGUgKHRpbWVvdXRfbG9vcCA8IERQX1RJTUVP VVRfTE9PUF9DT1VOVCkgewo+PiArCQlpZiAoYW5hbG9naXhfZHBfZ2V0X3BsdWdfaW5fc3RhdHVz KGRwKSA9PSAwKQo+PiArCQkJcmV0dXJuIDA7Cj4+ICsKPj4gICAJCXRpbWVvdXRfbG9vcCsrOwo+ PiAtCQlpZiAodGltZW91dF9sb29wID4gRFBfVElNRU9VVF9MT09QX0NPVU5UKSB7Cj4+IC0JCQlk ZXZfZXJyKGRwLT5kZXYsICJmYWlsZWQgdG8gZ2V0IGhwZCBwbHVnIHN0YXR1c1xuIik7Cj4+IC0J CQlyZXR1cm4gLUVUSU1FRE9VVDsKPj4gLQkJfQo+PiAgIAkJdXNsZWVwX3JhbmdlKDEwLCAxMSk7 Cj4+ICAgCX0KPj4gICAKPj4gKwkvKgo+PiArCSAqIFNvbWUgZWRwIHNjcmVlbiBkbyBub3QgaGF2 ZSBocGQgc2lnbmFsLCBzbyB3ZSBjYW4ndCBqdXN0Cj4+ICsJICogcmV0dXJuIGZhaWxlZCB3aGVu IGhwZCBwbHVnIGluIGRldGVjdCBmYWlsZWQsIERUIHByb3BlcnR5Cj4+ICsJICogIm5lZWQtZm9y Y2UtaHBkIiB3b3VsZCBpbmRpY2F0ZSB3aGV0aGVyIGRyaXZlciBuZWVkIHRoaXMuCj4+ICsJICov Cj4+ICsJaWYgKCFkcC0+Zm9yY2VfaHBkKQo+PiArCQlyZXR1cm4gLUVUSU1FRE9VVDsKPj4gKwo+ PiArCS8qCj4+ICsJICogVGhlIGVEUCBUUk0gaW5kaWNhdGUgdGhhdCBpZiBIUERfU1RBVFVTKFJP KSBpcyAwLCBBVVggQ0gKPj4gKwkgKiB3aWxsIG5vdCB3b3JrLCBzbyB3ZSBuZWVkIHRvIGdpdmUg YSBmb3JjZSBocGQgYWN0aW9uIHRvCj4+ICsJICogc2V0IEhQRF9TVEFUVVMgbWFudWFsbHkuCj4+ ICsJICovCj4+ICsJZGV2X2RiZyhkcC0+ZGV2LCAiZmFpbGVkIHRvIGdldCBocGQgcGx1ZyBzdGF0 dXMsIHRyeSB0byBmb3JjZSBocGRcbiIpOwo+PiArCj4+ICsJYW5hbG9naXhfZHBfZm9yY2VfaHBk KGRwKTsKPj4gKwo+PiArCWlmIChhbmFsb2dpeF9kcF9nZXRfcGx1Z19pbl9zdGF0dXMoZHApICE9 IDApIHsKPj4gKwkJZGV2X2VycihkcC0+ZGV2LCAiZmFpbGVkIHRvIGdldCBocGQgcGx1ZyBpbiBz dGF0dXNcbiIpOwo+PiArCQlyZXR1cm4gLUVJTlZBTDsKPj4gKwl9Cj4+ICsKPj4gKwlkZXZfZGJn KGRwLT5kZXYsICJzdWNjZXNzIHRvIGdldCBwbHVnIGluIHN0YXR1cyBhZnRlciBmb3JjZSBocGRc biIpOwo+PiArCj4+ICAgCXJldHVybiAwOwo+PiAgIH0KPj4gICAKPj4gQEAgLTEyNDYsNiArMTI2 OSw4IEBAIGludCBhbmFsb2dpeF9kcF9iaW5kKHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IGRy bV9kZXZpY2UgKmRybV9kZXYsCj4+ICAgCWlmIChJU19FUlIoZHAtPnJlZ19iYXNlKSkKPj4gICAJ CXJldHVybiBQVFJfRVJSKGRwLT5yZWdfYmFzZSk7Cj4+ICAgCj4+ICsJZHAtPmZvcmNlX2hwZCA9 IG9mX3Byb3BlcnR5X3JlYWRfYm9vbChkZXYtPm9mX25vZGUsICJmb3JjZS1ocGQiKTsKPj4gKwo+ PiAgIAlkcC0+aHBkX2dwaW8gPSBvZl9nZXRfbmFtZWRfZ3BpbyhkZXYtPm9mX25vZGUsICJocGQt Z3Bpb3MiLCAwKTsKPj4gICAJaWYgKCFncGlvX2lzX3ZhbGlkKGRwLT5ocGRfZ3BpbykpCj4+ICAg CQlkcC0+aHBkX2dwaW8gPSBvZl9nZXRfbmFtZWRfZ3BpbyhkZXYtPm9mX25vZGUsCj4+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2FuYWxvZ2l4L2FuYWxvZ2l4X2RwX2NvcmUu aCBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9naXgvYW5hbG9naXhfZHBfY29yZS5oCj4+ IGluZGV4IGU2ZjgyNDMuLjA3ZTE0N2MgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9i cmlkZ2UvYW5hbG9naXgvYW5hbG9naXhfZHBfY29yZS5oCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9icmlkZ2UvYW5hbG9naXgvYW5hbG9naXhfZHBfY29yZS5oCj4+IEBAIC0xNjAsNiArMTYwLDcg QEAgc3RydWN0IGFuYWxvZ2l4X2RwX2RldmljZSB7Cj4+ICAgCXN0cnVjdCBwaHkJCSpwaHk7Cj4+ ICAgCWludAkJCWRwbXNfbW9kZTsKPj4gICAJaW50CQkJaHBkX2dwaW87Cj4+ICsJYm9vbCAgICAg ICAgICAgICAgICAgICAgZm9yY2VfaHBkOwo+PiAgIAo+PiAgIAlzdHJ1Y3QgYW5hbG9naXhfZHBf cGxhdF9kYXRhICpwbGF0X2RhdGE7Cj4+ICAgfTsKPj4gQEAgLTE4MCw2ICsxODEsNyBAQCB2b2lk IGFuYWxvZ2l4X2RwX3NldF9hbmFsb2dfcG93ZXJfZG93bihzdHJ1Y3QgYW5hbG9naXhfZHBfZGV2 aWNlICpkcCwKPj4gICAJCQkJICAgICAgIGJvb2wgZW5hYmxlKTsKPj4gICB2b2lkIGFuYWxvZ2l4 X2RwX2luaXRfYW5hbG9nX2Z1bmMoc3RydWN0IGFuYWxvZ2l4X2RwX2RldmljZSAqZHApOwo+PiAg IHZvaWQgYW5hbG9naXhfZHBfaW5pdF9ocGQoc3RydWN0IGFuYWxvZ2l4X2RwX2RldmljZSAqZHAp Owo+PiArdm9pZCBhbmFsb2dpeF9kcF9mb3JjZV9ocGQoc3RydWN0IGFuYWxvZ2l4X2RwX2Rldmlj ZSAqZHApOwo+PiAgIGVudW0gZHBfaXJxX3R5cGUgYW5hbG9naXhfZHBfZ2V0X2lycV90eXBlKHN0 cnVjdCBhbmFsb2dpeF9kcF9kZXZpY2UgKmRwKTsKPj4gICB2b2lkIGFuYWxvZ2l4X2RwX2NsZWFy X2hvdHBsdWdfaW50ZXJydXB0cyhzdHJ1Y3QgYW5hbG9naXhfZHBfZGV2aWNlICpkcCk7Cj4+ICAg dm9pZCBhbmFsb2dpeF9kcF9yZXNldF9hdXgoc3RydWN0IGFuYWxvZ2l4X2RwX2RldmljZSAqZHAp Owo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFsb2dpeC9hbmFsb2dp eF9kcF9yZWcuYyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9naXgvYW5hbG9naXhfZHBf cmVnLmMKPj4gaW5kZXggMjFhMzI4Ny4uYzdlMjk1OSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2JyaWRnZS9hbmFsb2dpeC9hbmFsb2dpeF9kcF9yZWcuYwo+PiArKysgYi9kcml2ZXJz L2dwdS9kcm0vYnJpZGdlL2FuYWxvZ2l4L2FuYWxvZ2l4X2RwX3JlZy5jCj4+IEBAIC0zNjUsNiAr MzY1LDE1IEBAIHZvaWQgYW5hbG9naXhfZHBfaW5pdF9ocGQoc3RydWN0IGFuYWxvZ2l4X2RwX2Rl dmljZSAqZHApCj4+ICAgCXdyaXRlbChyZWcsIGRwLT5yZWdfYmFzZSArIEFOQUxPR0lYX0RQX1NZ U19DVExfMyk7Cj4+ICAgfQo+PiAgIAo+PiArdm9pZCBhbmFsb2dpeF9kcF9mb3JjZV9ocGQoc3Ry dWN0IGFuYWxvZ2l4X2RwX2RldmljZSAqZHApCj4+ICt7Cj4+ICsJdTMyIHJlZzsKPj4gKwo+PiAr CXJlZyA9IHJlYWRsKGRwLT5yZWdfYmFzZSArIEFOQUxPR0lYX0RQX1NZU19DVExfMyk7Cj4+ICsJ cmVnID0gKEZfSFBEIHwgSFBEX0NUUkwpOwo+PiArCXdyaXRlbChyZWcsIGRwLT5yZWdfYmFzZSAr IEFOQUxPR0lYX0RQX1NZU19DVExfMyk7Cj4+ICt9Cj4+ICsKPj4gICBlbnVtIGRwX2lycV90eXBl IGFuYWxvZ2l4X2RwX2dldF9pcnFfdHlwZShzdHJ1Y3QgYW5hbG9naXhfZHBfZGV2aWNlICpkcCkK Pj4gICB7Cj4+ICAgCXUzMiByZWc7Cj4+IC0tIAo+PiAxLjkuMQo+Pgo+Pgo+PiBfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+PiBkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0Cj4+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPj4gaHR0cDovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo+Cj4KCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: ykk@rock-chips.com (Yakir Yang) Date: Wed, 9 Dec 2015 13:55:20 +0800 Subject: [PATCH v10.1 14/17] drm: bridge: analogix/dp: try force hpd after plug in lookup failed In-Reply-To: <20151209042540.GA14415@rob-hp-laptop> References: <1449470239-30667-1-git-send-email-ykk@rock-chips.com> <1449627039-15689-1-git-send-email-ykk@rock-chips.com> <20151209042540.GA14415@rob-hp-laptop> Message-ID: <5667C248.8030605@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Rob, On 12/09/2015 12:25 PM, Rob Herring wrote: > On Wed, Dec 09, 2015 at 10:10:39AM +0800, Yakir Yang wrote: >> Some edp screen do not have hpd signal, so we can't just return >> failed when hpd plug in detect failed. >> >> This is an hardware property, so we need add a devicetree property >> "analogix,need-force-hpd" to indicate this sutiation. >> >> Signed-off-by: Yakir Yang >> Tested-by: Javier Martinez Canillas > Acked-by: Rob Herring Thanks, > >> --- >> Changes in v10.1: >> - Rename the "analogix,need-force-hpd" to common 'force-hpd' (Rob) >> >> Changes in v9: None >> Changes in v8: None >> Changes in v7: None >> Changes in v6: None >> Changes in v5: None >> Changes in v4: None >> Changes in v3: >> - Add "analogix,need-force-hpd" to indicate whether driver need foce >> hpd when hpd detect failed. >> >> Changes in v2: None >> >> .../bindings/display/bridge/analogix_dp.txt | 4 ++- >> .../bindings/display/exynos/exynos_dp.txt | 1 + >> .../display/rockchip/analogix_dp-rockchip.txt | 1 + >> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 35 ++++++++++++++++++---- >> drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 2 ++ >> drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 9 ++++++ >> 6 files changed, 46 insertions(+), 6 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt b/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt >> index 7659a7a..4f2ba8c 100644 >> --- a/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt >> +++ b/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt >> @@ -22,6 +22,9 @@ Required properties for dp-controller: >> from general PHY binding: Should be "dp". >> >> Optional properties for dp-controller: >> + -force-hpd: >> + Indicate driver need force hpd when hpd detect failed, this >> + is used for some eDP screen which don't have hpd signal. >> -hpd-gpios: >> Hotplug detect GPIO. >> Indicates which GPIO should be used for hotplug detection >> @@ -31,7 +34,6 @@ Optional properties for dp-controller: >> * Documentation/devicetree/bindings/display/exynos/exynos_dp.txt >> * Documentation/devicetree/bindings/video/analogix_dp-rockchip.txt >> >> - >> [1]: Documentation/devicetree/bindings/media/video-interfaces.txt >> ------------------------------------------------------------------------------- >> >> diff --git a/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt b/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt >> index 9905081..8800164 100644 >> --- a/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt >> +++ b/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt >> @@ -41,6 +41,7 @@ For the below properties, please refer to Analogix DP binding document: >> -phys (required) >> -phy-names (required) >> -hpd-gpios (optional) >> + -analogix,need-force-hpd (optional) Forget about this one, will send the new version to fix this, and carry your ack. - Yakir >> -video interfaces (optional) >> >> Deprecated properties for DisplayPort: >> diff --git a/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt >> index dae86c4..187a708e 100644 >> --- a/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt >> +++ b/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt >> @@ -32,6 +32,7 @@ For the below properties, please refer to Analogix DP binding document: >> - phys (required) >> - phy-names (required) >> - hpd-gpios (optional) >> +- force-hpd (optional) >> ------------------------------------------------------------------------------- >> >> Example: >> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c >> index a11504b..00aee44 100644 >> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c >> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c >> @@ -59,15 +59,38 @@ static int analogix_dp_detect_hpd(struct analogix_dp_device *dp) >> { >> int timeout_loop = 0; >> >> - while (analogix_dp_get_plug_in_status(dp) != 0) { >> + while (timeout_loop < DP_TIMEOUT_LOOP_COUNT) { >> + if (analogix_dp_get_plug_in_status(dp) == 0) >> + return 0; >> + >> timeout_loop++; >> - if (timeout_loop > DP_TIMEOUT_LOOP_COUNT) { >> - dev_err(dp->dev, "failed to get hpd plug status\n"); >> - return -ETIMEDOUT; >> - } >> usleep_range(10, 11); >> } >> >> + /* >> + * Some edp screen do not have hpd signal, so we can't just >> + * return failed when hpd plug in detect failed, DT property >> + * "need-force-hpd" would indicate whether driver need this. >> + */ >> + if (!dp->force_hpd) >> + return -ETIMEDOUT; >> + >> + /* >> + * The eDP TRM indicate that if HPD_STATUS(RO) is 0, AUX CH >> + * will not work, so we need to give a force hpd action to >> + * set HPD_STATUS manually. >> + */ >> + dev_dbg(dp->dev, "failed to get hpd plug status, try to force hpd\n"); >> + >> + analogix_dp_force_hpd(dp); >> + >> + if (analogix_dp_get_plug_in_status(dp) != 0) { >> + dev_err(dp->dev, "failed to get hpd plug in status\n"); >> + return -EINVAL; >> + } >> + >> + dev_dbg(dp->dev, "success to get plug in status after force hpd\n"); >> + >> return 0; >> } >> >> @@ -1246,6 +1269,8 @@ int analogix_dp_bind(struct device *dev, struct drm_device *drm_dev, >> if (IS_ERR(dp->reg_base)) >> return PTR_ERR(dp->reg_base); >> >> + dp->force_hpd = of_property_read_bool(dev->of_node, "force-hpd"); >> + >> dp->hpd_gpio = of_get_named_gpio(dev->of_node, "hpd-gpios", 0); >> if (!gpio_is_valid(dp->hpd_gpio)) >> dp->hpd_gpio = of_get_named_gpio(dev->of_node, >> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h >> index e6f8243..07e147c 100644 >> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h >> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h >> @@ -160,6 +160,7 @@ struct analogix_dp_device { >> struct phy *phy; >> int dpms_mode; >> int hpd_gpio; >> + bool force_hpd; >> >> struct analogix_dp_plat_data *plat_data; >> }; >> @@ -180,6 +181,7 @@ void analogix_dp_set_analog_power_down(struct analogix_dp_device *dp, >> bool enable); >> void analogix_dp_init_analog_func(struct analogix_dp_device *dp); >> void analogix_dp_init_hpd(struct analogix_dp_device *dp); >> +void analogix_dp_force_hpd(struct analogix_dp_device *dp); >> enum dp_irq_type analogix_dp_get_irq_type(struct analogix_dp_device *dp); >> void analogix_dp_clear_hotplug_interrupts(struct analogix_dp_device *dp); >> void analogix_dp_reset_aux(struct analogix_dp_device *dp); >> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c >> index 21a3287..c7e2959 100644 >> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c >> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c >> @@ -365,6 +365,15 @@ void analogix_dp_init_hpd(struct analogix_dp_device *dp) >> writel(reg, dp->reg_base + ANALOGIX_DP_SYS_CTL_3); >> } >> >> +void analogix_dp_force_hpd(struct analogix_dp_device *dp) >> +{ >> + u32 reg; >> + >> + reg = readl(dp->reg_base + ANALOGIX_DP_SYS_CTL_3); >> + reg = (F_HPD | HPD_CTRL); >> + writel(reg, dp->reg_base + ANALOGIX_DP_SYS_CTL_3); >> +} >> + >> enum dp_irq_type analogix_dp_get_irq_type(struct analogix_dp_device *dp) >> { >> u32 reg; >> -- >> 1.9.1 >> >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel at lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/dri-devel > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751846AbbLIFze (ORCPT ); Wed, 9 Dec 2015 00:55:34 -0500 Received: from lucky1.263xmail.com ([211.157.147.133]:40854 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750920AbbLIFzb (ORCPT ); Wed, 9 Dec 2015 00:55:31 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v10.1 14/17] drm: bridge: analogix/dp: try force hpd after plug in lookup failed To: Rob Herring References: <1449470239-30667-1-git-send-email-ykk@rock-chips.com> <1449627039-15689-1-git-send-email-ykk@rock-chips.com> <20151209042540.GA14415@rob-hp-laptop> Cc: Inki Dae , Mark Yao , Jingoo Han , Heiko Stuebner , devicetree@vger.kernel.org, Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, Russell King , javier@osg.samsung.com, emil.l.velikov@gmail.com, Seung-Woo Kim , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kishon Vijay Abraham I , linux-rockchip@lists.infradead.org, Andrzej Hajda , Kyungmin Park , ajaynumb@gmail.com, Andy Yan , Thierry Reding , Gustavo Padovan , linux-arm-kernel@lists.infradead.org From: Yakir Yang Message-ID: <5667C248.8030605@rock-chips.com> Date: Wed, 9 Dec 2015 13:55:20 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151209042540.GA14415@rob-hp-laptop> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On 12/09/2015 12:25 PM, Rob Herring wrote: > On Wed, Dec 09, 2015 at 10:10:39AM +0800, Yakir Yang wrote: >> Some edp screen do not have hpd signal, so we can't just return >> failed when hpd plug in detect failed. >> >> This is an hardware property, so we need add a devicetree property >> "analogix,need-force-hpd" to indicate this sutiation. >> >> Signed-off-by: Yakir Yang >> Tested-by: Javier Martinez Canillas > Acked-by: Rob Herring Thanks, > >> --- >> Changes in v10.1: >> - Rename the "analogix,need-force-hpd" to common 'force-hpd' (Rob) >> >> Changes in v9: None >> Changes in v8: None >> Changes in v7: None >> Changes in v6: None >> Changes in v5: None >> Changes in v4: None >> Changes in v3: >> - Add "analogix,need-force-hpd" to indicate whether driver need foce >> hpd when hpd detect failed. >> >> Changes in v2: None >> >> .../bindings/display/bridge/analogix_dp.txt | 4 ++- >> .../bindings/display/exynos/exynos_dp.txt | 1 + >> .../display/rockchip/analogix_dp-rockchip.txt | 1 + >> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 35 ++++++++++++++++++---- >> drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 2 ++ >> drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 9 ++++++ >> 6 files changed, 46 insertions(+), 6 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt b/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt >> index 7659a7a..4f2ba8c 100644 >> --- a/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt >> +++ b/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt >> @@ -22,6 +22,9 @@ Required properties for dp-controller: >> from general PHY binding: Should be "dp". >> >> Optional properties for dp-controller: >> + -force-hpd: >> + Indicate driver need force hpd when hpd detect failed, this >> + is used for some eDP screen which don't have hpd signal. >> -hpd-gpios: >> Hotplug detect GPIO. >> Indicates which GPIO should be used for hotplug detection >> @@ -31,7 +34,6 @@ Optional properties for dp-controller: >> * Documentation/devicetree/bindings/display/exynos/exynos_dp.txt >> * Documentation/devicetree/bindings/video/analogix_dp-rockchip.txt >> >> - >> [1]: Documentation/devicetree/bindings/media/video-interfaces.txt >> ------------------------------------------------------------------------------- >> >> diff --git a/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt b/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt >> index 9905081..8800164 100644 >> --- a/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt >> +++ b/Documentation/devicetree/bindings/display/exynos/exynos_dp.txt >> @@ -41,6 +41,7 @@ For the below properties, please refer to Analogix DP binding document: >> -phys (required) >> -phy-names (required) >> -hpd-gpios (optional) >> + -analogix,need-force-hpd (optional) Forget about this one, will send the new version to fix this, and carry your ack. - Yakir >> -video interfaces (optional) >> >> Deprecated properties for DisplayPort: >> diff --git a/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt >> index dae86c4..187a708e 100644 >> --- a/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt >> +++ b/Documentation/devicetree/bindings/display/rockchip/analogix_dp-rockchip.txt >> @@ -32,6 +32,7 @@ For the below properties, please refer to Analogix DP binding document: >> - phys (required) >> - phy-names (required) >> - hpd-gpios (optional) >> +- force-hpd (optional) >> ------------------------------------------------------------------------------- >> >> Example: >> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c >> index a11504b..00aee44 100644 >> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c >> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c >> @@ -59,15 +59,38 @@ static int analogix_dp_detect_hpd(struct analogix_dp_device *dp) >> { >> int timeout_loop = 0; >> >> - while (analogix_dp_get_plug_in_status(dp) != 0) { >> + while (timeout_loop < DP_TIMEOUT_LOOP_COUNT) { >> + if (analogix_dp_get_plug_in_status(dp) == 0) >> + return 0; >> + >> timeout_loop++; >> - if (timeout_loop > DP_TIMEOUT_LOOP_COUNT) { >> - dev_err(dp->dev, "failed to get hpd plug status\n"); >> - return -ETIMEDOUT; >> - } >> usleep_range(10, 11); >> } >> >> + /* >> + * Some edp screen do not have hpd signal, so we can't just >> + * return failed when hpd plug in detect failed, DT property >> + * "need-force-hpd" would indicate whether driver need this. >> + */ >> + if (!dp->force_hpd) >> + return -ETIMEDOUT; >> + >> + /* >> + * The eDP TRM indicate that if HPD_STATUS(RO) is 0, AUX CH >> + * will not work, so we need to give a force hpd action to >> + * set HPD_STATUS manually. >> + */ >> + dev_dbg(dp->dev, "failed to get hpd plug status, try to force hpd\n"); >> + >> + analogix_dp_force_hpd(dp); >> + >> + if (analogix_dp_get_plug_in_status(dp) != 0) { >> + dev_err(dp->dev, "failed to get hpd plug in status\n"); >> + return -EINVAL; >> + } >> + >> + dev_dbg(dp->dev, "success to get plug in status after force hpd\n"); >> + >> return 0; >> } >> >> @@ -1246,6 +1269,8 @@ int analogix_dp_bind(struct device *dev, struct drm_device *drm_dev, >> if (IS_ERR(dp->reg_base)) >> return PTR_ERR(dp->reg_base); >> >> + dp->force_hpd = of_property_read_bool(dev->of_node, "force-hpd"); >> + >> dp->hpd_gpio = of_get_named_gpio(dev->of_node, "hpd-gpios", 0); >> if (!gpio_is_valid(dp->hpd_gpio)) >> dp->hpd_gpio = of_get_named_gpio(dev->of_node, >> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h >> index e6f8243..07e147c 100644 >> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h >> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h >> @@ -160,6 +160,7 @@ struct analogix_dp_device { >> struct phy *phy; >> int dpms_mode; >> int hpd_gpio; >> + bool force_hpd; >> >> struct analogix_dp_plat_data *plat_data; >> }; >> @@ -180,6 +181,7 @@ void analogix_dp_set_analog_power_down(struct analogix_dp_device *dp, >> bool enable); >> void analogix_dp_init_analog_func(struct analogix_dp_device *dp); >> void analogix_dp_init_hpd(struct analogix_dp_device *dp); >> +void analogix_dp_force_hpd(struct analogix_dp_device *dp); >> enum dp_irq_type analogix_dp_get_irq_type(struct analogix_dp_device *dp); >> void analogix_dp_clear_hotplug_interrupts(struct analogix_dp_device *dp); >> void analogix_dp_reset_aux(struct analogix_dp_device *dp); >> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c >> index 21a3287..c7e2959 100644 >> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c >> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c >> @@ -365,6 +365,15 @@ void analogix_dp_init_hpd(struct analogix_dp_device *dp) >> writel(reg, dp->reg_base + ANALOGIX_DP_SYS_CTL_3); >> } >> >> +void analogix_dp_force_hpd(struct analogix_dp_device *dp) >> +{ >> + u32 reg; >> + >> + reg = readl(dp->reg_base + ANALOGIX_DP_SYS_CTL_3); >> + reg = (F_HPD | HPD_CTRL); >> + writel(reg, dp->reg_base + ANALOGIX_DP_SYS_CTL_3); >> +} >> + >> enum dp_irq_type analogix_dp_get_irq_type(struct analogix_dp_device *dp) >> { >> u32 reg; >> -- >> 1.9.1 >> >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/dri-devel > >