From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>,
Eric Blake <eblake@redhat.com>
Cc: libvir-list@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] FD passing for chardevs and chardev backend multiplexing
Date: Wed, 9 Dec 2015 14:11:56 +0100 [thread overview]
Message-ID: <5668289C.7010206@redhat.com> (raw)
In-Reply-To: <20151209111930.GB19914@redhat.com>
On 09/12/2015 12:19, Daniel P. Berrange wrote:
> > > Now in practice this doesn't work, because qmp_chardev_open_file()
> > > passes the O_CREAT|O_TRUNC flags in, which means the qemu_open()
> > > call will fail when using the pipe FD pased in via fdsets.
> >
> > Is it just the O_TRUNC that is failing? If so, there is a recent patch
> > to add an 'append':true flag that switches O_TRUNC off in favor of O_APPEND:
> > https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg00762.html
>
> Yes, it is the ftruncate() call in qemu_dup_flags, called from qemu_open
> that is failing.
It will require a little auditing, but I think ignoring EINVAL from that
fruncate() is fine.
Paolo
prev parent reply other threads:[~2015-12-09 13:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 14:59 [Qemu-devel] FD passing for chardevs and chardev backend multiplexing Daniel P. Berrange
2015-12-08 17:04 ` Eric Blake
2015-12-09 11:19 ` Daniel P. Berrange
2015-12-09 13:11 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5668289C.7010206@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=libvir-list@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.