From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Jarno Rajahalme <jarno@ovn.org>, netdev@vger.kernel.org
Cc: netfilter-devel@vger.kernel.org, dev@openvswitch.org
Subject: Re: [PATCH net-next v4 4/8] openvswitch: Update the CT state key only after nf_conntrack_in().
Date: Wed, 9 Dec 2015 16:40:46 +0300 [thread overview]
Message-ID: <56682F5E.2090006@cogentembedded.com> (raw)
In-Reply-To: <1449622870-48944-5-git-send-email-jarno@ovn.org>
Hello.
On 12/9/2015 4:01 AM, Jarno Rajahalme wrote:
> Only a successful nf_conntrack_in() call can effect a connection state
> change, so if suffices to update the key only after the
> nf_conntrack_in() returns.
>
> This change is needed for the later NAT patches.
>
> Signed-off-by: Jarno Rajahalme <jarno@ovn.org>
> ---
> net/openvswitch/conntrack.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c
> index a28a819..10f4a6e 100644
> --- a/net/openvswitch/conntrack.c
> +++ b/net/openvswitch/conntrack.c
> @@ -194,7 +194,6 @@ static int ovs_ct_set_mark(struct sk_buff *skb, struct sw_flow_key *key,
> struct nf_conn *ct;
> u32 new_mark;
>
> -
Unrelated whitespace change?
[...]
MBR, Sergei
next prev parent reply other threads:[~2015-12-09 13:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 1:01 [PATCH net-next v4 0/8] openvswitch: NAT support Jarno Rajahalme
[not found] ` <1449622870-48944-1-git-send-email-jarno-LZ6Gd1LRuIk@public.gmane.org>
2015-12-09 1:01 ` [PATCH net-next v4 1/8] netfilter: Remove IP_CT_NEW_REPLY definition Jarno Rajahalme
2015-12-09 1:01 ` [PATCH net-next v4 2/8] netfilter: Factor out nf_ct_get_info() Jarno Rajahalme
2015-12-10 19:14 ` Pablo Neira Ayuso
2015-12-10 21:51 ` Jarno Rajahalme
2015-12-09 1:01 ` [PATCH net-next v4 3/8] netfilter: Allow calling into nat helper without skb_dst Jarno Rajahalme
2015-12-09 1:01 ` [PATCH net-next v4 4/8] openvswitch: Update the CT state key only after nf_conntrack_in() Jarno Rajahalme
2015-12-09 13:40 ` Sergei Shtylyov [this message]
2015-12-09 1:01 ` [PATCH net-next v4 5/8] openvswitch: Find existing conntrack entry after upcall Jarno Rajahalme
2015-12-09 1:01 ` [PATCH net-next v4 6/8] openvswitch: Handle NF_REPEAT in conntrack action Jarno Rajahalme
2015-12-09 1:01 ` [PATCH net-next v4 7/8] openvswitch: Delay conntrack helper call for new connections Jarno Rajahalme
2015-12-09 13:44 ` Sergei Shtylyov
2015-12-09 1:01 ` [PATCH net-next v4 8/8] openvswitch: Interface with NAT Jarno Rajahalme
2015-12-10 19:10 ` Pablo Neira Ayuso
2015-12-17 0:54 ` Jarno Rajahalme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56682F5E.2090006@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=dev@openvswitch.org \
--cc=jarno@ovn.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.