From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Sander Eikelenboom <linux@eikelenboom.it>,
Jan Beulich <JBeulich@suse.com>
Cc: David Vrabel <david.vrabel@citrix.com>,
x86@kernel.org, tglx@linutronix.de,
xen-devel@lists.xenproject.org, mingo@redhat.com,
vkuznets@redhat.com, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, hpa@zytor.com
Subject: Re: [Xen-devel] [PATCH] x86: Xen PV guests don't have the rtc_cmos platform device
Date: Wed, 9 Dec 2015 10:15:33 -0500 [thread overview]
Message-ID: <56684595.4040402@oracle.com> (raw)
In-Reply-To: <745827c24ef5e59808d725d5777b5698@eikelenboom.it>
On 12/09/2015 10:00 AM, Sander Eikelenboom wrote:
> On 2015-12-09 15:42, Jan Beulich wrote:
>>>>> On 09.12.15 at 15:32, <boris.ostrovsky@oracle.com> wrote:
>>> --- a/arch/x86/kernel/rtc.c
>>> +++ b/arch/x86/kernel/rtc.c
>>> @@ -200,6 +200,9 @@ static __init int add_rtc_cmos(void)
>>> }
>>> #endif
>>>
>>> + if (paravirt_enabled())
>>> + return -ENODEV;
>>
>> What about Xen Dom0?
>>
>> Jan
>
> Checked that in my testing and that still worked:
> [ 16.733837] rtc_cmos 00:02: RTC can wake from S4
> [ 16.734030] rtc_cmos 00:02: rtc core: registered rtc_cmos as rtc0
> [ 16.734087] rtc_cmos 00:02: alarms up to one month, y3k, 114 bytes
> nvram
> [ 17.760329] rtc_cmos 00:02: setting system clock to 2015-12-09
> 08:43:48 UTC (1449650628)
>
> and /dev/rtc and /dev/rtc0 both exist.
>
> But i don't know the nitty gritty details about why ...
That's because it is discovered by ACPI earlier. I don't know though
whether we can always assume this will be the case.
-boris
next prev parent reply other threads:[~2015-12-09 15:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 14:32 [PATCH] x86: Xen PV guests don't have the rtc_cmos platform device Boris Ostrovsky
2015-12-09 14:42 ` [Xen-devel] " Jan Beulich
2015-12-09 15:00 ` Sander Eikelenboom
2015-12-09 15:00 ` [Xen-devel] " Sander Eikelenboom
2015-12-09 15:15 ` Boris Ostrovsky [this message]
2015-12-09 15:27 ` Jan Beulich
2015-12-09 15:27 ` [Xen-devel] " Jan Beulich
2015-12-09 18:18 ` Boris Ostrovsky
2015-12-09 18:18 ` [Xen-devel] " Boris Ostrovsky
2015-12-09 15:15 ` Boris Ostrovsky
2015-12-09 15:23 ` Vitaly Kuznetsov
2015-12-09 15:23 ` [Xen-devel] " Vitaly Kuznetsov
2015-12-09 14:42 ` Jan Beulich
2015-12-09 14:44 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56684595.4040402@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=JBeulich@suse.com \
--cc=david.vrabel@citrix.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@eikelenboom.it \
--cc=mingo@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.