From: Rhyland Klein <rklein@nvidia.com>
To: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, Johan Hovold <johan@kernel.org>,
Alexandre Courbot <acourbot@nvidia.com>,
Michael Welling <mwelling@ieee.org>,
Markus Pargmann <mpa@pengutronix.de>
Cc: Laxman Dewangan <ldewangan@nvidia.com>
Subject: Re: [PATCH 069/182] gpio: tps65910: use gpiochip data pointer
Date: Wed, 9 Dec 2015 11:25:04 -0500 [thread overview]
Message-ID: <566855E0.9020705@nvidia.com> (raw)
In-Reply-To: <1449667441-619-1-git-send-email-linus.walleij@linaro.org>
On 12/9/2015 8:24 AM, Linus Walleij wrote:
> This makes the driver use the data pointer added to the gpio_chip
> to store a pointer to the state container instead of relying on
> container_of().
>
> Cc: Rhyland Klein <rklein@nvidia.com>
> Cc: Laxman Dewangan <ldewangan@nvidia.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/gpio/gpio-tps65910.c | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpio/gpio-tps65910.c b/drivers/gpio/gpio-tps65910.c
> index 83894c0387fb..e81eee7627a3 100644
> --- a/drivers/gpio/gpio-tps65910.c
> +++ b/drivers/gpio/gpio-tps65910.c
> @@ -27,14 +27,9 @@ struct tps65910_gpio {
> struct tps65910 *tps65910;
> };
>
> -static inline struct tps65910_gpio *to_tps65910_gpio(struct gpio_chip *chip)
> -{
> - return container_of(chip, struct tps65910_gpio, gpio_chip);
> -}
> -
> static int tps65910_gpio_get(struct gpio_chip *gc, unsigned offset)
> {
> - struct tps65910_gpio *tps65910_gpio = to_tps65910_gpio(gc);
> + struct tps65910_gpio *tps65910_gpio = gpiochip_get_data(gc);
> struct tps65910 *tps65910 = tps65910_gpio->tps65910;
> unsigned int val;
>
> @@ -49,7 +44,7 @@ static int tps65910_gpio_get(struct gpio_chip *gc, unsigned offset)
> static void tps65910_gpio_set(struct gpio_chip *gc, unsigned offset,
> int value)
> {
> - struct tps65910_gpio *tps65910_gpio = to_tps65910_gpio(gc);
> + struct tps65910_gpio *tps65910_gpio = gpiochip_get_data(gc);
> struct tps65910 *tps65910 = tps65910_gpio->tps65910;
>
> if (value)
> @@ -63,7 +58,7 @@ static void tps65910_gpio_set(struct gpio_chip *gc, unsigned offset,
> static int tps65910_gpio_output(struct gpio_chip *gc, unsigned offset,
> int value)
> {
> - struct tps65910_gpio *tps65910_gpio = to_tps65910_gpio(gc);
> + struct tps65910_gpio *tps65910_gpio = gpiochip_get_data(gc);
> struct tps65910 *tps65910 = tps65910_gpio->tps65910;
>
> /* Set the initial value */
> @@ -75,7 +70,7 @@ static int tps65910_gpio_output(struct gpio_chip *gc, unsigned offset,
>
> static int tps65910_gpio_input(struct gpio_chip *gc, unsigned offset)
> {
> - struct tps65910_gpio *tps65910_gpio = to_tps65910_gpio(gc);
> + struct tps65910_gpio *tps65910_gpio = gpiochip_get_data(gc);
> struct tps65910 *tps65910 = tps65910_gpio->tps65910;
>
> return tps65910_reg_clear_bits(tps65910, TPS65910_GPIO0 + offset,
> @@ -175,7 +170,7 @@ static int tps65910_gpio_probe(struct platform_device *pdev)
> }
>
> skip_init:
> - ret = gpiochip_add(&tps65910_gpio->gpio_chip);
> + ret = gpiochip_add_data(&tps65910_gpio->gpio_chip, tps65910_gpio);
> if (ret < 0) {
> dev_err(&pdev->dev, "Could not register gpiochip, %d\n", ret);
> return ret;
>
Acked-By: Rhyland Klein <rklein@nvidia.com>
--
nvpublic
next prev parent reply other threads:[~2015-12-09 16:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 13:24 [PATCH 069/182] gpio: tps65910: use gpiochip data pointer Linus Walleij
2015-12-09 16:25 ` Rhyland Klein [this message]
2015-12-22 5:56 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566855E0.9020705@nvidia.com \
--to=rklein@nvidia.com \
--cc=acourbot@nvidia.com \
--cc=johan@kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=mwelling@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.