From: David Daney <ddaney@caviumnetworks.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org, Johan Hovold <johan@kernel.org>,
Alexandre Courbot <acourbot@nvidia.com>,
Michael Welling <mwelling@ieee.org>,
Markus Pargmann <mpa@pengutronix.de>,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH 045/182] gpio: octeon: use gpiochip data pointer
Date: Wed, 9 Dec 2015 09:42:29 -0800 [thread overview]
Message-ID: <56686805.8030804@caviumnetworks.com> (raw)
In-Reply-To: <1449667142-31883-1-git-send-email-linus.walleij@linaro.org>
On 12/09/2015 05:19 AM, Linus Walleij wrote:
> This makes the driver use the data pointer added to the gpio_chip
> to store a pointer to the state container instead of relying on
> container_of().
>
> Cc: David Daney <david.daney@cavium.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This seems sane.
Reviewed-by: David Daney <david.daney@cavium.com>
> ---
> drivers/gpio/gpio-octeon.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpio/gpio-octeon.c b/drivers/gpio/gpio-octeon.c
> index afbb2417dfbc..7665ebcd0c1d 100644
> --- a/drivers/gpio/gpio-octeon.c
> +++ b/drivers/gpio/gpio-octeon.c
> @@ -41,7 +41,7 @@ struct octeon_gpio {
>
> static int octeon_gpio_dir_in(struct gpio_chip *chip, unsigned offset)
> {
> - struct octeon_gpio *gpio = container_of(chip, struct octeon_gpio, chip);
> + struct octeon_gpio *gpio = gpiochip_get_data(chip);
>
> cvmx_write_csr(gpio->register_base + bit_cfg_reg(offset), 0);
> return 0;
> @@ -49,7 +49,7 @@ static int octeon_gpio_dir_in(struct gpio_chip *chip, unsigned offset)
>
> static void octeon_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
> {
> - struct octeon_gpio *gpio = container_of(chip, struct octeon_gpio, chip);
> + struct octeon_gpio *gpio = gpiochip_get_data(chip);
> u64 mask = 1ull << offset;
> u64 reg = gpio->register_base + (value ? TX_SET : TX_CLEAR);
> cvmx_write_csr(reg, mask);
> @@ -58,7 +58,7 @@ static void octeon_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
> static int octeon_gpio_dir_out(struct gpio_chip *chip, unsigned offset,
> int value)
> {
> - struct octeon_gpio *gpio = container_of(chip, struct octeon_gpio, chip);
> + struct octeon_gpio *gpio = gpiochip_get_data(chip);
> union cvmx_gpio_bit_cfgx cfgx;
>
> octeon_gpio_set(chip, offset, value);
> @@ -72,7 +72,7 @@ static int octeon_gpio_dir_out(struct gpio_chip *chip, unsigned offset,
>
> static int octeon_gpio_get(struct gpio_chip *chip, unsigned offset)
> {
> - struct octeon_gpio *gpio = container_of(chip, struct octeon_gpio, chip);
> + struct octeon_gpio *gpio = gpiochip_get_data(chip);
> u64 read_bits = cvmx_read_csr(gpio->register_base + RX_DAT);
>
> return ((1ull << offset) & read_bits) != 0;
> @@ -117,7 +117,7 @@ static int octeon_gpio_probe(struct platform_device *pdev)
> chip->get = octeon_gpio_get;
> chip->direction_output = octeon_gpio_dir_out;
> chip->set = octeon_gpio_set;
> - err = gpiochip_add(chip);
> + err = gpiochip_add_data(chip, gpio);
> if (err)
> goto out;
>
>
prev parent reply other threads:[~2015-12-09 20:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 13:19 [PATCH 045/182] gpio: octeon: use gpiochip data pointer Linus Walleij
2015-12-09 17:42 ` David Daney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56686805.8030804@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=acourbot@nvidia.com \
--cc=david.daney@cavium.com \
--cc=johan@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=mwelling@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.